From: Dan Williams <dan.j.williams@intel.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: Linus Walleij <linus.ml.walleij@gmail.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
"kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH v2] PL330: Add PL330 DMA controller driver
Date: Thu, 25 Mar 2010 08:13:35 -0700 [thread overview]
Message-ID: <4BAB7D9F.4070807@intel.com> (raw)
In-Reply-To: <1b68c6791003250517y4e2789baoe147e5982c363682@mail.gmail.com>
jassi brar wrote:
>> Perhaps Joonyoung can simply port over the stuff
>> you need to this driver if you show your code.
> Having worked on Samsung SoCs(with PL330 DMAC) based products, I would be
> _very_ surprised if any user found this implementation useful.
> Let alone testing, this implementation can't even explain usability
> for fast peripherals
> with shallow FIFOs. I didn't give feedback for this patch because I am
> not sure if this
> is the right way to go at all.
This is the wrong attitude. If it were not for a simple oversight
Joonyoung's driver would already be upstream for the past two kernel
releases. So you need to work together to improve that driver to
incorporate what you need.
It sounds like you just need to add an extension for the arch specific
dma api. At first glance this can mimic the approach taken by
Nobuhiro-san with the shdma driver.
--
Dan
next prev parent reply other threads:[~2010-03-25 15:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 3:17 [PATCH v2] PL330: Add PL330 DMA controller driver Joonyoung Shim
2010-03-25 5:34 ` jassi brar
2010-03-25 8:30 ` Linus Walleij
2010-03-25 12:17 ` jassi brar
2010-03-25 15:13 ` Dan Williams [this message]
2010-03-25 22:27 ` jassi brar
2010-03-25 23:12 ` Dan Williams
2010-03-25 23:59 ` jassi brar
2010-03-26 0:29 ` Kyungmin Park
2010-03-26 0:48 ` jassi brar
2010-03-26 0:54 ` Joonyoung Shim
2010-03-26 1:01 ` jassi brar
2010-03-25 15:20 ` Linus Walleij
2010-03-25 22:36 ` jassi brar
2010-04-01 5:34 ` jassi brar
2010-04-01 23:23 ` Linus Walleij
2010-04-02 1:38 ` jassi brar
2010-04-17 7:06 ` Kyungmin Park
2010-04-19 1:14 ` jassi brar
2010-03-25 5:44 ` Marc Zyngier
2010-03-25 9:01 ` Joonyoung Shim
2010-03-25 9:32 ` Marc Zyngier
2010-03-25 10:05 ` Joonyoung Shim
2010-03-25 10:32 ` Marc Zyngier
2010-03-25 11:48 ` Joonyoung Shim
2010-03-25 8:26 ` Linus Walleij
2010-03-26 2:08 ` jassi brar
2010-03-31 1:07 ` Ben Dooks
2010-03-31 1:40 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAB7D9F.4070807@intel.com \
--to=dan.j.williams@intel.com \
--cc=ben-linux@fluff.org \
--cc=jassisinghbrar@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).