Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last()

Al Viro
2010-03-25T11:00:34Z

On Thu, Mar 25, 2010 at 12:56:40PM +0200, Benny Halevy wrote:
> - if (*want_dir && !path->dentry->d_inode->i_op->lookup)
> + if (*want_dir && !path->dentry->d_inode->i_op->lookup) {
> + WARN_ON(1);
> goto exit_dput;
> + }
> path_to_nameidata(path, nd);
> audit_inode(pathname, nd->path.dentry);
> goto ok;
>
> but it is NOT tripping for this scenario.
>
> (for some reason I saw it tripping when building the kernel over nfs
> but it's benign)

It's ENOTDIR, not EISDIR, anyway. Happens if you ask to open foo/ or
foo with O_DIRECTORY when foo is not a directory.