From: Henrik Kretzschmar <henne@nachtwindheim.de>
To: David Miller <davem@davemloft.net>
Cc: isdn@linux-pingi.de, linux@dominikbrodowski.net,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer
Date: Fri, 26 Mar 2010 01:59:07 +0100 [thread overview]
Message-ID: <4BAC06DB.70800@nachtwindheim.de> (raw)
In-Reply-To: <20100325.115846.00009969.davem@davemloft.net>
David Miller schrieb:
> From: Karsten Keil <isdn@linux-pingi.de>
> Date: Thu, 25 Mar 2010 13:13:18 +0100
>
>
>> On Donnerstag, 25. März 2010 13:05:29 Henrik Kretzschmar wrote:
>>
>>> Compiling this driver gave a section mismatch,
>>> so I reviewed the init/exit paths of the driver
>>> and made the correct changes.
>>>
>>> WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
>>> in reference from the function sedlbauer_config() to the function
>>> .devinit.text:hisax_init_pcmcia()
>>> The function sedlbauer_config() references
>>> the function __devinit hisax_init_pcmcia().
>>> This is often because sedlbauer_config lacks a __devinit
>>> annotation or the annotation of hisax_init_pcmcia is wrong.
>>>
>>> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
>>>
>> Acked-by: <keil@b1-systems.de>
>>
>> Thank you for fixing this.
>>
>
> Thanks for reviewing Karsten.
>
> Please put your proper name in your ACK lines in the
> future, they should look just like Signed-off-by: lines.
>
> I fixed this up when committing, thanks again.
>
>
Hi David,
I've seen that you put the patches on the net-tree. Thats fine.
In the author field my real name "Henrik Kretzschmar" was replaced by "Henne" somehow.
That's not a problem for me, but I just wanted to have you noticed about that.
Greets Henrik
P.S. cc-ing to netdev is okay.
next prev parent reply other threads:[~2010-03-26 0:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 12:05 [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Henrik Kretzschmar
2010-03-25 12:05 ` [PATCH 4/4] isdn: Cleanup Sections in PCMCIA driver elsa Henrik Kretzschmar
2010-03-25 12:16 ` Karsten Keil
2010-03-25 12:15 ` [PATCH 3/4] isdn: Cleanup Sections in PCMCIA driver avma1 Karsten Keil
2010-03-25 12:14 ` [PATCH 2/4] isdn: Cleanup Sections in PCMCIA driver teles Karsten Keil
2010-03-25 12:13 ` [PATCH 1/4] isdn: Cleanup Sections in PCMCIA driver sedlbauer Karsten Keil
2010-03-25 17:02 ` Dominik Brodowski
2010-03-25 18:45 ` David Miller
2010-03-25 18:55 ` David Miller
2010-03-25 18:58 ` David Miller
2010-03-26 0:59 ` Henrik Kretzschmar [this message]
2010-03-26 3:27 ` David Miller
2010-03-26 13:56 ` Henrik Kretzschmar
2010-03-26 16:46 ` David Miller
2010-03-25 12:16 ` Wolfram Sang
2010-03-25 14:05 ` Henrik Kretzschmar
2010-03-25 14:17 ` Wolfram Sang
2010-03-25 14:08 ` Henrik Kretzschmar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAC06DB.70800@nachtwindheim.de \
--to=henne@nachtwindheim.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox