* [PATCH] staging: winbond: wb35tx_s.h Coding style fixes.
@ 2010-03-26 15:03 Lars Lindley
2010-03-26 15:19 ` Dan Carpenter
2010-03-27 6:06 ` Pavel Machek
0 siblings, 2 replies; 4+ messages in thread
From: Lars Lindley @ 2010-03-26 15:03 UTC (permalink / raw)
To: gregkh, greg, penberg, pavel; +Cc: devel, linux-kernel, Lars Lindley
I fixed all reported checkpatch issues.
I also removed versioning comments.
I checked for oopses with Dan Carpenters strip_whitespace.pl
and diff.
Signed-off-by: <lindley@coyote.org>
---
drivers/staging/winbond/wb35tx_s.h | 62 ++++++++++++++++++-----------------
1 files changed, 32 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond/wb35tx_s.h
index f70f433..6799048 100644
--- a/drivers/staging/winbond/wb35tx_s.h
+++ b/drivers/staging/winbond/wb35tx_s.h
@@ -3,45 +3,47 @@
#include "mds_s.h"
-//====================================
-// IS89C35 Tx related definition
-//====================================
-#define TX_INTERFACE 0 // Interface 1
-#define TX_PIPE 3 // endpoint 4
-#define TX_INTERRUPT 1 // endpoint 2
-#define MAX_INTERRUPT_LENGTH 64 // It must be 64 for EP2 hardware
-
-
-
-//====================================
-// Internal variable for module
-//====================================
-
-
+/*
+ * ====================================
+ * IS89C35 Tx related definition
+ * ====================================
+ */
+#define TX_INTERFACE 0 /* Interface 1 */
+#define TX_PIPE 3 /* endpoint 4 */
+#define TX_INTERRUPT 1 /* endpoint 2 */
+#define MAX_INTERRUPT_LENGTH 64 /* It must be 64 for EP2 hardware */
+
+
+
+/*
+ * ====================================
+ * Internal variable for module
+ * ====================================
+ */
struct wb35_tx {
- // For Tx buffer
- u8 TxBuffer[ MAX_USB_TX_BUFFER_NUMBER ][ MAX_USB_TX_BUFFER ];
+ /* For Tx buffer */
+ u8 TxBuffer[MAX_USB_TX_BUFFER_NUMBER][MAX_USB_TX_BUFFER];
- // For Interrupt pipe
- u8 EP2_buf[MAX_INTERRUPT_LENGTH];
+ /* For Interrupt pipe */
+ u8 EP2_buf[MAX_INTERRUPT_LENGTH];
- atomic_t TxResultCount;// For thread control of EP2 931130.4.m
- atomic_t TxFireCounter;// For thread control of EP4 931130.4.n
- u32 ByteTransfer;
+ atomic_t TxResultCount; /* For thread control of EP2 */
+ atomic_t TxFireCounter; /* For thread control of EP4 */
+ u32 ByteTransfer;
- u32 TxSendIndex;// The next index of Mds array to be sent
- u32 EP2vm_state; // for EP2vm state
- u32 EP4vm_state; // for EP4vm state
- u32 tx_halt; // Stopping VM
+ u32 TxSendIndex;/* The next index of Mds array to be sent */
+ u32 EP2vm_state; /* for EP2vm state */
+ u32 EP4vm_state; /* for EP4vm state */
+ u32 tx_halt; /* Stopping VM */
- struct urb * Tx4Urb;
- struct urb * Tx2Urb;
+ struct urb *Tx4Urb;
+ struct urb *Tx2Urb;
int EP2VM_status;
int EP4VM_status;
- u32 TxFillCount; // 20060928
- u32 TxTimer; // 20060928 Add if sending packet not great than 13
+ u32 TxFillCount;
+ u32 TxTimer; /* Add if sending packet not great than 13 */
};
#endif
--
1.7.0.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: winbond: wb35tx_s.h Coding style fixes.
2010-03-26 15:03 [PATCH] staging: winbond: wb35tx_s.h Coding style fixes Lars Lindley
@ 2010-03-26 15:19 ` Dan Carpenter
2010-03-27 6:06 ` Pavel Machek
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-03-26 15:19 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, penberg, pavel, devel, linux-kernel
On Fri, Mar 26, 2010 at 04:03:37PM +0100, Lars Lindley wrote:
> I fixed all reported checkpatch issues.
> I also removed versioning comments.
> I checked for oopses with Dan Carpenters strip_whitespace.pl
> and diff.
>
> Signed-off-by: <lindley@coyote.org>
Acked-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
> ---
> drivers/staging/winbond/wb35tx_s.h | 62 ++++++++++++++++++-----------------
> 1 files changed, 32 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond/wb35tx_s.h
> index f70f433..6799048 100644
> --- a/drivers/staging/winbond/wb35tx_s.h
> +++ b/drivers/staging/winbond/wb35tx_s.h
> @@ -3,45 +3,47 @@
>
> #include "mds_s.h"
>
> -//====================================
> -// IS89C35 Tx related definition
> -//====================================
> -#define TX_INTERFACE 0 // Interface 1
> -#define TX_PIPE 3 // endpoint 4
> -#define TX_INTERRUPT 1 // endpoint 2
> -#define MAX_INTERRUPT_LENGTH 64 // It must be 64 for EP2 hardware
> -
> -
> -
> -//====================================
> -// Internal variable for module
> -//====================================
> -
> -
> +/*
> + * ====================================
> + * IS89C35 Tx related definition
> + * ====================================
> + */
> +#define TX_INTERFACE 0 /* Interface 1 */
> +#define TX_PIPE 3 /* endpoint 4 */
> +#define TX_INTERRUPT 1 /* endpoint 2 */
> +#define MAX_INTERRUPT_LENGTH 64 /* It must be 64 for EP2 hardware */
> +
> +
> +
> +/*
> + * ====================================
> + * Internal variable for module
> + * ====================================
> + */
> struct wb35_tx {
> - // For Tx buffer
> - u8 TxBuffer[ MAX_USB_TX_BUFFER_NUMBER ][ MAX_USB_TX_BUFFER ];
> + /* For Tx buffer */
> + u8 TxBuffer[MAX_USB_TX_BUFFER_NUMBER][MAX_USB_TX_BUFFER];
>
> - // For Interrupt pipe
> - u8 EP2_buf[MAX_INTERRUPT_LENGTH];
> + /* For Interrupt pipe */
> + u8 EP2_buf[MAX_INTERRUPT_LENGTH];
>
> - atomic_t TxResultCount;// For thread control of EP2 931130.4.m
> - atomic_t TxFireCounter;// For thread control of EP4 931130.4.n
> - u32 ByteTransfer;
> + atomic_t TxResultCount; /* For thread control of EP2 */
> + atomic_t TxFireCounter; /* For thread control of EP4 */
> + u32 ByteTransfer;
>
> - u32 TxSendIndex;// The next index of Mds array to be sent
> - u32 EP2vm_state; // for EP2vm state
> - u32 EP4vm_state; // for EP4vm state
> - u32 tx_halt; // Stopping VM
> + u32 TxSendIndex;/* The next index of Mds array to be sent */
> + u32 EP2vm_state; /* for EP2vm state */
> + u32 EP4vm_state; /* for EP4vm state */
> + u32 tx_halt; /* Stopping VM */
>
> - struct urb * Tx4Urb;
> - struct urb * Tx2Urb;
> + struct urb *Tx4Urb;
> + struct urb *Tx2Urb;
>
> int EP2VM_status;
> int EP4VM_status;
>
> - u32 TxFillCount; // 20060928
> - u32 TxTimer; // 20060928 Add if sending packet not great than 13
> + u32 TxFillCount;
> + u32 TxTimer; /* Add if sending packet not great than 13 */
> };
>
> #endif
> --
> 1.7.0.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: winbond: wb35tx_s.h Coding style fixes.
2010-03-26 15:03 [PATCH] staging: winbond: wb35tx_s.h Coding style fixes Lars Lindley
2010-03-26 15:19 ` Dan Carpenter
@ 2010-03-27 6:06 ` Pavel Machek
2010-03-28 6:46 ` Lars Lindley
1 sibling, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2010-03-27 6:06 UTC (permalink / raw)
To: Lars Lindley; +Cc: gregkh, greg, penberg, devel, linux-kernel
On Fri 2010-03-26 16:03:37, Lars Lindley wrote:
> I fixed all reported checkpatch issues.
> I also removed versioning comments.
> I checked for oopses with Dan Carpenters strip_whitespace.pl
> and diff.
>
> Signed-off-by: <lindley@coyote.org>
Please add your name here.
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: winbond: wb35tx_s.h Coding style fixes.
2010-03-27 6:06 ` Pavel Machek
@ 2010-03-28 6:46 ` Lars Lindley
0 siblings, 0 replies; 4+ messages in thread
From: Lars Lindley @ 2010-03-28 6:46 UTC (permalink / raw)
To: Pavel Machek; +Cc: gregkh, greg, penberg, devel, linux-kernel
On 2010-03-27 07:06, Pavel Machek wrote:
> On Fri 2010-03-26 16:03:37, Lars Lindley wrote:
>> I fixed all reported checkpatch issues.
>> I also removed versioning comments.
>> I checked for oopses with Dan Carpenters strip_whitespace.pl
>> and diff.
>>
>> Signed-off-by: <lindley@coyote.org>
>
> Please add your name here.
>
> ACK.
>
Oops.. :)
[PATCH] staging: winbond: wb35tx_s.h Coding style fixes.
I fixed all reported checkpatch issues.
I also removed versioning comments.
I checked for oopses with Dan Carpenters strip_whitespace.pl
and diff.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
---
drivers/staging/winbond/wb35tx_s.h | 62 ++++++++++++++++++-----------------
1 files changed, 32 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond/wb35tx_s.h
index f70f433..6799048 100644
--- a/drivers/staging/winbond/wb35tx_s.h
+++ b/drivers/staging/winbond/wb35tx_s.h
@@ -3,45 +3,47 @@
#include "mds_s.h"
-//====================================
-// IS89C35 Tx related definition
-//====================================
-#define TX_INTERFACE 0 // Interface 1
-#define TX_PIPE 3 // endpoint 4
-#define TX_INTERRUPT 1 // endpoint 2
-#define MAX_INTERRUPT_LENGTH 64 // It must be 64 for EP2 hardware
-
-
-
-//====================================
-// Internal variable for module
-//====================================
-
-
+/*
+ * ====================================
+ * IS89C35 Tx related definition
+ * ====================================
+ */
+#define TX_INTERFACE 0 /* Interface 1 */
+#define TX_PIPE 3 /* endpoint 4 */
+#define TX_INTERRUPT 1 /* endpoint 2 */
+#define MAX_INTERRUPT_LENGTH 64 /* It must be 64 for EP2 hardware */
+
+
+
+/*
+ * ====================================
+ * Internal variable for module
+ * ====================================
+ */
struct wb35_tx {
- // For Tx buffer
- u8 TxBuffer[ MAX_USB_TX_BUFFER_NUMBER ][ MAX_USB_TX_BUFFER ];
+ /* For Tx buffer */
+ u8 TxBuffer[MAX_USB_TX_BUFFER_NUMBER][MAX_USB_TX_BUFFER];
- // For Interrupt pipe
- u8 EP2_buf[MAX_INTERRUPT_LENGTH];
+ /* For Interrupt pipe */
+ u8 EP2_buf[MAX_INTERRUPT_LENGTH];
- atomic_t TxResultCount;// For thread control of EP2 931130.4.m
- atomic_t TxFireCounter;// For thread control of EP4 931130.4.n
- u32 ByteTransfer;
+ atomic_t TxResultCount; /* For thread control of EP2 */
+ atomic_t TxFireCounter; /* For thread control of EP4 */
+ u32 ByteTransfer;
- u32 TxSendIndex;// The next index of Mds array to be sent
- u32 EP2vm_state; // for EP2vm state
- u32 EP4vm_state; // for EP4vm state
- u32 tx_halt; // Stopping VM
+ u32 TxSendIndex;/* The next index of Mds array to be sent */
+ u32 EP2vm_state; /* for EP2vm state */
+ u32 EP4vm_state; /* for EP4vm state */
+ u32 tx_halt; /* Stopping VM */
- struct urb * Tx4Urb;
- struct urb * Tx2Urb;
+ struct urb *Tx4Urb;
+ struct urb *Tx2Urb;
int EP2VM_status;
int EP4VM_status;
- u32 TxFillCount; // 20060928
- u32 TxTimer; // 20060928 Add if sending packet not great than 13
+ u32 TxFillCount;
+ u32 TxTimer; /* Add if sending packet not great than 13 */
};
#endif
--
1.7.0.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-28 7:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-26 15:03 [PATCH] staging: winbond: wb35tx_s.h Coding style fixes Lars Lindley
2010-03-26 15:19 ` Dan Carpenter
2010-03-27 6:06 ` Pavel Machek
2010-03-28 6:46 ` Lars Lindley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox