From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slub: Potential stack overflow
Date: Sun, 28 Mar 2010 20:10:17 +0300 [thread overview]
Message-ID: <4BAF8D79.4090900@cs.helsinki.fi> (raw)
In-Reply-To: <1269465947.2849.21.camel@edumazet-laptop>
Eric Dumazet wrote:
> Le mercredi 24 mars 2010 à 16:14 -0500, Christoph Lameter a écrit :
>> Here is a patch for the second case. I think its better since it results
>> in an error display and it avoids the alloc for each slab. Add this piece
>> to your patch?
>>
>> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
>
> Sure, here is third version :
>
> Thanks
>
> [PATCH] slub: Potential stack overflow
>
> I discovered that we can overflow stack if CONFIG_SLUB_DEBUG=y and use
> slabs with many objects, since list_slab_objects() and process_slab()
> use DECLARE_BITMAP(map, page->objects);
>
> With 65535 bits, we use 8192 bytes of stack ...
>
> Switch these allocations to dynamic allocations.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Applied.
prev parent reply other threads:[~2010-03-28 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 11:40 [PATCH] slub: Potential stack overflow Eric Dumazet
2010-03-24 19:16 ` Christoph Lameter
2010-03-24 19:22 ` Eric Dumazet
2010-03-24 19:49 ` Christoph Lameter
2010-03-24 21:03 ` Eric Dumazet
2010-03-24 21:10 ` Christoph Lameter
2010-03-24 21:14 ` Christoph Lameter
2010-03-24 21:25 ` Christoph Lameter
2010-03-24 21:30 ` Eric Dumazet
2010-03-24 21:25 ` Eric Dumazet
2010-03-25 19:29 ` Pekka Enberg
2010-03-25 21:03 ` Christoph Lameter
2010-03-28 17:10 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAF8D79.4090900@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox