From: Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
To: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
James Bottomley <James.Bottomley@suse.de>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>,
lkml <linux-kernel@vger.kernel.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Subject: [PATCH 1/2 v4] scsi: add __print_hex() to ftrace
Date: Thu, 01 Apr 2010 20:40:58 +0900 [thread overview]
Message-ID: <4BB4864A.3060406@jp.fujitsu.com> (raw)
In-Reply-To: <4BB4855E.7030509@jp.fujitsu.com>
This is the same patch from v1.
__print_hex() prints values in an array in hex (w/o '0x') (space separated)
EX) 92 33 32 f3 ee 4d
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
Signed-off-by: Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
---
linux-2.6.34-rc3-trace-kei/include/linux/ftrace_event.h | 3 +++
linux-2.6.34-rc3-trace-kei/include/trace/ftrace.h | 3 +++
linux-2.6.34-rc3-trace-kei/kernel/trace/trace_output.c | 15 +++++++++++++++
3 files changed, 21 insertions(+)
diff -puN include/linux/ftrace_event.h~add__print_hex_to_ftrace include/linux/ftrace_event.h
--- linux-2.6.34-rc3-trace/include/linux/ftrace_event.h~add__print_hex_to_ftrace 2010-03-31 10:03:14.000000000 +0900
+++ linux-2.6.34-rc3-trace-kei/include/linux/ftrace_event.h 2010-03-31 10:03:14.000000000 +0900
@@ -25,6 +25,9 @@ const char *ftrace_print_flags_seq(struc
const char *ftrace_print_symbols_seq(struct trace_seq *p, unsigned long val,
const struct trace_print_flags *symbol_array);
+const char *ftrace_print_hex_seq(struct trace_seq *p,
+ const unsigned char *buf, int len);
+
/*
* The trace entry - the most basic unit of tracing. This is what
* is printed in the end as a single line in the trace output, such as:
diff -puN include/trace/ftrace.h~add__print_hex_to_ftrace include/trace/ftrace.h
--- linux-2.6.34-rc3-trace/include/trace/ftrace.h~add__print_hex_to_ftrace 2010-03-31 10:03:14.000000000 +0900
+++ linux-2.6.34-rc3-trace-kei/include/trace/ftrace.h 2010-03-31 10:03:14.000000000 +0900
@@ -198,6 +198,9 @@
ftrace_print_symbols_seq(p, value, symbols); \
})
+#undef __print_hex
+#define __print_hex(buf, buf_len) ftrace_print_hex_seq(p, buf, buf_len)
+
#undef DECLARE_EVENT_CLASS
#define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \
static notrace enum print_line_t \
diff -puN kernel/trace/trace_output.c~add__print_hex_to_ftrace kernel/trace/trace_output.c
--- linux-2.6.34-rc3-trace/kernel/trace/trace_output.c~add__print_hex_to_ftrace 2010-03-31 10:03:14.000000000 +0900
+++ linux-2.6.34-rc3-trace-kei/kernel/trace/trace_output.c 2010-04-01 20:38:30.000000000 +0900
@@ -355,6 +355,21 @@ ftrace_print_symbols_seq(struct trace_se
}
EXPORT_SYMBOL(ftrace_print_symbols_seq);
+const char *
+ftrace_print_hex_seq(struct trace_seq *p, const unsigned char *buf, int buf_len)
+{
+ int i;
+ const char *ret = p->buffer + p->len;
+
+ for (i = 0; i < buf_len; i++)
+ trace_seq_printf(p, "%s%2.2x", i == 0 ? "" : " ", buf[i]);
+
+ trace_seq_putc(p, 0);
+
+ return ret;
+}
+EXPORT_SYMBOL(ftrace_print_hex_seq);
+
#ifdef CONFIG_KRETPROBES
static inline const char *kretprobed(const char *name)
{
_
next prev parent reply other threads:[~2010-04-01 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 11:37 [PATCH 0/2 v4] scsi: ftrace based scsi tracer Kei Tokunaga
2010-04-01 11:40 ` Kei Tokunaga [this message]
2010-04-01 13:57 ` [PATCH 1/2 v4] scsi: add __print_hex() to ftrace Steven Rostedt
2010-04-01 17:03 ` Joe Perches
2010-04-02 2:41 ` Li Zefan
2010-04-02 2:40 ` Li Zefan
2010-04-02 2:50 ` Steven Rostedt
2010-04-01 11:41 ` [PATCH 2/2 v4] scsi: add scsi trace core functions and put trace points Kei Tokunaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB4864A.3060406@jp.fujitsu.com \
--to=tokunaga.keiich@jp.fujitsu.com \
--cc=James.Bottomley@suse.de \
--cc=fweisbec@gmail.com \
--cc=kusumi.tomohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=martin.petersen@oracle.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox