* [PATCH] eeepc-wmi: include slab.h
@ 2010-04-05 2:41 Tejun Heo
2010-04-05 12:30 ` Wang, Yong Y
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2010-04-05 2:41 UTC (permalink / raw)
To: lkml; +Cc: Yong Wang
eeepc-wmi uses kfree() but doesn't include slab.h. Include it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Yong Wang <yong.y.wang@intel.com>
---
Hello,
I've committed this patch to percpu#slabh branch which breaks implicit
slab interface availability. I'm gonna push the branch to Linus
soonish.
Thanks.
drivers/platform/x86/eeepc-wmi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
index 2466b7b..9f88226 100644
--- a/drivers/platform/x86/eeepc-wmi.c
+++ b/drivers/platform/x86/eeepc-wmi.c
@@ -27,6 +27,7 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/types.h>
+#include <linux/slab.h>
#include <linux/input.h>
#include <linux/input/sparse-keymap.h>
#include <acpi/acpi_bus.h>
--
1.6.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] eeepc-wmi: include slab.h
2010-04-05 2:41 [PATCH] eeepc-wmi: include slab.h Tejun Heo
@ 2010-04-05 12:30 ` Wang, Yong Y
2010-04-05 14:34 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Wang, Yong Y @ 2010-04-05 12:30 UTC (permalink / raw)
To: Tejun Heo; +Cc: lkml
> From: Tejun Heo [mailto:tj@kernel.org]
> Sent: Monday, April 05, 2010 10:41 AM
> To: lkml
> Cc: Wang, Yong Y
> Subject: [PATCH] eeepc-wmi: include slab.h
>
> eeepc-wmi uses kfree() but doesn't include slab.h. Include it.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Yong Wang <yong.y.wang@intel.com>
> ---
> Hello,
>
> I've committed this patch to percpu#slabh branch which breaks implicit
> slab interface availability. I'm gonna push the branch to Linus
> soonish.
>
> Thanks.
>
> drivers/platform/x86/eeepc-wmi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/eeepc-wmi.c
> b/drivers/platform/x86/eeepc-wmi.c
> index 2466b7b..9f88226 100644
> --- a/drivers/platform/x86/eeepc-wmi.c
> +++ b/drivers/platform/x86/eeepc-wmi.c
> @@ -27,6 +27,7 @@
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/types.h>
> +#include <linux/slab.h>
> #include <linux/input.h>
> #include <linux/input/sparse-keymap.h>
> #include <acpi/acpi_bus.h>
<linux/module.h> includes <linux/percpu.h> which in turn includes <linux/slab.h>.
Doesn't it?
Thanks
-Yong
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] eeepc-wmi: include slab.h
2010-04-05 12:30 ` Wang, Yong Y
@ 2010-04-05 14:34 ` Tejun Heo
0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2010-04-05 14:34 UTC (permalink / raw)
To: Wang, Yong Y; +Cc: lkml
On 04/05/2010 09:30 PM, Wang, Yong Y wrote:
> <linux/module.h> includes <linux/percpu.h> which in turn includes <linux/slab.h>.
> Doesn't it?
Yeah, I'm trying to break that implicit dependency. :-)
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-05 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-05 2:41 [PATCH] eeepc-wmi: include slab.h Tejun Heo
2010-04-05 12:30 ` Wang, Yong Y
2010-04-05 14:34 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox