[PATCH] eeepc-wmi: include slab.h

[PATCH] eeepc-wmi: include slab.h

[Tejun Heo]

eeepc-wmi uses kfree() but doesn't include slab.h.  Include it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Yong Wang <yong.y.wang@intel.com>
---
Hello,

I've committed this patch to percpu#slabh branch which breaks implicit
slab interface availability.  I'm gonna push the branch to Linus
soonish.

Thanks.

 drivers/platform/x86/eeepc-wmi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
index 2466b7b..9f88226 100644
--- a/drivers/platform/x86/eeepc-wmi.c
+++ b/drivers/platform/x86/eeepc-wmi.c
@@ -27,6 +27,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/types.h>
+#include <linux/slab.h>
 #include <linux/input.h>
 #include <linux/input/sparse-keymap.h>
 #include <acpi/acpi_bus.h>
-- 
1.6.4.2

RE: [PATCH] eeepc-wmi: include slab.h

[Wang, Yong Y]

> From: Tejun Heo [mailto:tj@kernel.org]
> Sent: Monday, April 05, 2010 10:41 AM
> To: lkml
> Cc: Wang, Yong Y
> Subject: [PATCH] eeepc-wmi: include slab.h
> 
> eeepc-wmi uses kfree() but doesn't include slab.h.  Include it.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Yong Wang <yong.y.wang@intel.com>
> ---
> Hello,
> 
> I've committed this patch to percpu#slabh branch which breaks implicit
> slab interface availability.  I'm gonna push the branch to Linus
> soonish.
> 
> Thanks.
> 
>  drivers/platform/x86/eeepc-wmi.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/eeepc-wmi.c
> b/drivers/platform/x86/eeepc-wmi.c
> index 2466b7b..9f88226 100644
> --- a/drivers/platform/x86/eeepc-wmi.c
> +++ b/drivers/platform/x86/eeepc-wmi.c
> @@ -27,6 +27,7 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> +#include <linux/slab.h>
>  #include <linux/input.h>
>  #include <linux/input/sparse-keymap.h>
>  #include <acpi/acpi_bus.h>

<linux/module.h> includes <linux/percpu.h> which in turn includes <linux/slab.h>.
Doesn't it?

Thanks
-Yong

Re: [PATCH] eeepc-wmi: include slab.h

[Tejun Heo]

On 04/05/2010 09:30 PM, Wang, Yong Y wrote:
> <linux/module.h> includes <linux/percpu.h> which in turn includes <linux/slab.h>.
> Doesn't it?

Yeah, I'm trying to break that implicit dependency.  :-)

-- 
tejun