From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Avi Kivity <avi@redhat.com>
Cc: Dmitry Torokhov <dtor@vmware.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pv-drivers@vmware.com" <pv-drivers@vmware.com>
Subject: Re: [PATCH] VMware Balloon driver
Date: Tue, 06 Apr 2010 12:18:38 -0700 [thread overview]
Message-ID: <4BBB890E.5040808@goop.org> (raw)
In-Reply-To: <4BBB7F1E.3030307@redhat.com>
On 04/06/2010 11:36 AM, Avi Kivity wrote:
> On 04/06/2010 09:25 PM, Jeremy Fitzhardinge wrote:
>> On 04/06/2010 09:32 AM, Avi Kivity wrote:
>>> Yeah. If we wanted commonality, we could make a balloon_core.c that
>>> contains the common code. IMO that's premature, but perhaps there's
>>> some meat there (like suspend/resume support and /proc//sys interface).
>>
>> I think it would be useful to have common:
>>
>> 1. User and kernel mode ABIs for controlling ballooning. It assumes
>> that the different balloon implementations are sufficiently
>> similar in semantics. (Once there's a kernel ABI, adding a
>> common user ABI is trivial.)
>> 2. Policy driving the ballooning driver, at least from the guest
>> side. That is, some good metrics from the vm subsystem about
>> memory pressure (both positive and negative), and something to
>> turn those metrics into requests to the balloon driver.
>>
>> 1) is not a huge amount of code, but something consistent would be
>> nice. 2) is something we've been missing and is a bit of an open
>> question/research project anyway.
>
> 3) Code that attempts to reclaim 2MB pages when possible
Yes. Ballooning in 4k units is a bit silly.
J
next prev parent reply other threads:[~2010-04-06 19:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 21:52 [PATCH] VMware Balloon driver Dmitry Torokhov
2010-04-05 21:24 ` Andrew Morton
2010-04-05 22:03 ` Jeremy Fitzhardinge
2010-04-05 22:17 ` Andrew Morton
2010-04-05 22:26 ` Avi Kivity
2010-04-05 22:40 ` Andrew Morton
2010-04-05 23:01 ` Dmitry Torokhov
2010-04-05 23:03 ` Dan Magenheimer
2010-04-05 23:11 ` Andrew Morton
2010-04-05 23:28 ` Dmitry Torokhov
2010-04-06 16:28 ` Avi Kivity
2010-04-05 23:28 ` Jeremy Fitzhardinge
2010-04-05 23:34 ` Andrew Morton
2010-04-06 0:26 ` Dan Magenheimer
2010-04-06 16:30 ` Avi Kivity
2010-04-06 17:27 ` Dan Magenheimer
2010-04-06 23:20 ` Dave Hansen
2010-04-05 22:58 ` Dmitry Torokhov
2010-04-06 16:32 ` Avi Kivity
2010-04-06 17:06 ` Dmitry Torokhov
2010-04-06 17:42 ` Avi Kivity
2010-04-06 18:25 ` Jeremy Fitzhardinge
2010-04-06 18:36 ` Avi Kivity
2010-04-06 19:18 ` Jeremy Fitzhardinge [this message]
2010-04-08 5:30 ` Pavel Machek
2010-04-08 7:18 ` Avi Kivity
2010-04-08 17:01 ` Jeremy Fitzhardinge
2010-04-15 21:00 ` [PATCH v2] " Dmitry Torokhov
2010-04-21 19:59 ` Dmitry Torokhov
2010-04-21 20:18 ` Andrew Morton
2010-04-21 20:52 ` Dmitry Torokhov
2010-04-21 21:13 ` Andrew Morton
2010-04-22 0:09 ` Dmitry Torokhov
2010-04-21 23:54 ` Andrew Morton
2010-04-22 0:00 ` Dmitry Torokhov
2010-04-22 1:02 ` [Pv-drivers] " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBB890E.5040808@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=dtor@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox