linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: graff yang <graff.yang@gmail.com>,
	dhowells@redhat.com, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org,
	uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu
Date: Thu, 08 Apr 2010 11:43:10 +0900	[thread overview]
Message-ID: <4BBD42BE.20307@kernel.org> (raw)
In-Reply-To: <y2l4e5ebad51004060228t814129beqd0d90059e247e48d@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Hello, Sonic.

> I tested your patch on NOMMU bf561 with SMP enabled. It is compiled
> and boots without problem. Because there are few percpu data defined
> in bf561 SMP kernel, the functions in mm/percpu-km.c may not be
> executed with a simple test. But, since these functions are simple
> malloc/free, I don't see any problem.

Great, thanks for testing.  Just in case, can you please test with the
attached module?  In test-pcpu.c, the cmds table directs the module
what to allocate and free.  { size > 0, tag } entry makes it allocate
an area with the specified size and tag and { 0, tag } entry makes it
free all areas with the matching tag.  The existing table makes pretty
large amount of allocations and might not work very well on nommu
configuration.  There are also several DEFINE_PER_CPU() instances to
test module static percpu area alloc/free.  Please insmod/rmmod in
loop and make sure it doesn't leak any memory or crashes the machine.

Thanks.

-- 
tejun

[-- Attachment #2: test-pcpu.tar.gz --]
[-- Type: application/x-gzip, Size: 1590 bytes --]

  reply	other threads:[~2010-04-08  2:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19  9:02 [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu graff.yang
2010-03-20  4:06 ` Tejun Heo
2010-03-22  2:33   ` graff yang
2010-04-01 10:20     ` Tejun Heo
2010-04-06  9:28       ` Sonic Zhang
2010-04-08  2:43         ` Tejun Heo [this message]
2010-04-08  9:40           ` Sonic Zhang
2010-04-08 23:33             ` Tejun Heo
2010-03-22  4:14   ` [Uclinux-dist-devel] [PATCH] mm/nommu.c:Dynamic alloc/freepercpu " Zhang, Sonic
2010-03-22 11:50 ` [PATCH] mm/nommu.c:Dynamic alloc/free percpu " David Howells
2010-03-23  2:33   ` graff yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBD42BE.20307@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=graff.yang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sonic.adi@gmail.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).