From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: Rakesh Ranjan <rakesh@chelsio.com>,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kxie@chelsio.com,
davem@davemloft.net, James.Bottomley@hansenpartnership.com
Subject: Re: [PATCH 3/3] cxgb4i: iscsi and pdu processing part
Date: Thu, 08 Apr 2010 14:15:50 -0500 [thread overview]
Message-ID: <4BBE2B66.8090900@cs.wisc.edu> (raw)
In-Reply-To: <1270728855-20951-4-git-send-email-rakesh@chelsio.com>
On 04/08/2010 07:14 AM, Rakesh Ranjan wrote:
> From: Rakesh Ranjan<rakesh@chelsio.com>
>
>
> Signed-off-by: Rakesh Ranjan<rakesh@chelsio.com>
> ---
> drivers/scsi/cxgb4i/cxgb4i_iscsi.c | 715 ++++++++++++++++++++++++++++++++++++
> drivers/scsi/cxgb4i/cxgb4i_pdu.c | 475 ++++++++++++++++++++++++
> drivers/scsi/cxgb4i/cxgb4i_pdu.h | 61 +++
> 3 files changed, 1251 insertions(+), 0 deletions(-)
> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_iscsi.c
> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_pdu.c
> create mode 100644 drivers/scsi/cxgb4i/cxgb4i_pdu.h
>
The code in these files looks like the code is the cxgb3i iscsi and pdu
code. Can you just make a common cxgb3i iscsi/pdu layer and add some
callouts?
Something similar to what qla2xxx or lpfc has done to support multiple
cards. In their case they have common fc and driver stuff and then
callouts for hw specifics?
next prev parent reply other threads:[~2010-04-08 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1270728855-20951-1-git-send-email-rakesh@chelsio.com>
2010-04-08 12:18 ` cxgb4i submission David Miller
2010-04-08 12:41 ` Rakesh Ranjan
[not found] ` <1270728855-20951-2-git-send-email-rakesh@chelsio.com>
[not found] ` <1270728855-20951-3-git-send-email-rakesh@chelsio.com>
[not found] ` <1270728855-20951-4-git-send-email-rakesh@chelsio.com>
2010-04-08 19:15 ` Mike Christie [this message]
2010-04-13 20:41 ` [PATCH 2/3] cxgb4i: main driver files Mike Christie
2010-04-13 21:41 ` Karen Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBE2B66.8090900@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@hansenpartnership.com \
--cc=davem@davemloft.net \
--cc=kxie@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=rakesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox