From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759116Ab0DHVYa (ORCPT ); Thu, 8 Apr 2010 17:24:30 -0400 Received: from LION.SEAS.upenn.edu ([158.130.12.194]:59008 "EHLO lion.seas.upenn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759027Ab0DHVYZ (ORCPT ); Thu, 8 Apr 2010 17:24:25 -0400 Message-ID: <4BBE4969.60802@seas.upenn.edu> Date: Thu, 08 Apr 2010 17:23:53 -0400 From: Rafi Rubin User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Henrik Rydberg CC: Michael Poole , Dmitry Torokhov , Andrew Morton , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: mt: introduce MT event slots References: <1270685590-2204-1-git-send-email-rydberg@euromail.se> <87tyrmiqw2.fsf@troilus.org> <4BBDA555.1020003@euromail.se> <4BBE2B4D.9040808@seas.upenn.edu> <4BBE3BC4.2030503@euromail.se> In-Reply-To: <4BBE3BC4.2030503@euromail.se> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/08/10 16:25, Henrik Rydberg wrote: > Rafi Rubin wrote: >> On 04/08/2010 05:43 AM, Henrik Rydberg wrote: >>> Michael Poole wrote: >>> [...] >>>> >>>> How would the slot number for a contact be chosen? >>> >>> The device driver determines how to use the slots. The driver calls >>> input_mt_slot(dev, slot), sends the data for the slot, picks another >>> slot, and >>> repeats. >>> >> >> Is there any particular downside to defaulting to implicit slot ids? > > Yes. The device driver should not have to update every slot between > synchronizations, or the point would be lost. > >> For drivers/hardware that don't handle tracking, SYN_MT_REPORT could >> just result in dev->slot++ and a SYN_REPORT resets dev->slot to 0; > > Drivers that do not handle tracking should not use the slots at all. The slot > concept requires that whatever gets communicated over it is identifiable, or > else it would not be possible to send changes. Drivers without tracking > capabilities should stick to the current MT protocol, for which it was designed. That's unfortunate. I think tracking upsets are generally quite rare (at least for the n-trig hardware), and we would see most of the benefit of jitter and bandwidth reduction even if we use contact ordering for slots. Tracking upsets would still flow downstream, a large state change should cause the slot to emit the new position. I was also hoping the slotting mechanism might be a good place to inject generic tracking support later. Rafi -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAku+SWcACgkQwuRiAT9o60894wCg1lQIzcFgmUNqUpiKJSDigxNE QVcAn3YylXnlNaieGTJyQ2UblpqR5X7q =EokA -----END PGP SIGNATURE-----