From: Jonathan Cameron <jic23@cam.ac.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: yauhen.kharuzhy@promwad.com, linux-kernel@vger.kernel.org,
Jeff Mahoney <jeffm@suse.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, Sonic Zhang <sonic.adi@gmail.com>
Subject: Re: [PATCH] IIO: Fix adding more than one iio device eventset
Date: Fri, 09 Apr 2010 14:33:56 +0100 [thread overview]
Message-ID: <4BBF2CC4.5000303@cam.ac.uk> (raw)
In-Reply-To: <20100408124843.ed53e39d.akpm@linux-foundation.org>
On 04/08/10 20:48, Andrew Morton wrote:
> On Wed, 07 Apr 2010 19:15:56 +0100
> Jonathan Cameron <jic23@cam.ac.uk> wrote:
>
>> Thanks for the patch. The first bug was fixed by a patch from Sonic Zhang.
>> Andrew Morton picked it up so it is in the mm tree. Thanks for the report
>> of this particularly horrible bug though as had been there quite a while before
>> Sonic pointed it out!
>
> hm. Is it a "horrible bug"? I had assumed that it was a minor bug and
> had staged the patch for 2.6.35. Was that a mistake?
>
It is a bug you will only see if you attempt to bring up two iio devices
with event interfaces at the same time. I've no idea if anyone has a, non-dev
board where this is happening. If you trigger the bug the second devices probe
will fail. So moderately horrible but the problem is fairly self contained.
By the look of it two people have run into the bug (or spotted the problem during
code review?) so probably worth pushing the fix in sooner rather than later.
Thanks,
Jonathan
prev parent reply other threads:[~2010-04-09 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 15:03 [PATCH] IIO: Fix adding more than one iio device eventset yauhen.kharuzhy
2010-04-07 18:15 ` Jonathan Cameron
2010-04-08 19:48 ` Andrew Morton
2010-04-09 13:33 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBF2CC4.5000303@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jeffm@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sonic.adi@gmail.com \
--cc=yauhen.kharuzhy@promwad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox