2.6.34-rc3 doesn't suspend to disk (-rc2 did)

2.6.34-rc3 doesn't suspend to disk (-rc2 did)

[Jiri Kosina]

Hi,

I have just hit this problem. Haven't bisected it yet, and going through 
shortlog doesn't ring any bell immediately, so I am sending this out in 
case it rings a bell for someone right away.

Calling 

	s2disk -r /dev/sdb4

suspends without any issues on 2.6.34-rc2, and resume is also fine. With 
2.6.34-rc3 I get

	s2disk: Could not use the resume device (try swapon -a). Reason: No such device

Relevant part of s2disk strace:

mount("none", "/proc/2449", "tmpfs", 0, NULL) = 0
stat64("/dev/sdb4", {st_mode=S_IFBLK|0660, st_rdev=makedev(259, 65536), ...}) = 0
chdir("/proc/2449")                     = 0
mknod("resume", S_IFBLK|0600, makedev(259, 65536)) = 0
open("resume", O_RDWR|O_LARGEFILE)      = 3
stat64("/dev/snapshot", {st_mode=S_IFCHR|0660, st_rdev=makedev(10, 231), ...}) = 0
open("/dev/snapshot", O_RDONLY|O_LARGEFILE) = 4
ioctl(4, 0x400c330d, 0xbfdbcb04)        = -1 ENODEV (No such device)
ioctl(4, 0x4004330a, 0x10010300)        = -1 ENODEV (No such device)
write(2, "s2disk: Could not use the resume"..., 80s2disk: Could not use the resume device (try swapon -a). Reason: No such device

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: 2.6.34-rc3 doesn't suspend to disk (-rc2 did)

[Rafael J. Wysocki]

On Friday 02 April 2010, Jiri Kosina wrote:
> Hi,

Hi,

> I have just hit this problem. Haven't bisected it yet, and going through 
> shortlog doesn't ring any bell immediately, so I am sending this out in 
> case it rings a bell for someone right away.

No, and it works for me on a couple of systems.

> Calling 
> 
> 	s2disk -r /dev/sdb4
> 
> suspends without any issues on 2.6.34-rc2, and resume is also fine. With 
> 2.6.34-rc3 I get
> 
> 	s2disk: Could not use the resume device (try swapon -a). Reason: No such device
> 
> Relevant part of s2disk strace:
> 
> mount("none", "/proc/2449", "tmpfs", 0, NULL) = 0
> stat64("/dev/sdb4", {st_mode=S_IFBLK|0660, st_rdev=makedev(259, 65536), ...}) = 0
> chdir("/proc/2449")                     = 0
> mknod("resume", S_IFBLK|0600, makedev(259, 65536)) = 0
> open("resume", O_RDWR|O_LARGEFILE)      = 3
> stat64("/dev/snapshot", {st_mode=S_IFCHR|0660, st_rdev=makedev(10, 231), ...}) = 0
> open("/dev/snapshot", O_RDONLY|O_LARGEFILE) = 4
> ioctl(4, 0x400c330d, 0xbfdbcb04)        = -1 ENODEV (No such device)
> ioctl(4, 0x4004330a, 0x10010300)        = -1 ENODEV (No such device)
> write(2, "s2disk: Could not use the resume"..., 80s2disk: Could not use the resume device (try swapon -a). Reason: No such device

It seems that swap_type_of() returns error code for your swap device.

I'd put a couple of debug printks in there to see what happens.

Rafael

Re: 2.6.34-rc3 doesn't suspend to disk (-rc2 did)

[Maciej Rutecki]

On piątek, 2 kwietnia 2010 o 02:19:26 Jiri Kosina wrote:
> Hi,
> 
> I have just hit this problem. Haven't bisected it yet, and going through
> shortlog doesn't ring any bell immediately, so I am sending this out in
> case it rings a bell for someone right away.

I created a Bugzilla entry at 
https://bugzilla.kernel.org/show_bug.cgi?id=15728
for your bug report, please add your address to the CC list in there, thanks!

-- 
Maciej Rutecki
http://www.maciek.unixy.pl

Re: 2.6.34-rc3 doesn't suspend to disk (-rc2 did)

[Jiri Slaby]

On 04/08/2010 08:44 PM, Maciej Rutecki wrote:
> On piątek, 2 kwietnia 2010 o 02:19:26 Jiri Kosina wrote:
>> Hi,
>>
>> I have just hit this problem. Haven't bisected it yet, and going through
>> shortlog doesn't ring any bell immediately, so I am sending this out in
>> case it rings a bell for someone right away.
> 
> I created a Bugzilla entry at 
> https://bugzilla.kernel.org/show_bug.cgi?id=15728

Jiri, could you add there whether you changed config options somehow?
The bug drives me crazy.

thanks,
-- 
js

Re: 2.6.34-rc3 doesn't suspend to disk (-rc2 did)

[Jiri Slaby]

On 04/10/2010 10:42 AM, Jiri Slaby wrote:
> Jiri, could you add there whether you changed config options somehow?
> The bug drives me crazy.

(and check whether the fix there solves your problem or we hit different
issues)

-- 
js

Re: 2.6.34-rc3 doesn't suspend to disk (-rc2 did)

[Jiri Kosina]

On Sat, 10 Apr 2010, Jiri Slaby wrote:

> > Jiri, could you add there whether you changed config options somehow?
> > The bug drives me crazy.
> 
> (and check whether the fix there solves your problem or we hit different
> issues)

Yes, I can confirm that the patch fixes the issue I have been seeing as 
well (I have been testing with different DEBUG_BLOCK_EXT_DEVT setting with 
-rc2 and -rc3).

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.