public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: Rakesh Ranjan <rakesh@chelsio.com>,
	netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, kxie@chelsio.com,
	davem@davemloft.net, James.Bottomley@hansenpartnership.com
Subject: Re: [PATCH 2/3] cxgb4i: main driver files
Date: Tue, 13 Apr 2010 15:41:53 -0500	[thread overview]
Message-ID: <4BC4D711.5030802@cs.wisc.edu> (raw)
In-Reply-To: <1270728855-20951-3-git-send-email-rakesh@chelsio.com>

On 04/08/2010 07:14 AM, Rakesh Ranjan wrote:
> +static inline int cxgb4i_ddp_gl_map(struct pci_dev *pdev,
> +				struct cxgb4i_gather_list *gl)
> +{
> +	int i;
> +
> +	for (i = 0; i<  gl->nelem; i++) {
> +		gl->phys_addr[i] = pci_map_page(pdev, gl->pages[i], 0,
> +						PAGE_SIZE,

Hey Rakesh,

I guess we are trying to move away from the pci mapping functions move 
to the dma ones. On your next submission, could you fix those up too?

  parent reply	other threads:[~2010-04-13 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1270728855-20951-1-git-send-email-rakesh@chelsio.com>
2010-04-08 12:18 ` cxgb4i submission David Miller
2010-04-08 12:41   ` Rakesh Ranjan
     [not found] ` <1270728855-20951-2-git-send-email-rakesh@chelsio.com>
     [not found]   ` <1270728855-20951-3-git-send-email-rakesh@chelsio.com>
     [not found]     ` <1270728855-20951-4-git-send-email-rakesh@chelsio.com>
2010-04-08 19:15       ` [PATCH 3/3] cxgb4i: iscsi and pdu processing part Mike Christie
2010-04-13 20:41     ` Mike Christie [this message]
2010-04-13 21:41       ` [PATCH 2/3] cxgb4i: main driver files Karen Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC4D711.5030802@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=davem@davemloft.net \
    --cc=kxie@chelsio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    --cc=rakesh@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox