Re: [PATCH 6/23] Make register values available to CRIS panic notifiers

David VomLehn
2010-04-14T21:13:15Z

Sam Ravnborg wrote:
> On Sun, Apr 11, 2010 at 11:06:25PM -0700, David VomLehn wrote:
>
>> The save_ptregs() function has not been tested or even built. I will need
>> help to complete this.
>>
>> Signed-off-by: David VomLehn <dvomlehn@cisco.com>
>> ---
>> arch/cris/include/arch-v10/arch/ptrace.h | 80 ++++++++++++++++++++++++++++
>> arch/cris/include/arch-v32/arch/ptrace.h | 84 ++++++++++++++++++++++++++++++
>> 2 files changed, 164 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/cris/include/arch-v10/arch/ptrace.h b/arch/cris/include/arch-v10/arch/ptrace.h
>> index 2f464ea..28be57c 100644
>> --- a/arch/cris/include/arch-v10/arch/ptrace.h
>> +++ b/arch/cris/include/arch-v10/arch/ptrace.h
>> @@ -114,6 +114,86 @@ struct switch_stack {
>> #define profile_pc(regs) instruction_pointer(regs)
>> extern void show_regs(struct pt_regs *);
>>
>> +/* Macros for saving the contents of registers and for the output constraint
>> + * for those registers */
>> +#include "/home/vomlehn/git/kernel.org/ptreg.h"
>>
>
> The above include needs fixing.
> I did not look at the rest of your patches - they may suffer the same.
>
> PS: Your To: is seriously broken, I have to hand-edit Cc:s to send the mail
>
Yes;, and I apologize for this. I've got to track down the reason for
this. before send more
patches.
> Sam
>