From: James Chapman <jchapman@katalix.com>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net/l2tp/l2tp_debugfs.c: Convert NIPQUAD to %pI4
Date: Thu, 15 Apr 2010 19:44:51 +0100 [thread overview]
Message-ID: <4BC75EA3.2070402@katalix.com> (raw)
In-Reply-To: <1271349703.1726.62.camel@Joe-Laptop.home>
Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: James Chapman <jchapman@katalix.com>
> ---
> net/l2tp/l2tp_debugfs.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c
> index 908f10f..104ec3b 100644
> --- a/net/l2tp/l2tp_debugfs.c
> +++ b/net/l2tp/l2tp_debugfs.c
> @@ -122,8 +122,8 @@ static void l2tp_dfs_seq_tunnel_show(struct seq_file *m, void *v)
> seq_printf(m, "\nTUNNEL %u peer %u", tunnel->tunnel_id, tunnel->peer_tunnel_id);
> if (tunnel->sock) {
> struct inet_sock *inet = inet_sk(tunnel->sock);
> - seq_printf(m, " from " NIPQUAD_FMT " to " NIPQUAD_FMT "\n",
> - NIPQUAD(inet->inet_saddr), NIPQUAD(inet->inet_daddr));
> + seq_printf(m, " from %pI4 to %pI4\n",
> + &inet->inet_saddr, &inet->inet_daddr);
> if (tunnel->encap == L2TP_ENCAPTYPE_UDP)
> seq_printf(m, " source port %hu, dest port %hu\n",
> ntohs(inet->inet_sport), ntohs(inet->inet_dport));
>
>
>
next prev parent reply other threads:[~2010-04-15 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 16:41 [PATCH net-next] net/l2tp/l2tp_debugfs.c: Convert NIPQUAD to %pI4 Joe Perches
2010-04-15 18:44 ` James Chapman [this message]
2010-04-15 22:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC75EA3.2070402@katalix.com \
--to=jchapman@katalix.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox