From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: platform-driver-x86@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Cc: "Brown, Len" <len.brown@intel.com>,
Matthew Garrett <mjg@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2 v2] Make BACKLIGHT_CLASS_DEVICE be selected automatically when needed
Date: Sat, 17 Apr 2010 14:54:54 +0200 [thread overview]
Message-ID: <4BC9AF9E.8040902@tremplin-utc.net> (raw)
In-Reply-To: <4BC8FFA4.2090906@tremplin-utc.net>
Here is a new version, compatible with the v2 of PATCH 1.
Eric
8<----------------------------------
Many different modules depend on BACKLIGHT_CLASS_DEVICE, and are
situated in completely different places. In Kconfig, some used to "depend"
on it, while others "selected" it. Excepted for the drivers just below
the option, it's easier for the user to have it automatically
selected whenever needed. So we consistently "select" it for platform
and ACPI drivers.
Signed-off-by: Éric Piel <eric.piel@tremplin-utc.net>
---
drivers/platform/x86/Kconfig | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 28c33e8..de5e99d 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -19,9 +19,9 @@ config ACER_WMI
depends on ACPI
depends on LEDS_CLASS
depends on NEW_LEDS
- depends on BACKLIGHT_CLASS_DEVICE
depends on SERIO_I8042
depends on RFKILL || RFKILL = n
+ select BACKLIGHT_CLASS_DEVICE
select ACPI_WMI
---help---
This is a driver for newer Acer (and Wistron) laptops. It adds
@@ -78,10 +78,10 @@ config DELL_LAPTOP
depends on X86
depends on DCDBAS
depends on EXPERIMENTAL
- depends on BACKLIGHT_CLASS_DEVICE
depends on RFKILL || RFKILL = n
depends on POWER_SUPPLY
depends on SERIO_I8042
+ select BACKLIGHT_CLASS_DEVICE
default n
---help---
This driver adds support for rfkill and backlight control to Dell
@@ -102,8 +102,8 @@ config FUJITSU_LAPTOP
tristate "Fujitsu Laptop Extras"
depends on ACPI
depends on INPUT
- depends on BACKLIGHT_CLASS_DEVICE
depends on LEDS_CLASS || LEDS_CLASS=n
+ select BACKLIGHT_CLASS_DEVICE
---help---
This is a driver for laptops built by Fujitsu:
@@ -151,8 +151,8 @@ config HP_WMI
config MSI_LAPTOP
tristate "MSI Laptop Extras"
depends on ACPI
- depends on BACKLIGHT_CLASS_DEVICE
depends on RFKILL
+ select BACKLIGHT_CLASS_DEVICE
---help---
This is a driver for laptops built by MSI (MICRO-STAR
INTERNATIONAL):
@@ -170,7 +170,7 @@ config MSI_LAPTOP
config PANASONIC_LAPTOP
tristate "Panasonic Laptop Extras"
depends on INPUT && ACPI
- depends on BACKLIGHT_CLASS_DEVICE
+ select BACKLIGHT_CLASS_DEVICE
---help---
This driver adds support for access to backlight control and hotkeys
on Panasonic Let's Note laptops.
@@ -181,8 +181,8 @@ config PANASONIC_LAPTOP
config COMPAL_LAPTOP
tristate "Compal Laptop Extras"
depends on ACPI
- depends on BACKLIGHT_CLASS_DEVICE
depends on RFKILL
+ select BACKLIGHT_CLASS_DEVICE
---help---
This is a driver for laptops built by Compal:
@@ -423,8 +423,8 @@ config ACPI_WMI
config MSI_WMI
tristate "MSI WMI extras"
depends on INPUT
- depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI
+ select BACKLIGHT_CLASS_DEVICE
select ACPI_WMI
select INPUT_SPARSEKMAP
help
--
1.7.0.5
prev parent reply other threads:[~2010-04-17 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 0:24 [PATCH 2/2] Make BACKLIGHT_CLASS_DEVICE be selected automatically when needed Éric Piel
2010-04-17 12:54 ` Éric Piel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC9AF9E.8040902@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox