From: Randy Dunlap <randy.dunlap@oracle.com>
To: John Kacur <jkacur@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: trace-cmd: make Makefile rpm-friendly
Date: Mon, 19 Apr 2010 11:38:13 -0700 [thread overview]
Message-ID: <4BCCA315.3090009@oracle.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1004191942010.4111@localhost.localdomain>
On 04/19/10 11:11, John Kacur wrote:
>
>
> On Mon, 19 Apr 2010, Randy Dunlap wrote:
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Update Makefile to support rpmbuild DESTDIR usage.
>
> So, what would happen if you did
> make DESTDIR=/usr/local install ?
>
> I think you would get /usr/local/usr/local
> So, I think I would NAK this patch.
>
> I also don't believe there is anything magical about DESTDIR in a spec
> file. Essentially, prefix in this makefile is equivalent to DESTDIR, so
> you can replace DESTDIR with prefix in a spec template.
I see. Thanks for your comments.
--
~Randy
next prev parent reply other threads:[~2010-04-19 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 17:00 trace-cmd: make Makefile rpm-friendly Randy Dunlap
2010-04-19 18:11 ` John Kacur
2010-04-19 18:38 ` Randy Dunlap [this message]
2010-04-19 19:06 ` Steven Rostedt
2010-04-19 19:09 ` Randy Dunlap
2010-04-19 20:06 ` John Kacur
2010-04-19 20:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCCA315.3090009@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox