From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Whitespace Coding style fixes.
Date: Wed, 21 Apr 2010 06:26:02 -0700 [thread overview]
Message-ID: <4BCEFCEA.8080509@gmail.com> (raw)
In-Reply-To: <1271835281.1730.274.camel@Joe-Laptop.home>
On 04/21/2010 12:34 AM, Joe Perches wrote:
> On Wed, 2010-04-21 at 00:09 -0700, Justin P. Mattock wrote:
>> On 04/21/2010 12:03 AM, Alexey Dobriyan wrote:
>>> You screw up git-blame.
>> how does this patch screw it up?
>
> Alexey just doesn't like whitespace patches.
>
> Whitespace patches don't really "screw up" git blame.
>
> git blame displays the current version of a file
> with line-by-line commits and the date each line
> was last modified.
>
> So whitespace changes make it harder to find which patch
> introduced the last logical change for a particular line.
>
> A more interactive git blame with history backtracking
> might help keep Alexey happier but who knows for sure...
>
>
ahh.. so after adding this patch,
and committing it in my branch the doing
git blame security/commoncap.c
only shows something from James Morris instead
of what my change had brought.
Alright I can see why it screws things up..
I'll not (L)indent the whole tree then...
Justin P. Mattock
next prev parent reply other threads:[~2010-04-21 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 7:02 [PATCH] Whitespace Coding style fixes Justin P. Mattock
2010-04-21 7:03 ` Alexey Dobriyan
2010-04-21 7:09 ` Justin P. Mattock
2010-04-21 7:34 ` Joe Perches
2010-04-21 12:54 ` Florian Mickler
2010-04-21 13:26 ` Justin P. Mattock [this message]
2010-04-23 0:17 ` James Morris
2010-04-23 5:10 ` Justin P. Mattock
2010-04-23 5:17 ` James Morris
2010-04-23 5:29 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCEFCEA.8080509@gmail.com \
--to=justinmattock@gmail.com \
--cc=adobriyan@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox