From: Larry Finger <Larry.Finger@lwfinger.net>
To: Roel Van Nyen <roel.vannyen@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
"Bartlomiej Zolnierkiewicz devel@driverdev.osuosl.org"
<bzolnier@gmail.com>,
Bernhard Schiffner <bernhard@schiffner-limbach.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: fix coding style errors of r8180_rtl8225z2.c
Date: Thu, 22 Apr 2010 16:52:49 -0500 [thread overview]
Message-ID: <4BD0C531.9050104@lwfinger.net> (raw)
In-Reply-To: <4BD0C19F.3030809@gmail.com>
On 04/22/2010 04:37 PM, Roel Van Nyen wrote:
> Fix coding style errors
>
> Signed-off-by: Roel Van Nyen <roel.vannyen@gmail.com>
>
> ---
>
> drivers/staging/rtl8187se/r8180_rtl8225z2.c | 58 ++++++++++++++-------------
>
> 1 files changed, 30 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_rtl8225z2.c b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>
> index 6edf5a4..9c38b3a 100644
>
> --- a/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>
> +++ b/drivers/staging/rtl8187se/r8180_rtl8225z2.c
>
> @@ -225,7 +225,7 @@ static void rtl8225_SetTXPowerLevel(struct net_device *dev, short ch)
>
> }
>
>
>
> static const u8 rtl8225z2_threshold[] = {
> <========================= HERE
> - 0x8d, 0x8d, 0x8d, 0x8d, 0x9d, 0xad, 0xbd,
>
> + 0x8d, 0x8d, 0x8d, 0x8d, 0x9d, 0xad, 0xbd,
>
> };
NACK: This patch is badly broken. All of the blank lines like the one I
marked above fail.
Larry
next prev parent reply other threads:[~2010-04-22 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 21:37 [PATCH] Staging: rtl8187se: fix coding style errors of r8180_rtl8225z2.c Roel Van Nyen
2010-04-22 21:52 ` Larry Finger [this message]
2010-04-22 22:07 ` Greg KH
2010-04-23 7:15 ` Roel Van Nyen
-- strict thread matches above, loose matches on Subject: below --
2010-04-25 13:18 Roel Van Nyen
2010-04-29 19:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD0C531.9050104@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bernhard@schiffner-limbach.de \
--cc=bzolnier@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.vannyen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox