From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
KVM list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 9/10] KVM MMU: separate invlpg code form kvm_mmu_pte_write()
Date: Mon, 26 Apr 2010 11:13:40 +0800 [thread overview]
Message-ID: <4BD504E4.9080309@cn.fujitsu.com> (raw)
In-Reply-To: <4BD411F6.6030800@redhat.com>
Avi Kivity wrote:
> On 04/25/2010 10:02 AM, Xiao Guangrong wrote:
>> Let invlpg not depends on kvm_mmu_pte_write path, later patch will need
>> this feature
>>
>>
>> if (mmu_topup_memory_caches(vcpu))
>> return;
>> - kvm_mmu_pte_write(vcpu, pte_gpa, NULL, sizeof(pt_element_t), 0);
>> +
>> + kvm_read_guest_page(vcpu->kvm, gfn,&gentry, offset,
>> + sizeof(pt_element_t));
>> +
>>
>
> Need error check.
>
>> + mmu_guess_page_from_pte_write(vcpu, gfn_to_gpa(gfn) + offset,
>> gentry);
>>
>
> This needs an undo operation to drop the page if we don't update_pte();
> see the end of kvm_mmu_pte_write(). That needs to go into a helper to
> avoid duplication.
>
Ah, i forgot those, will fix in v3, thanks for you point out.
next prev parent reply other threads:[~2010-04-26 3:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4BD3E306.4020202@cn.fujitsu.com>
2010-04-25 7:00 ` [PATCH v2 1/10] KVM MMU: fix for calculating gpa in invlpg code Xiao Guangrong
2010-04-25 9:46 ` Avi Kivity
2010-04-26 3:10 ` Xiao Guangrong
2010-04-26 7:39 ` Avi Kivity
2010-04-25 7:00 ` [PATCH v2 2/10] KVM MMU: convert mmu tracepoints Xiao Guangrong
2010-04-25 7:00 ` [PATCH v2 3/10] KVM MMU: move unsync/sync tracpoints to proper place Xiao Guangrong
2010-04-25 7:00 ` [PATCH v2 4/10] KVM MMU: cleanup invlpg code Xiao Guangrong
2010-04-25 7:00 ` [PATCH v2 5/10] KVM MMU: split kvm_sync_page() function Xiao Guangrong
2010-04-25 9:50 ` Avi Kivity
2010-04-26 3:11 ` Xiao Guangrong
2010-04-25 7:00 ` [PATCH v2 6/10] KVM MMU: don't write-protect if have new mapping to unsync page Xiao Guangrong
2010-04-25 10:00 ` Avi Kivity
2010-04-26 3:58 ` Xiao Guangrong
2010-04-26 6:07 ` Avi Kivity
2010-04-25 7:01 ` [PATCH v2 7/10] KVM MMU: allow more page become unsync at gfn mapping time Xiao Guangrong
2010-04-25 7:01 ` [PATCH v2 8/10] KVM MMU: allow more page become unsync at getting sp time Xiao Guangrong
2010-04-25 7:02 ` [PATCH v2 9/10] KVM MMU: separate invlpg code form kvm_mmu_pte_write() Xiao Guangrong
2010-04-25 9:57 ` Avi Kivity
2010-04-26 3:13 ` Xiao Guangrong [this message]
2010-04-25 7:02 ` [PATCH v2 10/10] KVM MMU: optimize sync/update unsync-page Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD504E4.9080309@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox