Re: [PATCH] procfs: fix tid fdinfo

[Jerome Marchand <jmarchan@redhat.com>]

On 04/23/2010 10:07 PM, Miklos Szeredi wrote:
> On Sat, 2010-04-24 at 22:27 +0300, Alexey Dobriyan wrote:
>> On Fri, Apr 23, 2010 at 11:16:20AM -0700, Andrew Morton wrote:
>>> On Fri, 23 Apr 2010 17:40:07 +0200
>>>> -	DIR("fdinfo",    S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fd_operations),
>>>> +	DIR("fdinfo",    S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fdinfo_operations),
>>
>>> hm, the code's been like that for over a year.  What are the
>>> user-visible effects of the bug, and of this change?
>>
>> /proc/*/task/*/fdinfo contains symlinks to opened files like /proc/*/fd/
>> which is cool bug :-)
> 
> Yeah, at least now we can see that someone has started using this
> interface ;)

AFAIK there is still nobody using it, but lsof should use it, and 
/proc/<pid>/task/<tid>/fd/ too. I haven't checked the code, but as it is
now, it doesn't spot files open by a thread which does share its father's
file descriptor table.

> 
> Jerome, thanks for spotting this!
> 
> Miklos
> 
>