From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755287Ab0D1P2b (ORCPT ); Wed, 28 Apr 2010 11:28:31 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:48466 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755251Ab0D1P22 (ORCPT ); Wed, 28 Apr 2010 11:28:28 -0400 Message-ID: <4BD85393.8020400@oracle.com> Date: Wed, 28 Apr 2010 08:26:11 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: Linux-Kernel , Peter Jones , linux-next@vger.kernel.org Subject: Re: linux-next: April 27 (iscsi_ibft) References: <80edf231-ef31-4f21-ab1b-1a21fda35809@default> <20100427230121.GA31743@andromeda.dapyr.net> In-Reply-To: <20100427230121.GA31743@andromeda.dapyr.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090202.4BD8540D.0049:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/10 16:01, Konrad Rzeszutek Wilk wrote: > On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote: >> when CONFIG_ACPI is not enabled: >> >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' >> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type >> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name' > > Yikes. > > Randy, thank you for spotting this and sending an e-mail my way. > > It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which > is gone when !CONFIG_ACPI. > > Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included > a copy of the old ibft_struct that should work. > > Or we make the code dependent on CONFIG_ACPI (in the Kconfig > file). > > Peter, Randy: Which option do you think makes more sense? I think that you and Peter know more about that than I do. I'd go for the Kconfig dependency. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***