From: Randy Dunlap <randy.dunlap@oracle.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Michal Marek <mmarek@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 6/6] xconfig: Add support to show hidden options which have prompts
Date: Thu, 29 Apr 2010 07:40:22 -0700 [thread overview]
Message-ID: <4BD99A56.4070800@oracle.com> (raw)
In-Reply-To: <4BD91FEC.6070903@cn.fujitsu.com>
On 04/28/10 22:58, Li Zefan wrote:
> Randy Dunlap wrote:
>> On Tue, 27 Apr 2010 15:49:30 +0800 Li Zefan wrote:
>>
>>> This feature has been supported in menuconfig and gconfig, so
>>> here add it to xconfig.
>>
>> Looks/sounds reasonable, but it does hide some symbols that were previously displayed
>> when in "Show all options" mode.
>>
>> E.g., CONFIG_64BIT is not displayed at all with this patch applied
>> (except by the Search function).
>> Also, X86_32 is not displayed at all (when this patch is applied)
>> and it cannot be found or displayed by the Search function.
>>
I'm using a kernel source tree with your 12 patches applied.
Should that be OK?
I don't see any of the hidden (no prompt string) symbols from
arch/x86/Kconfig displayed. Or maybe they have just moved, but I can't
locate them.
>
> I don't see this issue, though I found a bug in this patch...
> Could you send me your .config (in private) ?
Done, but the issue is not config-specific.
>> IOW, Show all options mode is busted. :(
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-04-30 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 7:48 [PATCH 1/6] kconfig: print symbol type in help text Li Zefan
2010-04-27 7:48 ` Li Zefan
2010-04-27 20:36 ` Randy Dunlap
2010-04-27 7:48 ` [PATCH 3/6] gconfig: fix to tag NEW symbols correctly Li Zefan
2010-04-27 7:49 ` [PATCH 4/6] gconfig: fix null pointer warning Li Zefan
2010-04-27 20:36 ` Randy Dunlap
2010-04-27 7:49 ` [PATCH 5/6] xconfig: remove unused function Li Zefan
2010-04-27 7:49 ` [PATCH 6/6] xconfig: Add support to show hidden options which have prompts Li Zefan
2010-04-27 20:42 ` Randy Dunlap
[not found] ` <4BD91FEC.6070903@cn.fujitsu.com>
2010-04-29 14:40 ` Randy Dunlap [this message]
[not found] ` <4BDA35AD.6000407@cn.fujitsu.com>
2010-05-03 18:01 ` Randy Dunlap
2010-04-27 20:36 ` [PATCH 1/6] kconfig: print symbol type in help text Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD99A56.4070800@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).