Re: [PATCH 02/30] viafb: use proper pci config API

Florian Tobias Schandinat
2010-05-01T14:01:43Z

Jonathan Corbet schrieb:
> + if (viaparinfo->memsize < 0) {
> + rc = viaparinfo->memsize;
> + goto out_delete_i2c;
> + }

I fear this check is wrong as

struct viafb_par {
...
unsigned int memsize;
...
}

so this check would as far as I see never return true *wonders why gcc
doesn't complain about it*
Feel free to store the result in an integer or cast it back to signed or
whatever solution you like.

Thanks,

Florian Tobias Schandinat