Re: [PATCH 02/30] viafb: use proper pci config API

Jonathan Corbet
2010-05-04T02:37:30Z

[One I never answered]

On Sat, 01 May 2010 16:01:30 +0200
Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:

> I fear this check is wrong as
>
> struct viafb_par {
> ...
> unsigned int memsize;
> ...
> }
>
> so this check would as far as I see never return true *wonders why gcc
> doesn't complain about it*

That is wrong, yes. As it happens, this gets fixed later in the series
when things move into via-core.c. I'd like to say that it's because I
noticed the problem and dealt with it, but you're smarter than that,
alas...

Thanks,

jon