From: Avi Kivity <avi@redhat.com>
To: Shane Wang <shane.wang@intel.com>
Cc: hpa@zytor.com, mingo@elte.hu, joseph.cihula@intel.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] intel_txt: enable VMXON check with SMX in KVM
Date: Sun, 02 May 2010 16:49:30 +0300 [thread overview]
Message-ID: <4BDD82EA.7060308@redhat.com> (raw)
In-Reply-To: <1272557341-3777-1-git-send-email-shane.wang@intel.com>
On 04/29/2010 07:09 PM, Shane Wang wrote:
> Per document, for feature control MSR
> Bit 1 enables VMXON in SMX operation. If the bit is clear, execution of VMXON in SMX operation causes a general-protection exception.
> Bit 2 enables VMXON outside SMX operation. If the bit is clear, execution of VMXON outside SMX operation causes a general-protection exception.
>
> This patch is to enable this kind of check with SMX for VMXON in KVM.
>
>
Looks good.
> @@ -1176,9 +1177,16 @@ static __init int vmx_disabled_by_bios(v
> u64 msr;
>
> rdmsrl(MSR_IA32_FEATURE_CONTROL, msr);
> - return (msr& (FEATURE_CONTROL_LOCKED |
> - FEATURE_CONTROL_VMXON_ENABLED))
> - == FEATURE_CONTROL_LOCKED;
> + if (!!(msr& FEATURE_CONTROL_LOCKED)) {
>
!! not really necessary here (no need to resend, we can fix while applying).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-05-02 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 16:09 [PATCH] intel_txt: enable VMXON check with SMX in KVM Shane Wang
2010-05-02 13:49 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDD82EA.7060308@redhat.com \
--to=avi@redhat.com \
--cc=hpa@zytor.com \
--cc=joseph.cihula@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shane.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox