Re: [PATCH] fs: use kmalloc() to allocate fdmem if possible

Avi Kivity
2010-05-03T07:43:40Z

On 05/03/2010 10:05 AM, Changli Gao wrote:
> On Mon, May 3, 2010 at 2:06 PM, Avi Kivity<avi@redhat.com> wrote:
>
>> My point is, vmalloc() and vfree should do this, not their callers:
>>
>> vmalloc(size):
>> if (size<= PAGE_SIZE)
>> return kmalloc(size, GFP_KERNEL);
>> ...
>>
>> vfree(p):
>> if (!is_vmalloc_addr(p) {
>> kfree(p);
>> return;
>> }
>> ...
>>
> I think we should not change vmalloc/vfree, and you can invent new
> memory APIs, such as malloc()/free().
>

Why?

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.