* linux-next: April 27 (iscsi_ibft)
@ 2010-04-27 16:13 Randy Dunlap
2010-04-27 23:01 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2010-04-27 16:13 UTC (permalink / raw)
To: Linux-Kernel; +Cc: Peter Jones, Konrad Rzeszutek Wilk, linux-next
when CONFIG_ACPI is not enabled:
drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
---
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: April 27 (iscsi_ibft)
2010-04-27 16:13 linux-next: April 27 (iscsi_ibft) Randy Dunlap
@ 2010-04-27 23:01 ` Konrad Rzeszutek Wilk
2010-04-28 15:26 ` Randy Dunlap
2010-05-03 16:01 ` Peter Jones
0 siblings, 2 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2010-04-27 23:01 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linux-Kernel, Peter Jones, Konrad Rzeszutek Wilk, linux-next
On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote:
> when CONFIG_ACPI is not enabled:
>
> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
Yikes.
Randy, thank you for spotting this and sending an e-mail my way.
It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which
is gone when !CONFIG_ACPI.
Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included
a copy of the old ibft_struct that should work.
Or we make the code dependent on CONFIG_ACPI (in the Kconfig
file).
Peter, Randy: Which option do you think makes more sense?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: April 27 (iscsi_ibft)
2010-04-27 23:01 ` Konrad Rzeszutek Wilk
@ 2010-04-28 15:26 ` Randy Dunlap
2010-05-11 17:58 ` Konrad Rzeszutek Wilk
2010-05-03 16:01 ` Peter Jones
1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2010-04-28 15:26 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Linux-Kernel, Peter Jones, linux-next
On 04/27/10 16:01, Konrad Rzeszutek Wilk wrote:
> On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote:
>> when CONFIG_ACPI is not enabled:
>>
>> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
>> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
>> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
>> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
>> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
>
> Yikes.
>
> Randy, thank you for spotting this and sending an e-mail my way.
>
> It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which
> is gone when !CONFIG_ACPI.
>
> Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included
> a copy of the old ibft_struct that should work.
>
> Or we make the code dependent on CONFIG_ACPI (in the Kconfig
> file).
>
> Peter, Randy: Which option do you think makes more sense?
I think that you and Peter know more about that than I do.
I'd go for the Kconfig dependency.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: April 27 (iscsi_ibft)
2010-04-28 15:26 ` Randy Dunlap
@ 2010-05-11 17:58 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2010-05-11 17:58 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Konrad Rzeszutek Wilk, Linux-Kernel, Peter Jones, linux-next
> > It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which
> > is gone when !CONFIG_ACPI.
> >
> > Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included
> > a copy of the old ibft_struct that should work.
> >
> > Or we make the code dependent on CONFIG_ACPI (in the Kconfig
> > file).
> >
> > Peter, Randy: Which option do you think makes more sense?
>
> I think that you and Peter know more about that than I do.
> I'd go for the Kconfig dependency.
Found a way that makes this go away. This is by including #include
<linux/iscsi_ibft.h> in the module and it fixed the problem.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: April 27 (iscsi_ibft)
2010-04-27 23:01 ` Konrad Rzeszutek Wilk
2010-04-28 15:26 ` Randy Dunlap
@ 2010-05-03 16:01 ` Peter Jones
1 sibling, 0 replies; 5+ messages in thread
From: Peter Jones @ 2010-05-03 16:01 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Randy Dunlap, Linux-Kernel, linux-next
On 04/27/2010 07:01 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Apr 27, 2010 at 09:13:16AM -0700, Randy Dunlap wrote:
>> when CONFIG_ACPI is not enabled:
>>
>> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
>> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
>> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
>> drivers/firmware/iscsi_ibft_find.c:112: error: dereferencing pointer to incomplete type
>> drivers/firmware/iscsi_ibft_find.c:112: warning: type defaults to 'int' in declaration of 'type name'
>
> Yikes.
>
> Randy, thank you for spotting this and sending an e-mail my way.
>
> It is all b/c we now use the 'struct acpi_table_ibft *ibft_addr' which
> is gone when !CONFIG_ACPI.
>
> Peter, if we did in an #ifdef !CONFIG_ACPI in iscsi_ibft.h and included
> a copy of the old ibft_struct that should work.
>
> Or we make the code dependent on CONFIG_ACPI (in the Kconfig
> file).
>
> Peter, Randy: Which option do you think makes more sense?
Or we make that one structure be defined whether CONFIG_ACPI is enabled
or not.
--
Peter
For some reason it has always seemed to me that the term software
engineering contains some very optimistic assumptions about the
nature of reality.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-11 18:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-27 16:13 linux-next: April 27 (iscsi_ibft) Randy Dunlap
2010-04-27 23:01 ` Konrad Rzeszutek Wilk
2010-04-28 15:26 ` Randy Dunlap
2010-05-11 17:58 ` Konrad Rzeszutek Wilk
2010-05-03 16:01 ` Peter Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).