From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933704Ab0EDUO3 (ORCPT ); Tue, 4 May 2010 16:14:29 -0400 Received: from terminus.zytor.com ([198.137.202.10]:54623 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933683Ab0EDUO1 (ORCPT ); Tue, 4 May 2010 16:14:27 -0400 Message-ID: <4BE08013.5060402@zytor.com> Date: Tue, 04 May 2010 13:14:11 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Thunderbird/3.0.4 MIME-Version: 1.0 To: Bjorn Helgaas CC: Linus Torvalds , linux-kernel@vger.kernel.org, Jesse Barnes Subject: Re: [PATCH 2/2] vgacon: use request_region(), not request_resource(), to set BUSY References: <20100504185801.7244.39173.stgit@bob.kio> <20100504185806.7244.96960.stgit@bob.kio> <201005041316.51113.bjorn.helgaas@hp.com> In-Reply-To: <201005041316.51113.bjorn.helgaas@hp.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04/2010 12:16 PM, Bjorn Helgaas wrote: > On Tuesday, May 04, 2010 01:09:46 pm Linus Torvalds wrote: >> On Tue, 4 May 2010, Bjorn Helgaas wrote: >>> Drivers normally use request_region() to mark the region busy so it won't >>> be used by anybody else. Previously, we used request_resource(), which >>> doesn't mark the VGA regions busy. >>> >>> Signed-off-by: Bjorn Helgaas >> >> Hmm. I don't object, but unless there is some crazy regression, there's no >> way I will take something like this outside the merge window. Who knows >> what odd frame buffer driver is out there that just depended on the fact >> that it could also register that VGA area? >> >> Probably no such thing exists, but it's why I want these kinds of things >> during the merge window. And obviously preferably through something like >> the PCI merge tree, but that's a different issue. > > Yep, I was intending for after .34. I couldn't figure out where > to send it, but I'll be happy to send it to Jesse. > I would vote for Jesse's tree. If Jesse doesn't want it I'll take it. -hpa