From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934266Ab0EEJRM (ORCPT ); Wed, 5 May 2010 05:17:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48361 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934216Ab0EEJRJ (ORCPT ); Wed, 5 May 2010 05:17:09 -0400 Message-ID: <4BE13872.6050500@redhat.com> Date: Wed, 05 May 2010 17:20:50 +0800 From: Cong Wang User-Agent: Thunderbird 2.0.0.23 (X11/20091001) MIME-Version: 1.0 To: Changli Gao CC: linux-kernel@vger.kernel.org, Octavian Purdila , Eric Dumazet , penguin-kernel@i-love.sakura.ne.jp, netdev@vger.kernel.org, Neil Horman , ebiederm@xmission.com, adobriyan@gmail.com, David Miller Subject: Re: [Patch 2/3] sysctl: add proc_do_large_bitmap References: <20100430082912.5630.82405.sendpatchset@localhost.localdomain> <20100430082936.5630.67682.sendpatchset@localhost.localdomain> <4BE0E27C.7040200@redhat.com> In-Reply-To: <4BE0E27C.7040200@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cong Wang wrote: > Changli Gao wrote: >> add the following lines to let "echo 1-10 >> >> /proc/..." work as normal. > > Hmm, I haven't tested this, what did you see if we append > lines into it? > > Also, do we need appending lines to this /proc file when design it? > Octavian? Eric? > Hmm, currently this behaves like other /proc files, IOW, echo 'foo' >> /proc/XXX is the same with echo 'foo' > /proc/XXX. I think it is reasonable for bitmap /proc files to have echo 'foo' >> /proc/XXX behaves like non-proc files, that is appending numbers into that file, like what Changli mentioned. Any objections? Thanks.