From: Nitin Gupta <ngupta@vflare.org>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: Greg KH <greg@kroah.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>, Cyp <cyp561@gmail.com>,
Minchan Kim <minchan.kim@gmail.com>,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/3] Add flag to identify block swap devices
Date: Fri, 07 May 2010 13:46:43 +0530 [thread overview]
Message-ID: <4BE3CC6B.2080008@vflare.org> (raw)
In-Reply-To: <y2m1b68c6791005070103q8cabf3afx22af4a28c6ecf747@mail.gmail.com>
On 05/07/2010 01:33 PM, jassi brar wrote:
> On Fri, May 7, 2010 at 4:25 PM, Nitin Gupta <ngupta@vflare.org> wrote:
>> Added SWP_BLKDEV flag to distinguish block and regular file backed
>> swap devices. We could also check if a swap is entire block device,
>> rather than a file, by:
>> S_ISBLK(swap_info_struct->swap_file->f_mapping->host->i_mode)
>> but, I think, simply checking this flag is more convenient.
> This might make it convenient for now but is likely to increase complexity and
> redundancy. Why not define a macro/inline to figure that out?
>
Accessing such long pointer chain is maybe not good thing to do for
every swap_entry_free() call? Simple checking a flag is perhaps slightly
faster? I also can't see how this flag can later increase complexity
compared to creating new macro for this check.
Thanks,
Nitin
next prev parent reply other threads:[~2010-05-07 8:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 7:25 [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2) Nitin Gupta
2010-05-07 7:25 ` [PATCH 1/3] Add flag to identify block swap devices Nitin Gupta
2010-05-07 8:03 ` jassi brar
2010-05-07 8:16 ` Nitin Gupta [this message]
2010-05-07 8:56 ` jassi brar
2010-05-07 9:24 ` Pekka Enberg
2010-05-07 9:32 ` Nigel Cunningham
2010-05-07 7:25 ` [PATCH 2/3] Add swap slot free callback to block_device_operations Nitin Gupta
2010-05-07 9:22 ` Nigel Cunningham
2010-05-07 9:48 ` Nitin Gupta
2010-05-07 10:40 ` Nigel Cunningham
2010-05-07 7:25 ` [PATCH 3/3] ramzswap: Handler for swap slot free callback Nitin Gupta
2010-05-07 7:44 ` [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2) Pekka Enberg
2010-05-07 14:51 ` Linus Torvalds
2010-05-07 19:55 ` Andrew Morton
2010-05-08 4:05 ` Nitin Gupta
2010-05-08 6:29 ` Pekka Enberg
2010-05-08 6:54 ` Nitin Gupta
2010-05-08 7:05 ` Pekka Enberg
2010-05-08 6:57 ` Nitin Gupta
2010-05-08 7:26 ` Pekka Enberg
2010-05-08 7:32 ` Nitin Gupta
-- strict thread matches above, loose matches on Subject: below --
2010-05-17 5:32 [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2 resend) Nitin Gupta
2010-05-17 5:32 ` [PATCH 1/3] Add flag to identify block swap devices Nitin Gupta
2010-05-17 11:50 ` Minchan Kim
2010-05-17 19:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE3CC6B.2080008@vflare.org \
--to=ngupta@vflare.org \
--cc=cyp561@gmail.com \
--cc=greg@kroah.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan.kim@gmail.com \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox