From: Nigel Cunningham <nigel@tuxonice.net>
To: Linus WALLEIJ <linus.walleij@stericsson.com>
Cc: Steven Liu <lingjiujianke@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Check kmalloc return value before use the buffer
Date: Sat, 08 May 2010 11:27:09 +1000 [thread overview]
Message-ID: <4BE4BDED.5050406@tuxonice.net> (raw)
In-Reply-To: <CEE6BB42CAD6E947908279175AF8470A025A68D366@EXDCVYMBSTM006.EQ1STM.local>
Hi again.
On 08/05/10 04:57, Linus WALLEIJ wrote:
> [Steven]
>
>> the code in arch/arm/mach-u300/dummyspichip.c is
>>
>> bigtxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>> if (bigtxbuf_virtual == NULL) {
>> status = -ENOMEM;
>> goto out;
>> }
>> bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
>>
>>
>> if kmalloc memory space for bigrxbuf_virtual is NULL, when it have
>> kmalloc DMA_TEST_SIZE memory space for bigtxbuf_virtual,so ,if kmalloc
>> memory for bigtxbuf_virtual success and kmalloc memory for
>> bigrxbuf_virtual faild,i think we must kfree bigtxbuf_virtual memory
>
> Ha, I also misread tx for rx, sorry.
I've just looked again, and the original version did have rx in the
test. We weren't seeing things :)
> Acked-by: Linus Walleij<linus.walleij@stericsson.com>
Acked-by: Nigel Cunningham <nigel@tuxonice.net>
Regards,
Nigel
next prev parent reply other threads:[~2010-05-08 1:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 2:41 [PATCH] Check kmalloc return value before use the buffer Steven Liu
2010-05-07 6:52 ` Linus WALLEIJ
2010-05-07 7:16 ` Steven Liu
2010-05-07 7:17 ` Steven Liu
2010-05-07 9:37 ` Nigel Cunningham
2010-05-07 9:37 ` Nigel Cunningham
2010-05-07 9:47 ` Steven Liu
2010-05-07 9:51 ` Nigel Cunningham
2010-05-07 18:57 ` Linus WALLEIJ
2010-05-08 1:27 ` Nigel Cunningham [this message]
2010-05-08 8:56 ` Steven Liu
2010-05-07 9:50 ` Steven Liu
2010-05-07 9:52 ` Nigel Cunningham
2010-05-07 9:55 ` Steven Liu
2010-05-10 21:49 ` Andy Isaacson
2010-05-10 22:08 ` Nigel Cunningham
-- strict thread matches above, loose matches on Subject: below --
2010-05-07 9:05 Steven Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE4BDED.5050406@tuxonice.net \
--to=nigel@tuxonice.net \
--cc=lingjiujianke@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox