* Keep index within boundaries in kvmppc_44x_emul_tlbwe()
@ 2010-05-09 15:26 Roel Kluin
2010-05-09 19:06 ` Alexander Graf
2010-05-10 22:58 ` Hollis Blanchard
0 siblings, 2 replies; 5+ messages in thread
From: Roel Kluin @ 2010-05-09 15:26 UTC (permalink / raw)
To: Alexander Graf, kvm-ppc, Andrew Morton, LKML
An index of KVM44x_GUEST_TLB_SIZE is already one too large.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
arch/powerpc/kvm/44x_tlb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kvm/44x_tlb.c b/arch/powerpc/kvm/44x_tlb.c
index 2570fcc..8123125 100644
--- a/arch/powerpc/kvm/44x_tlb.c
+++ b/arch/powerpc/kvm/44x_tlb.c
@@ -440,7 +440,7 @@ int kvmppc_44x_emul_tlbwe(struct kvm_vcpu *vcpu, u8 ra, u8 rs, u8 ws)
unsigned int gtlb_index;
gtlb_index = kvmppc_get_gpr(vcpu, ra);
- if (gtlb_index > KVM44x_GUEST_TLB_SIZE) {
+ if (gtlb_index >= KVM44x_GUEST_TLB_SIZE) {
printk("%s: index %d\n", __func__, gtlb_index);
kvmppc_dump_vcpu(vcpu);
return EMULATE_FAIL;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: Keep index within boundaries in kvmppc_44x_emul_tlbwe()
2010-05-09 15:26 Keep index within boundaries in kvmppc_44x_emul_tlbwe() Roel Kluin
@ 2010-05-09 19:06 ` Alexander Graf
2010-05-10 22:58 ` Hollis Blanchard
1 sibling, 0 replies; 5+ messages in thread
From: Alexander Graf @ 2010-05-09 19:06 UTC (permalink / raw)
To: Roel Kluin; +Cc: kvm-ppc, Andrew Morton, LKML, kvm@vger.kernel.org, hollis
Roel Kluin wrote:
> An index of KVM44x_GUEST_TLB_SIZE is already one too large.
>
Thanks for this one Roel. Please try to keep kvm@vger CC'ed on KVM
patches, as all KVM patches go through kvm.git.
Hollis, I'd like to see an Ack from you on this patch. It looks
reasonable to me, but I'd still feel better if there was some word from
you on it.
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Keep index within boundaries in kvmppc_44x_emul_tlbwe()
2010-05-09 15:26 Keep index within boundaries in kvmppc_44x_emul_tlbwe() Roel Kluin
2010-05-09 19:06 ` Alexander Graf
@ 2010-05-10 22:58 ` Hollis Blanchard
2010-05-10 23:10 ` Alexander Graf
1 sibling, 1 reply; 5+ messages in thread
From: Hollis Blanchard @ 2010-05-10 22:58 UTC (permalink / raw)
To: Roel Kluin; +Cc: Alexander Graf, kvm-ppc, Andrew Morton, LKML, kvm-devel
On Sun, May 9, 2010 at 8:26 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> An index of KVM44x_GUEST_TLB_SIZE is already one too large.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Hollis Blanchard <hollis@penguinppc.org>
Thanks Roel.
-Hollis
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Keep index within boundaries in kvmppc_44x_emul_tlbwe()
2010-05-10 22:58 ` Hollis Blanchard
@ 2010-05-10 23:10 ` Alexander Graf
2010-05-12 20:23 ` Marcelo Tosatti
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Graf @ 2010-05-10 23:10 UTC (permalink / raw)
To: Hollis Blanchard; +Cc: Roel Kluin, kvm-ppc, Andrew Morton, LKML, kvm-devel
On 11.05.2010, at 00:58, Hollis Blanchard wrote:
> On Sun, May 9, 2010 at 8:26 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
>> An index of KVM44x_GUEST_TLB_SIZE is already one too large.
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>
> Acked-by: Hollis Blanchard <hollis@penguinppc.org>
Acked-by: Alexander Graf <agraf@suse.de>
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Keep index within boundaries in kvmppc_44x_emul_tlbwe()
2010-05-10 23:10 ` Alexander Graf
@ 2010-05-12 20:23 ` Marcelo Tosatti
0 siblings, 0 replies; 5+ messages in thread
From: Marcelo Tosatti @ 2010-05-12 20:23 UTC (permalink / raw)
To: Alexander Graf
Cc: Hollis Blanchard, Roel Kluin, kvm-ppc, Andrew Morton, LKML,
kvm-devel
On Tue, May 11, 2010 at 01:10:49AM +0200, Alexander Graf wrote:
>
> On 11.05.2010, at 00:58, Hollis Blanchard wrote:
>
> > On Sun, May 9, 2010 at 8:26 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> >> An index of KVM44x_GUEST_TLB_SIZE is already one too large.
> >>
> >> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> >
> > Acked-by: Hollis Blanchard <hollis@penguinppc.org>
>
> Acked-by: Alexander Graf <agraf@suse.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-12 20:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-09 15:26 Keep index within boundaries in kvmppc_44x_emul_tlbwe() Roel Kluin
2010-05-09 19:06 ` Alexander Graf
2010-05-10 22:58 ` Hollis Blanchard
2010-05-10 23:10 ` Alexander Graf
2010-05-12 20:23 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).