From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zamsden@redhat.com
Subject: Re: [PATCH v3 0/8] pvclock fixes - v3
Date: Tue, 11 May 2010 11:35:22 +0300 [thread overview]
Message-ID: <4BE916CA.6030501@redhat.com> (raw)
In-Reply-To: <1273094839-18655-1-git-send-email-glommer@redhat.com>
On 05/06/2010 12:27 AM, Glauber Costa wrote:
> Hello,
>
> Avi, this version fixes the issues you raised in the last
> review. Hopte it is better now.
>
>
Sorry about the late review. Looks reasonable, apart from a couple of
minor points.
> A cpuid.txt wil follow as soon as we're set on everything, so
> I am not including it yet.
>
Pity, for a reviewer it is a lot easier to review a spec, then the
code's conformity to the spec, instead of having to reverse engineer the
intent from the code. Please include it next time.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-05-11 8:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 21:27 [PATCH v3 0/8] pvclock fixes - v3 Glauber Costa
2010-05-05 21:27 ` [PATCH v3 1/8] Enable pvclock flags in vcpu_time_info structure Glauber Costa
2010-05-05 21:27 ` [PATCH v3 2/8] Add a global synchronization point for pvclock Glauber Costa
2010-05-05 21:27 ` [PATCH v3 3/8] change msr numbers for kvmclock Glauber Costa
2010-05-05 21:27 ` [PATCH v3 4/8] add new KVMCLOCK cpuid feature Glauber Costa
2010-05-05 21:27 ` [PATCH v3 5/8] export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID Glauber Costa
2010-05-05 21:27 ` [PATCH v3 6/8] Try using new kvm clock msrs Glauber Costa
2010-05-05 21:27 ` [PATCH v3 7/8] don't compute pvclock adjustments if we trust the tsc Glauber Costa
2010-05-05 21:27 ` [PATCH v3 8/8] Tell the guest we'll warn it about tsc stability Glauber Costa
2010-05-11 8:29 ` [PATCH v3 5/8] export paravirtual cpuid flags in KVM_GET_SUPPORTED_CPUID Avi Kivity
2010-05-11 8:35 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE916CA.6030501@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox