From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Albert Herranz <albert_herranz@yahoo.es>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
fujita.tomonori@lab.ntt.co.jp, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, chrisw@sous-sol.org,
Ian.Campbell@eu.citrix.com, dwmw2@infradead.org
Subject: Re: [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file.
Date: Tue, 11 May 2010 11:36:42 -0700 [thread overview]
Message-ID: <4BE9A3BA.5090908@goop.org> (raw)
In-Reply-To: <4BE9A1C0.3090505@yahoo.es>
On 05/11/2010 11:28 AM, Albert Herranz wrote:
> Konrad Rzeszutek Wilk wrote:
>
>> +extern void *swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys,
>> + u64 tbl_dma_addr, size_t size,
>> + enum dma_data_direction dir);
>> +
>>
> The phys and tbl_dma_addr arguments in the function prototype are swapped compared to the function definition in patch 1/6.
>
Good catch. I can see someone beating their head bloody over that...
J
next prev parent reply other threads:[~2010-05-11 18:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 15:39 [PATCH] swiotlb v0.8: seperation of physical/virtual address translation Konrad Rzeszutek Wilk
2010-05-11 15:39 ` [PATCH 1/6] swiotlb: add swiotlb_tbl_map_single library function Konrad Rzeszutek Wilk
2010-05-11 15:39 ` [PATCH 2/6] swiotlb: add the swiotlb initialization function with iotlb memory Konrad Rzeszutek Wilk
2010-05-11 15:39 ` [PATCH 3/6] swiotlb: Make internal bookkeeping functions have 'swiotlb_tbl' prefix Konrad Rzeszutek Wilk
2010-05-11 15:39 ` [PATCH 4/6] swiotlb: search and replace "int dir" with "enum dma_data_direction dir" Konrad Rzeszutek Wilk
2010-05-11 15:39 ` [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file Konrad Rzeszutek Wilk
2010-05-11 15:39 ` [PATCH 6/6] swiotlb: EXPORT_SYMBOL_GPL functions + variables that are defined " Konrad Rzeszutek Wilk
2010-05-11 18:28 ` [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible " Albert Herranz
2010-05-11 18:36 ` Jeremy Fitzhardinge [this message]
2010-05-11 18:46 ` Konrad Rzeszutek Wilk
2010-05-11 19:01 ` Albert Herranz
2010-05-11 19:39 ` Konrad Rzeszutek Wilk
2010-05-13 5:04 ` Albert Herranz
2010-05-18 3:28 ` FUJITA Tomonori
2010-05-18 16:52 ` Albert Herranz
2010-05-19 3:34 ` FUJITA Tomonori
2010-05-19 5:22 ` Albert Herranz
2010-05-19 7:10 ` Russell King - ARM Linux
2010-05-19 11:54 ` FUJITA Tomonori
2010-05-17 9:48 ` [PATCH] swiotlb v0.8: seperation of physical/virtual address translation FUJITA Tomonori
2010-05-26 15:42 ` Konrad Rzeszutek Wilk
2010-05-28 16:23 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2010-04-07 20:29 [PATCH] swiotlb 0.7: separation of physical and virtual " Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 1/6] swiotlb: Make internal bookkeeping functions have 'swiotlb_tbl' prefix Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 2/6] swiotlb: swiotlb_tbl_map_single: abstract out swiotlb_virt_to_bus calls out Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 3/6] swiotlb: Make exportable bookkeeping functions and variables have same prefix Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 4/6] swiotlb: search and replace "int dir" with "enum dma_data_direction dir" Konrad Rzeszutek Wilk
2010-04-07 20:29 ` [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file Konrad Rzeszutek Wilk
2010-05-09 13:41 ` FUJITA Tomonori
2010-05-10 19:35 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE9A3BA.5090908@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=albert_herranz@yahoo.es \
--cc=chrisw@sous-sol.org \
--cc=dwmw2@infradead.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).