linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
	systemtap <systemtap@sources.redhat.com>,
	DLE <dle-develop@lists.sourceforge.net>,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Jim Keniston <jkenisto@us.ibm.com>,
	Jason Baron <jbaron@redhat.com>
Subject: Re: [PATCH -tip 1/5] [CLEANUP] kprobes: Remove redundant	text_mutex lock in optimize
Date: Tue, 11 May 2010 16:06:53 -0400	[thread overview]
Message-ID: <4BE9B8DD.9080004@redhat.com> (raw)
In-Reply-To: <20100511123550.GB25418@Krystal>

Hi Mathieu,

Mathieu Desnoyers wrote:
> * Masami Hiramatsu (mhiramat@redhat.com) wrote:
>> Remove text_mutex locking in optimize_all_kprobes, because
>> that function doesn't modify text but just order optimization
>> to worker.
> 
> Hi Masami,
> 
> A few comments:
> 
> 1) optimize_all_kprobes/unoptimize_all_kprobes should have comments saying that
> they are always called with kprobe_mutex held.
> 
> 2) The sentence above in the changelog could be changed into:
> 
>  ..."because this function doesn't modify text. It simply queues optimizations
> for the kprobe_optimizer worker thread."
> 
> 3)
> 
> static DEFINE_MUTEX(kprobe_mutex);      /* Protects kprobe_table */
> 
> .. should also state that it protects optimizing_list.
> 

Thanks! all comments are good to me!

Thank you again,




-- 
Masami Hiramatsu
e-mail: mhiramat@redhat.com


  reply	other threads:[~2010-05-11 20:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10 17:53 [PATCH -tip 0/5] kprobes: batch (un)optimization support Masami Hiramatsu
2010-05-10 17:53 ` [PATCH -tip 1/5] [CLEANUP] kprobes: Remove redundant text_mutex lock in optimize Masami Hiramatsu
2010-05-11 12:35   ` Mathieu Desnoyers
2010-05-11 20:06     ` Masami Hiramatsu [this message]
2010-05-10 17:53 ` [PATCH -tip 2/5] kprobes: Limit maximum number of optimization at once Masami Hiramatsu
2010-05-10 17:53 ` [PATCH -tip 3/5] x86: Introduce text_poke_smp_batch() for batch-code modifying Masami Hiramatsu
2010-05-10 17:53 ` [PATCH -tip 4/5] kprobes/x86: Use text_poke_smp_batch Masami Hiramatsu
2010-05-11 14:40   ` Mathieu Desnoyers
2010-05-12  0:41     ` Masami Hiramatsu
2010-05-12 15:27       ` Mathieu Desnoyers
2010-05-12 17:43         ` Masami Hiramatsu
2010-05-12 17:48           ` Mathieu Desnoyers
2010-05-12 19:11             ` Masami Hiramatsu
2010-05-13 19:07         ` Masami Hiramatsu
2010-05-13 21:20           ` Mathieu Desnoyers
2010-05-10 17:53 ` [PATCH -tip 5/5] kprobes: Support delayed unoptimization Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE9B8DD.9080004@redhat.com \
    --to=mhiramat@redhat.com \
    --cc=ananth@in.ibm.com \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=jbaron@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).