From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753804Ab0ELVCR (ORCPT ); Wed, 12 May 2010 17:02:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35458 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627Ab0ELVCP (ORCPT ); Wed, 12 May 2010 17:02:15 -0400 Message-ID: <4BEB1732.1010503@redhat.com> Date: Wed, 12 May 2010 17:01:38 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: Mel Gorman CC: Andrew Morton , Andrea Arcangeli , Minchan Kim , Linux-MM , KAMEZAWA Hiroyuki , LKML , Linus Torvalds Subject: Re: [PATCH 3/5] track the root (oldest) anon_vma References: <20100512133815.0d048a86@annuminas.surriel.com> <20100512133958.3aff0515@annuminas.surriel.com> <20100512205941.GO24989@csn.ul.ie> In-Reply-To: <20100512205941.GO24989@csn.ul.ie> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2010 04:59 PM, Mel Gorman wrote: > On Wed, May 12, 2010 at 01:39:58PM -0400, Rik van Riel wrote: >> Subject: track the root (oldest) anon_vma >> >> Track the root (oldest) anon_vma in each anon_vma tree. Because we only >> take the lock on the root anon_vma, we cannot use the lock on higher-up >> anon_vmas to lock anything. This makes it impossible to do an indirect >> lookup of the root anon_vma, since the data structures could go away from >> under us. >> >> However, a direct pointer is safe because the root anon_vma is always the >> last one that gets freed on munmap or exit, by virtue of the same_vma list >> order and unlink_anon_vmas walking the list forward. >> > > Shouldn't this be "usually the last one that gets freed" because of the > ref-counting by KSM aspect? Minor nit anyway. It needs to be the last one that gets freed. Patch 5/5 makes sure that it is when KSM refcounting is involved. >> Signed-off-by: Rik van Riel > > Otherwise > > Acked-by: Mel Gorman Thank you for reviewing these patches. -- All rights reversed