* Re: mmotm 2010-05-11-18-20 uploaded (aio build)
2010-05-12 1:21 mmotm 2010-05-11-18-20 uploaded akpm
@ 2010-05-12 16:50 ` Randy Dunlap
2010-05-12 17:07 ` Jeff Moyer
2010-05-12 19:52 ` mmotm 2010-05-11 - dies in pm_qos_update_request() Valdis.Kletnieks
` (3 subsequent siblings)
4 siblings, 1 reply; 24+ messages in thread
From: Randy Dunlap @ 2010-05-12 16:50 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Jeff Moyer
On Tue, 11 May 2010 18:21:22 -0700 akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://zen-kernel.org/kernel/mmotm.git
aio-fix-the-compat-vectored-operations.patch:
(1) when CONFIG_AIO is not enabled, there are hundreds of this warning:
include/linux/aio.h:226: warning: no return statement in function returning non-void
(2) when CONFIG_AIO=y, CONFIG_IA32_EMULATION=n, CONFIG_COMPAT=n:
fs/aio.c:1393: error: implicit declaration of function 'compat_rw_copy_check_uvector'
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: mmotm 2010-05-11-18-20 uploaded (aio build)
2010-05-12 16:50 ` mmotm 2010-05-11-18-20 uploaded (aio build) Randy Dunlap
@ 2010-05-12 17:07 ` Jeff Moyer
2010-05-12 17:09 ` Randy Dunlap
2010-05-12 19:42 ` mmotm 2010-05-11-18-20 uploaded (aio build; add numa) Randy Dunlap
0 siblings, 2 replies; 24+ messages in thread
From: Jeff Moyer @ 2010-05-12 17:07 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, akpm
Randy Dunlap <randy.dunlap@oracle.com> writes:
> On Tue, 11 May 2010 18:21:22 -0700 akpm@linux-foundation.org wrote:
>
>> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>>
>> http://userweb.kernel.org/~akpm/mmotm/
>>
>> and will soon be available at
>>
>> git://zen-kernel.org/kernel/mmotm.git
>
>
> aio-fix-the-compat-vectored-operations.patch:
>
> (1) when CONFIG_AIO is not enabled, there are hundreds of this warning:
>
> include/linux/aio.h:226: warning: no return statement in function returning non-void
>
>
> (2) when CONFIG_AIO=y, CONFIG_IA32_EMULATION=n, CONFIG_COMPAT=n:
>
> fs/aio.c:1393: error: implicit declaration of function 'compat_rw_copy_check_uvector'
Sorry about that. I'll fix it up, but probably can't get to it until
Monday. Hopefully that's an ok timeframe.
Cheers,
Jeff
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded (aio build)
2010-05-12 17:07 ` Jeff Moyer
@ 2010-05-12 17:09 ` Randy Dunlap
2010-05-12 19:42 ` mmotm 2010-05-11-18-20 uploaded (aio build; add numa) Randy Dunlap
1 sibling, 0 replies; 24+ messages in thread
From: Randy Dunlap @ 2010-05-12 17:09 UTC (permalink / raw)
To: Jeff Moyer; +Cc: linux-kernel, akpm
On 05/12/10 10:07, Jeff Moyer wrote:
> Randy Dunlap <randy.dunlap@oracle.com> writes:
>
>> On Tue, 11 May 2010 18:21:22 -0700 akpm@linux-foundation.org wrote:
>>
>>> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/
>>>
>>> and will soon be available at
>>>
>>> git://zen-kernel.org/kernel/mmotm.git
>>
>>
>> aio-fix-the-compat-vectored-operations.patch:
>>
>> (1) when CONFIG_AIO is not enabled, there are hundreds of this warning:
>>
>> include/linux/aio.h:226: warning: no return statement in function returning non-void
>>
>>
>> (2) when CONFIG_AIO=y, CONFIG_IA32_EMULATION=n, CONFIG_COMPAT=n:
>>
>> fs/aio.c:1393: error: implicit declaration of function 'compat_rw_copy_check_uvector'
>
> Sorry about that. I'll fix it up, but probably can't get to it until
> Monday. Hopefully that's an ok timeframe.
Sure, not a problem IMO.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded (aio build; add numa)
2010-05-12 17:07 ` Jeff Moyer
2010-05-12 17:09 ` Randy Dunlap
@ 2010-05-12 19:42 ` Randy Dunlap
1 sibling, 0 replies; 24+ messages in thread
From: Randy Dunlap @ 2010-05-12 19:42 UTC (permalink / raw)
To: Jeff Moyer, Jack Steiner; +Cc: linux-kernel, akpm
On Wed, 12 May 2010 13:07:58 -0400 Jeff Moyer wrote:
> Randy Dunlap <randy.dunlap@oracle.com> writes:
>
> > On Tue, 11 May 2010 18:21:22 -0700 akpm@linux-foundation.org wrote:
> >
> >> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> >>
> >> http://userweb.kernel.org/~akpm/mmotm/
> >>
> >> and will soon be available at
> >>
> >> git://zen-kernel.org/kernel/mmotm.git
> >
> >
> > aio-fix-the-compat-vectored-operations.patch:
> >
> > (1) when CONFIG_AIO is not enabled, there are hundreds of this warning:
> >
> > include/linux/aio.h:226: warning: no return statement in function returning non-void
> >
> >
> > (2) when CONFIG_AIO=y, CONFIG_IA32_EMULATION=n, CONFIG_COMPAT=n:
> >
> > fs/aio.c:1393: error: implicit declaration of function 'compat_rw_copy_check_uvector'
>
> Sorry about that. I'll fix it up, but probably can't get to it until
> Monday. Hopefully that's an ok timeframe.
Andrew's patch works_for_me. (Ack)
During the build, I got another (unrelated) build error:
kernel/built-in.o: In function `copy_process':
fork.c:(.text+0x162b6): undefined reference to `__node_random'
fork.c:(.text+0x162cd): undefined reference to `__node_random'
kernel/fork.c needs to #include <linux/nodemask.h>
[builds...]
But that is not enough. The config file has CONFIG_CPUSETS=y
and CONFIG_NUMA=n, so __node_random() is not being built at all.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 24+ messages in thread
* mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-12 1:21 mmotm 2010-05-11-18-20 uploaded akpm
2010-05-12 16:50 ` mmotm 2010-05-11-18-20 uploaded (aio build) Randy Dunlap
@ 2010-05-12 19:52 ` Valdis.Kletnieks
2010-05-12 21:07 ` Rafael J. Wysocki
2010-05-12 20:39 ` [PATCH -mmotm] misc: fix ad525X_dpot build Randy Dunlap
` (2 subsequent siblings)
4 siblings, 1 reply; 24+ messages in thread
From: Valdis.Kletnieks @ 2010-05-12 19:52 UTC (permalink / raw)
To: Andrew Morton, Rafael J. Wysocki, David S. Miller
Cc: linux-kernel, e1000-devel, netdev
[-- Attachment #1: Type: text/plain, Size: 4678 bytes --]
On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
Dell Latitude E6500, x86_64 kernel.
Died a horrid death at boot in the e1000e driver. Seems to be
something in linux-next.patch. Didn't get a netconsole trace for obvious
reasons...
Copied-by-hand traceback:
pm_qos_update_request()+0x22
e1000_configure+0x478
e1000_open_device+0xee
? _raw_notifier_call_chain+0xf
__dev_open+0xec
dev_open+0x1b
netpoll_setup+0x28b
init_netconsole+0xbc
I suspect this commit:
commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date: Sun Mar 14 14:35:17 2010 +0000
e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
Use the PCI runtime power management framework to add basic PCI
runtime PM support to the e1000e driver. Namely, make the driver
suspend the device when the link is off and set it up for generating
a wakeup event after the link has been detected again. [This
feature is disabled until the user space enables it with the help of
the /sys/devices/.../power/contol device attribute.]
Not sure how to reconcile "this feature is disabled until" with my
traceback, since userspace hasn't even started when init_netconsole is
happening.
/*
* Enable early receives on supported devices, only takes effect when
* packet size is equal or larger than the specified value (in 8 byte
* units), e.g. using jumbo frames when setting to E1000_ERT_2048
*/
if (adapter->flags & FLAG_HAS_ERT) {
How the heck did FLAG_HAS_ERT get set, we can't call pm_qos_update_request()
otherwise?
Aha. Over in ich8lan.c, we have:
struct e1000_info e1000_ich9_info = {
.mac = e1000_ich9lan,
.flags = FLAG_HAS_JUMBO_FRAMES
| FLAG_IS_ICH
| FLAG_HAS_WOL
| FLAG_RX_CSUM_ENABLED
| FLAG_HAS_CTRLEXT_ON_LOAD
| FLAG_HAS_AMT
| FLAG_HAS_ERT
| FLAG_HAS_FLASH
| FLAG_APME_IN_WUC,
And lspci says:
00:00.0 Host bridge: Intel Corporation Mobile 4 Series Chipset Memory Controller Hub (rev 07)
00:01.0 PCI bridge: Intel Corporation Mobile 4 Series Chipset PCI Express Graphics Port (rev 07)
00:19.0 Ethernet controller: Intel Corporation 82567LM Gigabit Network Connection (rev 03)
00:1a.0 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #4 (rev 03)
00:1a.1 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #5 (rev 03)
00:1a.2 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #6 (rev 03)
00:1a.7 USB Controller: Intel Corporation 82801I (ICH9 Family) USB2 EHCI Controller #2 (rev 03)
00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)
00:1c.0 PCI bridge: Intel Corporation 82801I (ICH9 Family) PCI Express Port 1 (rev 03)
00:1c.1 PCI bridge: Intel Corporation 82801I (ICH9 Family) PCI Express Port 2 (rev 03)
00:1c.2 PCI bridge: Intel Corporation 82801I (ICH9 Family) PCI Express Port 3 (rev 03)
00:1c.3 PCI bridge: Intel Corporation 82801I (ICH9 Family) PCI Express Port 4 (rev 03)
00:1d.0 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #1 (rev 03)
00:1d.1 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #2 (rev 03)
00:1d.2 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI Controller #3 (rev 03)
00:1d.7 USB Controller: Intel Corporation 82801I (ICH9 Family) USB2 EHCI Controller #1 (rev 03)
00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev 93)
00:1f.0 ISA bridge: Intel Corporation ICH9M-E LPC Interface Controller (rev 03)
00:1f.2 RAID bus controller: Intel Corporation Mobile 82801 SATA RAID Controller (rev 03)
00:1f.3 SMBus: Intel Corporation 82801I (ICH9 Family) SMBus Controller (rev 03)
01:00.0 VGA compatible controller: nVidia Corporation G98M [Quadro NVS 160M] (rev a1)
03:01.0 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev ba)
03:01.1 FireWire (IEEE 1394): Ricoh Co Ltd R5C832 IEEE 1394 Controller (rev 04)
03:01.2 SD Host controller: Ricoh Co Ltd R5C822 SD/SDIO/MMC/MS/MSPro Host Adapter (rev 21)
0c:00.0 Network controller: Intel Corporation Wireless WiFi Link 5100
I see a lot of ICH9 listed there, guess a Mobile 4 is ICH9-ish enough...
Unfortunately, that's the limit of my ability to chase this down.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-12 19:52 ` mmotm 2010-05-11 - dies in pm_qos_update_request() Valdis.Kletnieks
@ 2010-05-12 21:07 ` Rafael J. Wysocki
2010-05-12 22:12 ` Valdis.Kletnieks
2010-05-13 14:34 ` Valdis.Kletnieks
0 siblings, 2 replies; 24+ messages in thread
From: Rafael J. Wysocki @ 2010-05-12 21:07 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: Andrew Morton, David S. Miller, linux-kernel, e1000-devel, netdev
On Wednesday 12 May 2010, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Dell Latitude E6500, x86_64 kernel.
>
> Died a horrid death at boot in the e1000e driver. Seems to be
> something in linux-next.patch. Didn't get a netconsole trace for obvious
> reasons...
>
> Copied-by-hand traceback:
> pm_qos_update_request()+0x22
> e1000_configure+0x478
> e1000_open_device+0xee
> ? _raw_notifier_call_chain+0xf
> __dev_open+0xec
> dev_open+0x1b
> netpoll_setup+0x28b
> init_netconsole+0xbc
>
> I suspect this commit:
>
> commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> Author: Rafael J. Wysocki <rjw@sisk.pl>
> Date: Sun Mar 14 14:35:17 2010 +0000
>
> e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
No, I don't think so. I'm running -rc6 with this patch applied on a box with
e1000e and it works just fine.
Please try to revert this one instead:
http://git.kernel.org/?p=linux/kernel/git/rafael/suspend-2.6.git;a=patch;h=ed77134bfccf5e75b6cbadab268e559dbe6a4ebb
Rafael
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-12 21:07 ` Rafael J. Wysocki
@ 2010-05-12 22:12 ` Valdis.Kletnieks
2010-05-12 22:33 ` Rafael J. Wysocki
2010-05-13 14:34 ` Valdis.Kletnieks
1 sibling, 1 reply; 24+ messages in thread
From: Valdis.Kletnieks @ 2010-05-12 22:12 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Andrew Morton, David S. Miller, linux-kernel, e1000-devel, netdev
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
On Wed, 12 May 2010 23:07:20 +0200, "Rafael J. Wysocki" said:
> > I suspect this commit:
> >
> > commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> > Author: Rafael J. Wysocki <rjw@sisk.pl>
> > Date: Sun Mar 14 14:35:17 2010 +0000
> >
> > e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
>
> No, I don't think so. I'm running -rc6 with this patch applied on a box with
> e1000e and it works just fine.
>
> Please try to revert this one instead:
>
> http://git.kernel.org/?p=linux/kernel/git/rafael/suspend-2.6.git;a=patch;h=ed77134bfccf5e75b6cbadab268e559dbe6a4ebb
Isn't a clean revert - build dies with:
CC net/mac80211/scan.o
net/mac80211/scan.c: In function 'ieee80211_scan_state_decision':
net/mac80211/scan.c:510: error: implicit declaration of function 'pm_qos_request'
make[1]: *** [net/mac80211/scan.o] Error 1
make: *** [net/mac80211/scan.o] Error 2
Will investigate more later, find what other commit needs reverting.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-12 22:12 ` Valdis.Kletnieks
@ 2010-05-12 22:33 ` Rafael J. Wysocki
0 siblings, 0 replies; 24+ messages in thread
From: Rafael J. Wysocki @ 2010-05-12 22:33 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: Andrew Morton, David S. Miller, linux-kernel, e1000-devel, netdev
On Thursday 13 May 2010, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 12 May 2010 23:07:20 +0200, "Rafael J. Wysocki" said:
>
> > > I suspect this commit:
> > >
> > > commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> > > Author: Rafael J. Wysocki <rjw@sisk.pl>
> > > Date: Sun Mar 14 14:35:17 2010 +0000
> > >
> > > e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
> >
> > No, I don't think so. I'm running -rc6 with this patch applied on a box with
> > e1000e and it works just fine.
> >
> > Please try to revert this one instead:
> >
> > http://git.kernel.org/?p=linux/kernel/git/rafael/suspend-2.6.git;a=patch;h=ed77134bfccf5e75b6cbadab268e559dbe6a4ebb
>
> Isn't a clean revert - build dies with:
>
> CC net/mac80211/scan.o
> net/mac80211/scan.c: In function 'ieee80211_scan_state_decision':
> net/mac80211/scan.c:510: error: implicit declaration of function 'pm_qos_request'
> make[1]: *** [net/mac80211/scan.o] Error 1
> make: *** [net/mac80211/scan.o] Error 2
>
> Will investigate more later, find what other commit needs reverting.
Simply rename pm_qos_request() to pm_qos_requirement() in
ieee80211_scan_state_decision() and it should build.
Rafael
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-12 21:07 ` Rafael J. Wysocki
2010-05-12 22:12 ` Valdis.Kletnieks
@ 2010-05-13 14:34 ` Valdis.Kletnieks
2010-05-13 22:24 ` Rafael J. Wysocki
2010-05-13 22:32 ` Rafael J. Wysocki
1 sibling, 2 replies; 24+ messages in thread
From: Valdis.Kletnieks @ 2010-05-13 14:34 UTC (permalink / raw)
To: Rafael J. Wysocki, Mark Gross
Cc: Andrew Morton, David S. Miller, linux-kernel, e1000-devel, netdev
[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]
On Wed, 12 May 2010 23:07:20 +0200, "Rafael J. Wysocki" said:
> On Wednesday 12 May 2010, Valdis.Kletnieks@vt.edu wrote:
> > On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> > > The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> > >
> > > http://userweb.kernel.org/~akpm/mmotm/
> >
> > Dell Latitude E6500, x86_64 kernel.
> >
> > Died a horrid death at boot in the e1000e driver. Seems to be
> > something in linux-next.patch. Didn't get a netconsole trace for obvious
> > reasons...
> >
> > Copied-by-hand traceback:
> > pm_qos_update_request()+0x22
> > e1000_configure+0x478
> > e1000_open_device+0xee
> > ? _raw_notifier_call_chain+0xf
> > __dev_open+0xec
> > dev_open+0x1b
> > netpoll_setup+0x28b
> > init_netconsole+0xbc
> >
> > I suspect this commit:
> >
> > commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> > Author: Rafael J. Wysocki <rjw@sisk.pl>
> > Date: Sun Mar 14 14:35:17 2010 +0000
> >
> > e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
>
> No, I don't think so. I'm running -rc6 with this patch applied on a box with
> e1000e and it works just fine.
>
> Please try to revert this one instead:
>
> http://git.kernel.org/?p=linux/kernel/git/rafael/suspend-2.6.git;a=patch;h=ed77134bfccf5e75b6cbadab268e559dbe6a4ebb
Confirming - reverting that patch and doing the build fixup results in a
kernel that doesn't blow up in the e1000e driver...
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-13 14:34 ` Valdis.Kletnieks
@ 2010-05-13 22:24 ` Rafael J. Wysocki
2010-05-14 23:43 ` mark gross
2010-05-13 22:32 ` Rafael J. Wysocki
1 sibling, 1 reply; 24+ messages in thread
From: Rafael J. Wysocki @ 2010-05-13 22:24 UTC (permalink / raw)
To: Valdis.Kletnieks, Mark Gross
Cc: Andrew Morton, David S. Miller, linux-kernel, e1000-devel, netdev
On Thursday 13 May 2010, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 12 May 2010 23:07:20 +0200, "Rafael J. Wysocki" said:
> > On Wednesday 12 May 2010, Valdis.Kletnieks@vt.edu wrote:
> > > On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> > > > The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> > > >
> > > > http://userweb.kernel.org/~akpm/mmotm/
> > >
> > > Dell Latitude E6500, x86_64 kernel.
> > >
> > > Died a horrid death at boot in the e1000e driver. Seems to be
> > > something in linux-next.patch. Didn't get a netconsole trace for obvious
> > > reasons...
> > >
> > > Copied-by-hand traceback:
> > > pm_qos_update_request()+0x22
> > > e1000_configure+0x478
> > > e1000_open_device+0xee
> > > ? _raw_notifier_call_chain+0xf
> > > __dev_open+0xec
> > > dev_open+0x1b
> > > netpoll_setup+0x28b
> > > init_netconsole+0xbc
> > >
> > > I suspect this commit:
> > >
> > > commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> > > Author: Rafael J. Wysocki <rjw@sisk.pl>
> > > Date: Sun Mar 14 14:35:17 2010 +0000
> > >
> > > e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
> >
> > No, I don't think so. I'm running -rc6 with this patch applied on a box with
> > e1000e and it works just fine.
> >
> > Please try to revert this one instead:
> >
> > http://git.kernel.org/?p=linux/kernel/git/rafael/suspend-2.6.git;a=patch;h=ed77134bfccf5e75b6cbadab268e559dbe6a4ebb
>
> Confirming - reverting that patch and doing the build fixup results in a
> kernel that doesn't blow up in the e1000e driver...
Then I guess there's an initializations problem somewhere.
Mark, any chance to look into that any time soon? If we don't resolve this
before the merge window opens, I'm afraid I'll have to revert that commit
from my tree.
Rafael
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-13 22:24 ` Rafael J. Wysocki
@ 2010-05-14 23:43 ` mark gross
0 siblings, 0 replies; 24+ messages in thread
From: mark gross @ 2010-05-14 23:43 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Valdis.Kletnieks, Andrew Morton, David S. Miller, linux-kernel,
e1000-devel, netdev
On Fri, May 14, 2010 at 12:24:50AM +0200, Rafael J. Wysocki wrote:
> On Thursday 13 May 2010, Valdis.Kletnieks@vt.edu wrote:
> > On Wed, 12 May 2010 23:07:20 +0200, "Rafael J. Wysocki" said:
> > > On Wednesday 12 May 2010, Valdis.Kletnieks@vt.edu wrote:
> > > > On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> > > > > The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> > > > >
> > > > > http://userweb.kernel.org/~akpm/mmotm/
> > > >
> > > > Dell Latitude E6500, x86_64 kernel.
> > > >
> > > > Died a horrid death at boot in the e1000e driver. Seems to be
> > > > something in linux-next.patch. Didn't get a netconsole trace for obvious
> > > > reasons...
> > > >
> > > > Copied-by-hand traceback:
> > > > pm_qos_update_request()+0x22
> > > > e1000_configure+0x478
> > > > e1000_open_device+0xee
> > > > ? _raw_notifier_call_chain+0xf
> > > > __dev_open+0xec
> > > > dev_open+0x1b
> > > > netpoll_setup+0x28b
> > > > init_netconsole+0xbc
> > > >
> > > > I suspect this commit:
> > > >
> > > > commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> > > > Author: Rafael J. Wysocki <rjw@sisk.pl>
> > > > Date: Sun Mar 14 14:35:17 2010 +0000
> > > >
> > > > e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
> > >
> > > No, I don't think so. I'm running -rc6 with this patch applied on a box with
> > > e1000e and it works just fine.
> > >
> > > Please try to revert this one instead:
> > >
> > > http://git.kernel.org/?p=linux/kernel/git/rafael/suspend-2.6.git;a=patch;h=ed77134bfccf5e75b6cbadab268e559dbe6a4ebb
> >
> > Confirming - reverting that patch and doing the build fixup results in a
> > kernel that doesn't blow up in the e1000e driver...
>
> Then I guess there's an initializations problem somewhere.
>
> Mark, any chance to look into that any time soon? If we don't resolve this
> before the merge window opens, I'm afraid I'll have to revert that commit
> from my tree.
>
I'll look at it right away.
I think I have an e1000e in my home box.
--mgross
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11 - dies in pm_qos_update_request()
2010-05-13 14:34 ` Valdis.Kletnieks
2010-05-13 22:24 ` Rafael J. Wysocki
@ 2010-05-13 22:32 ` Rafael J. Wysocki
1 sibling, 0 replies; 24+ messages in thread
From: Rafael J. Wysocki @ 2010-05-13 22:32 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: Mark Gross, Andrew Morton, David S. Miller, linux-kernel,
e1000-devel, netdev
On Thursday 13 May 2010, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 12 May 2010 23:07:20 +0200, "Rafael J. Wysocki" said:
> > On Wednesday 12 May 2010, Valdis.Kletnieks@vt.edu wrote:
> > > On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> > > > The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> > > >
> > > > http://userweb.kernel.org/~akpm/mmotm/
> > >
> > > Dell Latitude E6500, x86_64 kernel.
> > >
> > > Died a horrid death at boot in the e1000e driver. Seems to be
> > > something in linux-next.patch. Didn't get a netconsole trace for obvious
> > > reasons...
> > >
> > > Copied-by-hand traceback:
> > > pm_qos_update_request()+0x22
> > > e1000_configure+0x478
> > > e1000_open_device+0xee
> > > ? _raw_notifier_call_chain+0xf
> > > __dev_open+0xec
> > > dev_open+0x1b
> > > netpoll_setup+0x28b
> > > init_netconsole+0xbc
> > >
> > > I suspect this commit:
> > >
> > > commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> > > Author: Rafael J. Wysocki <rjw@sisk.pl>
> > > Date: Sun Mar 14 14:35:17 2010 +0000
> > >
> > > e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
> >
> > No, I don't think so. I'm running -rc6 with this patch applied on a box with
> > e1000e and it works just fine.
> >
> > Please try to revert this one instead:
> >
> > http://git.kernel.org/?p=linux/kernel/git/rafael/suspend-2.6.git;a=patch;h=ed77134bfccf5e75b6cbadab268e559dbe6a4ebb
>
> Confirming - reverting that patch and doing the build fixup results in a
> kernel that doesn't blow up in the e1000e driver...
Can you try the tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/suspend-2.6.git linux-next
without the other linux-next changes, please?
I'm not seeing the problem you're reporting on my test box with e1000e.
Rafael
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH -mmotm] misc: fix ad525X_dpot build
2010-05-12 1:21 mmotm 2010-05-11-18-20 uploaded akpm
2010-05-12 16:50 ` mmotm 2010-05-11-18-20 uploaded (aio build) Randy Dunlap
2010-05-12 19:52 ` mmotm 2010-05-11 - dies in pm_qos_update_request() Valdis.Kletnieks
@ 2010-05-12 20:39 ` Randy Dunlap
2010-05-12 20:53 ` Hennerich, Michael
2010-05-12 20:39 ` [PATCH -mmotm] backlight: fix adp8860_bl build errors Randy Dunlap
2010-05-13 15:06 ` mmotm 2010-05-11-18-20 uploaded Valdis.Kletnieks
4 siblings, 1 reply; 24+ messages in thread
From: Randy Dunlap @ 2010-05-12 20:39 UTC (permalink / raw)
To: akpm, Michael Hennerich; +Cc: linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Add slab.h to fix build:
drivers/misc/ad525x_dpot.c:609: error: implicit declaration of function 'kzalloc'
drivers/misc/ad525x_dpot.c:609: warning: assignment makes pointer from integer without a cast
drivers/misc/ad525x_dpot.c:656: error: implicit declaration of function 'kfree'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
---
drivers/misc/ad525x_dpot.c | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2010-0511-1820.orig/drivers/misc/ad525x_dpot.c
+++ mmotm-2010-0511-1820/drivers/misc/ad525x_dpot.c
@@ -70,6 +70,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/delay.h>
+#include <linux/slab.h>
#define DRIVER_VERSION "0.2"
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH -mmotm] misc: fix ad525X_dpot build
2010-05-12 20:39 ` [PATCH -mmotm] misc: fix ad525X_dpot build Randy Dunlap
@ 2010-05-12 20:53 ` Hennerich, Michael
0 siblings, 0 replies; 24+ messages in thread
From: Hennerich, Michael @ 2010-05-12 20:53 UTC (permalink / raw)
To: Randy Dunlap, akpm@linux-foundation.org; +Cc: linux-kernel@vger.kernel.org
Randy Dunlap wrote on 2010-05-12:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add slab.h to fix build:
>
> drivers/misc/ad525x_dpot.c:609: error: implicit declaration of
> function 'kzalloc'
> drivers/misc/ad525x_dpot.c:609: warning: assignment makes pointer from
> integer without a cast
> drivers/misc/ad525x_dpot.c:656: error: implicit declaration of
> function 'kfree'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Thanks!
> ---
> drivers/misc/ad525x_dpot.c | 1 +
> 1 file changed, 1 insertion(+)
> --- mmotm-2010-0511-1820.orig/drivers/misc/ad525x_dpot.c
> +++ mmotm-2010-0511-1820/drivers/misc/ad525x_dpot.c
> @@ -70,6 +70,7 @@
> #include <linux/kernel.h>
> #include <linux/init.h>
> #include <linux/delay.h>
> +#include <linux/slab.h>
>
> #define DRIVER_VERSION "0.2"
Greetings,
Michael
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH -mmotm] backlight: fix adp8860_bl build errors
2010-05-12 1:21 mmotm 2010-05-11-18-20 uploaded akpm
` (2 preceding siblings ...)
2010-05-12 20:39 ` [PATCH -mmotm] misc: fix ad525X_dpot build Randy Dunlap
@ 2010-05-12 20:39 ` Randy Dunlap
2010-05-12 20:54 ` Hennerich, Michael
2010-05-13 15:06 ` mmotm 2010-05-11-18-20 uploaded Valdis.Kletnieks
4 siblings, 1 reply; 24+ messages in thread
From: Randy Dunlap @ 2010-05-12 20:39 UTC (permalink / raw)
To: akpm, Michael Hennerich; +Cc: linux-kernel
From: Randy Dunlap <randy.dunlap@oracle.com>
Add slab.h to fix part of build.
Add a parameter in backlight_device_register() call to fix part of build.
drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of function 'kzalloc'
drivers/video/backlight/adp8860_bl.c:215: warning: assignment makes pointer from integer without a cast
drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of function 'kfree'
drivers/video/backlight/adp8860_bl.c:673: warning: assignment makes pointer from integer without a cast
drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to function 'backlight_device_register'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
---
drivers/video/backlight/adp8860_bl.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--- mmotm-2010-0511-1820.orig/drivers/video/backlight/adp8860_bl.c
+++ mmotm-2010-0511-1820/drivers/video/backlight/adp8860_bl.c
@@ -16,6 +16,7 @@
#include <linux/fb.h>
#include <linux/backlight.h>
#include <linux/leds.h>
+#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/i2c/adp8860.h>
@@ -647,6 +648,7 @@ static int __devinit adp8860_probe(struc
struct adp8860_bl *data;
struct adp8860_backlight_platform_data *pdata =
client->dev.platform_data;
+ struct backlight_properties props;
uint8_t reg_val;
int ret;
@@ -683,10 +685,13 @@ static int __devinit adp8860_probe(struc
data->current_brightness = 0;
i2c_set_clientdata(client, data);
+ memset(&props, 0, sizeof(props));
+ props.max_brightness = ADP8860_MAX_BRIGHTNESS;
+
mutex_init(&data->lock);
bl = backlight_device_register(dev_driver_string(&client->dev),
- &client->dev, data, &adp8860_bl_ops);
+ &client->dev, data, &adp8860_bl_ops, &props);
if (IS_ERR(bl)) {
dev_err(&client->dev, "failed to register backlight\n");
ret = PTR_ERR(bl);
^ permalink raw reply [flat|nested] 24+ messages in thread* RE: [PATCH -mmotm] backlight: fix adp8860_bl build errors
2010-05-12 20:39 ` [PATCH -mmotm] backlight: fix adp8860_bl build errors Randy Dunlap
@ 2010-05-12 20:54 ` Hennerich, Michael
0 siblings, 0 replies; 24+ messages in thread
From: Hennerich, Michael @ 2010-05-12 20:54 UTC (permalink / raw)
To: Randy Dunlap, akpm@linux-foundation.org; +Cc: linux-kernel@vger.kernel.org
Randy Dunlap wrote on 2010-05-12:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add slab.h to fix part of build. Add a parameter in
> backlight_device_register() call to fix part of build.
>
> drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration
> of function 'kzalloc'
> drivers/video/backlight/adp8860_bl.c:215: warning: assignment makes
> pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration
> of function 'kfree'
> drivers/video/backlight/adp8860_bl.c:673: warning: assignment makes
> pointer from integer without a cast
> drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to
> function 'backlight_device_register'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Thanks!
> ---
> drivers/video/backlight/adp8860_bl.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> --- mmotm-2010-0511-1820.orig/drivers/video/backlight/adp8860_bl.c
> +++ mmotm-2010-0511-1820/drivers/video/backlight/adp8860_bl.c
> @@ -16,6 +16,7 @@
> #include <linux/fb.h> #include <linux/backlight.h> #include
> <linux/leds.h> +#include <linux/slab.h> #include <linux/workqueue.h>
>
> #include <linux/i2c/adp8860.h> @@ -647,6 +648,7 @@ static int __devinit
> adp8860_probe(struc struct adp8860_bl *data; struct
> adp8860_backlight_platform_data *pdata = client->dev.platform_data;
> + struct backlight_properties props; uint8_t reg_val; int ret;
> @@ -683,10 +685,13 @@ static int __devinit adp8860_probe(struc
> data->current_brightness = 0;
> i2c_set_clientdata(client, data);
> + memset(&props, 0, sizeof(props));
> + props.max_brightness = ADP8860_MAX_BRIGHTNESS;
> +
> mutex_init(&data->lock);
>
> bl = backlight_device_register(dev_driver_string(&client->dev),
> - &client->dev, data, &adp8860_bl_ops);
> + &client->dev, data, &adp8860_bl_ops, &props);
> if (IS_ERR(bl)) {
> dev_err(&client->dev, "failed to register backlight\n");
> ret = PTR_ERR(bl);
Greetings,
Michael
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded
2010-05-12 1:21 mmotm 2010-05-11-18-20 uploaded akpm
` (3 preceding siblings ...)
2010-05-12 20:39 ` [PATCH -mmotm] backlight: fix adp8860_bl build errors Randy Dunlap
@ 2010-05-13 15:06 ` Valdis.Kletnieks
2010-05-13 16:02 ` Dmitry Torokhov
4 siblings, 1 reply; 24+ messages in thread
From: Valdis.Kletnieks @ 2010-05-13 15:06 UTC (permalink / raw)
To: Andrew Morton, Mauro Carvalho Chehab, Dmitry Torokhov
Cc: linux-kernel, linux-input
[-- Attachment #1: Type: text/plain, Size: 3685 bytes --]
On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
Dell Latitude E6500, x86_64 kernel.
Boots to single user prompt, but has issues on the way there. Possibly
very important - I was definitely *not* typing at the time (as I had hit
return on the LUKS passphrase for the disk at 36 seconds after boot, and
I didn't get the # prompt for single-user for another minute or two (probably
due to udev having issues due to the oops). So I have no idea what it was
trying to get a keycode for...
[ 40.717136] udev: starting version 154
[ 41.710153] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 41.711007] IP: [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
[ 41.711007] PGD 11d318067 PUD 118af1067 PMD 0
[ 41.711007] Oops: 0002 [#1] PREEMPT SMP
[ 41.711007] last sysfs file: /sys/devices/pci0000:00/0000:00:1a.7/usb1/1-4/idVendor
[ 41.711007] CPU 0
[ 41.711007] Modules linked in:
[ 41.711007]
[ 41.711007] Pid: 2501, comm: keymap Not tainted 2.6.34-rc7-mmotm0511 #2 0X564R/Latitude E6500
[ 41.711007] RIP: 0010:[<ffffffff813bb996>] [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
[ 41.711007] RSP: 0018:ffff88011d513cc8 EFLAGS: 00010046
[ 41.711007] RAX: 0000000000000081 RBX: ffff88011c004000 RCX: 0000000000000081
[ 41.711007] RDX: 0000000000000000 RSI: ffff88011d513ce8 RDI: ffff88011c004000
[ 41.711007] RBP: ffff88011d513cc8 R08: 0000000000000002 R09: 0000000000000001
[ 41.711007] R10: 0000000000000069 R11: 0000000000000002 R12: ffff88011d513ce8
[ 41.711007] R13: ffff88011c004830 R14: 0000000000000282 R15: ffff88011c0c1800
[ 41.711007] FS: 00007f7da81f1700(0000) GS:ffff880002600000(0000) knlGS:0000000000000000
[ 41.711007] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 41.711007] CR2: 0000000000000000 CR3: 0000000119d96000 CR4: 00000000000406f0
[ 41.711007] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 41.711007] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 41.711007] Process keymap (pid: 2501, threadinfo ffff88011d512000, task ffff88011cea2240)
[ 41.711007] Stack:
[ 41.711007] ffff88011d513d28 ffffffff813bdb62 ffff88011d513fd8 ffff88011d513dd4
[ 41.711007] <0> 0000008100000000 0000000000000004 0000000000000000 0000000000000000
[ 41.711007] <0> 0000000080084504 00007fffb1390a20 ffff88011c004000 ffff88011b9305c0
[ 41.711007] Call Trace:
[ 41.711007] [<ffffffff813bdb62>] input_get_keycode+0x5e/0x85
[ 41.711007] [<ffffffff813c094b>] evdev_do_ioctl+0x1cd/0x79b
[ 41.711007] [<ffffffff813c0f56>] ? evdev_ioctl_handler+0x3d/0x80
[ 41.711007] [<ffffffff813c0f56>] ? evdev_ioctl_handler+0x3d/0x80
[ 41.711007] [<ffffffff813c0f7c>] evdev_ioctl_handler+0x63/0x80
[ 41.711007] [<ffffffff813c0fb6>] evdev_ioctl+0xb/0xd
[ 41.711007] [<ffffffff810e97f9>] vfs_ioctl+0x2d/0xa1
[ 41.711007] [<ffffffff810e9d9c>] do_vfs_ioctl+0x4b8/0x4fe
[ 41.711007] [<ffffffff810e9e39>] sys_ioctl+0x57/0x95
[ 41.711007] [<ffffffff810025eb>] system_call_fastpath+0x16/0x1b
[ 41.711007] Code: c8 48 8b 97 d0 00 00 00 75 18 eb 10 48 63 d0 48 8b 8f d0 00 00 00 0f b6 14 11 eb 09 0f b7 14 4a eb 03 8b 14 8a 89 16 48 8b 56 18 <89> 02 31 c0 eb 05 b8 ea ff ff ff c9 c3 55 8b 56 08 4889 e5 83
[ 41.711007] RIP [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
[ 41.711007] RSP <ffff88011d513cc8>
[ 41.711007] CR2: 0000000000000000
[ 41.711007] ---[ end trace 51c151638ede785c ]---
[ 41.711007] note: keymap[2501] exited with preempt_count 1
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: mmotm 2010-05-11-18-20 uploaded
2010-05-13 15:06 ` mmotm 2010-05-11-18-20 uploaded Valdis.Kletnieks
@ 2010-05-13 16:02 ` Dmitry Torokhov
2010-05-13 16:20 ` Mauro Carvalho Chehab
2010-05-19 23:34 ` Mauro Carvalho Chehab
0 siblings, 2 replies; 24+ messages in thread
From: Dmitry Torokhov @ 2010-05-13 16:02 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: Andrew Morton, Mauro Carvalho Chehab, linux-kernel, linux-input
On Thu, May 13, 2010 at 11:06:34AM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Dell Latitude E6500, x86_64 kernel.
>
> Boots to single user prompt, but has issues on the way there. Possibly
> very important - I was definitely *not* typing at the time (as I had hit
> return on the LUKS passphrase for the disk at 36 seconds after boot, and
> I didn't get the # prompt for single-user for another minute or two (probably
> due to udev having issues due to the oops). So I have no idea what it was
> trying to get a keycode for...
>
Udev probably tries to remap special keys on your keyboard...
> [ 40.717136] udev: starting version 154
> [ 41.710153] BUG: unable to handle kernel NULL pointer dereference at (null)
> [ 41.711007] IP: [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
> [ 41.711007] PGD 11d318067 PUD 118af1067 PMD 0
> [ 41.711007] Oops: 0002 [#1] PREEMPT SMP
> [ 41.711007] last sysfs file: /sys/devices/pci0000:00/0000:00:1a.7/usb1/1-4/idVendor
> [ 41.711007] CPU 0
> [ 41.711007] Modules linked in:
> [ 41.711007]
> [ 41.711007] Pid: 2501, comm: keymap Not tainted 2.6.34-rc7-mmotm0511 #2 0X564R/Latitude E6500
>
> [ 41.711007] RIP: 0010:[<ffffffff813bb996>] [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
I think this is Mauro's big keycode additions.
--
Dmitry
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded
2010-05-13 16:02 ` Dmitry Torokhov
@ 2010-05-13 16:20 ` Mauro Carvalho Chehab
2010-05-13 16:29 ` Valdis.Kletnieks
2010-05-19 23:34 ` Mauro Carvalho Chehab
1 sibling, 1 reply; 24+ messages in thread
From: Mauro Carvalho Chehab @ 2010-05-13 16:20 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Valdis.Kletnieks, Andrew Morton, linux-kernel, linux-input
Dmitry Torokhov wrote:
> On Thu, May 13, 2010 at 11:06:34AM -0400, Valdis.Kletnieks@vt.edu wrote:
>> On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
>>> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/
>> Dell Latitude E6500, x86_64 kernel.
>>
>> Boots to single user prompt, but has issues on the way there. Possibly
>> very important - I was definitely *not* typing at the time (as I had hit
>> return on the LUKS passphrase for the disk at 36 seconds after boot, and
>> I didn't get the # prompt for single-user for another minute or two (probably
>> due to udev having issues due to the oops). So I have no idea what it was
>> trying to get a keycode for...
>>
>
> Udev probably tries to remap special keys on your keyboard...
>
>> [ 40.717136] udev: starting version 154
>> [ 41.710153] BUG: unable to handle kernel NULL pointer dereference at (null)
>> [ 41.711007] IP: [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>> [ 41.711007] PGD 11d318067 PUD 118af1067 PMD 0
>> [ 41.711007] Oops: 0002 [#1] PREEMPT SMP
>> [ 41.711007] last sysfs file: /sys/devices/pci0000:00/0000:00:1a.7/usb1/1-4/idVendor
>> [ 41.711007] CPU 0
>> [ 41.711007] Modules linked in:
>> [ 41.711007]
>> [ 41.711007] Pid: 2501, comm: keymap Not tainted 2.6.34-rc7-mmotm0511 #2 0X564R/Latitude E6500
>>
>> [ 41.711007] RIP: 0010:[<ffffffff813bb996>] [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>
> I think this is Mauro's big keycode additions.
Yes, it is likely. It may be caused by some bad conflict resolution between both git trees.
I'll handle this bug.
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded
2010-05-13 16:20 ` Mauro Carvalho Chehab
@ 2010-05-13 16:29 ` Valdis.Kletnieks
2010-05-13 17:32 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 24+ messages in thread
From: Valdis.Kletnieks @ 2010-05-13 16:29 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Dmitry Torokhov, Andrew Morton, linux-kernel, linux-input
[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]
On Thu, 13 May 2010 13:20:50 -0300, Mauro Carvalho Chehab said:
> Dmitry Torokhov wrote:
> > On Thu, May 13, 2010 at 11:06:34AM -0400, Valdis.Kletnieks@vt.edu wrote:
> >> On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
> >>> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
> >>>
> >>> http://userweb.kernel.org/~akpm/mmotm/
> >> Dell Latitude E6500, x86_64 kernel.
> >>
> >> Boots to single user prompt, but has issues on the way there. Possibly
> >> very important - I was definitely *not* typing at the time (as I had hit
> >> return on the LUKS passphrase for the disk at 36 seconds after boot, and
> >> I didn't get the # prompt for single-user for another minute or two (probably
> >> due to udev having issues due to the oops). So I have no idea what it was
> >> trying to get a keycode for...
> >>
> >
> > Udev probably tries to remap special keys on your keyboard...
> >
> >> [ 40.717136] udev: starting version 154
> >> [ 41.710153] BUG: unable to handle kernel NULL pointer dereference at (null)
> >> [ 41.711007] IP: [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
> >> [ 41.711007] PGD 11d318067 PUD 118af1067 PMD 0
> >> [ 41.711007] Oops: 0002 [#1] PREEMPT SMP
> >> [ 41.711007] last sysfs file: /sys/devices/pci0000:00/0000:00:1a.7/usb1/1-4/idVendor
> >> [ 41.711007] CPU 0
> >> [ 41.711007] Modules linked in:
> >> [ 41.711007]
> >> [ 41.711007] Pid: 2501, comm: keymap Not tainted 2.6.34-rc7-mmotm0511 #2 0X564R/Latitude E6500
> >>
> >> [ 41.711007] RIP: 0010:[<ffffffff813bb996>] [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
> >
> > I think this is Mauro's big keycode additions.
>
> Yes, it is likely. It may be caused by some bad conflict resolution between both git trees.
> I'll handle this bug.
Feel free to let me know if there's any testing/instrumentation you want done...
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded
2010-05-13 16:29 ` Valdis.Kletnieks
@ 2010-05-13 17:32 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 24+ messages in thread
From: Mauro Carvalho Chehab @ 2010-05-13 17:32 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: Dmitry Torokhov, Andrew Morton, linux-kernel, linux-input
Valdis.Kletnieks@vt.edu wrote:
> On Thu, 13 May 2010 13:20:50 -0300, Mauro Carvalho Chehab said:
>> Dmitry Torokhov wrote:
>>> On Thu, May 13, 2010 at 11:06:34AM -0400, Valdis.Kletnieks@vt.edu wrote:
>>>> On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
>>>>> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>>>>>
>>>>> http://userweb.kernel.org/~akpm/mmotm/
>>>> Dell Latitude E6500, x86_64 kernel.
>>>>
>>>> Boots to single user prompt, but has issues on the way there. Possibly
>>>> very important - I was definitely *not* typing at the time (as I had hit
>>>> return on the LUKS passphrase for the disk at 36 seconds after boot, and
>>>> I didn't get the # prompt for single-user for another minute or two (probably
>>>> due to udev having issues due to the oops). So I have no idea what it was
>>>> trying to get a keycode for...
>>>>
>>> Udev probably tries to remap special keys on your keyboard...
>>>
>>>> [ 40.717136] udev: starting version 154
>>>> [ 41.710153] BUG: unable to handle kernel NULL pointer dereference at (null)
>>>> [ 41.711007] IP: [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>>>> [ 41.711007] PGD 11d318067 PUD 118af1067 PMD 0
>>>> [ 41.711007] Oops: 0002 [#1] PREEMPT SMP
>>>> [ 41.711007] last sysfs file: /sys/devices/pci0000:00/0000:00:1a.7/usb1/1-4/idVendor
>>>> [ 41.711007] CPU 0
>>>> [ 41.711007] Modules linked in:
>>>> [ 41.711007]
>>>> [ 41.711007] Pid: 2501, comm: keymap Not tainted 2.6.34-rc7-mmotm0511 #2 0X564R/Latitude E6500
>>>>
>>>> [ 41.711007] RIP: 0010:[<ffffffff813bb996>] [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>>> I think this is Mauro's big keycode additions.
>> Yes, it is likely. It may be caused by some bad conflict resolution between both git trees.
>> I'll handle this bug.
>
> Feel free to let me know if there's any testing/instrumentation you want done...
>
Ok. I probably won't have time for handing it until next week, as I'll be traveling
tomorrow for a short trip.
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded
2010-05-13 16:02 ` Dmitry Torokhov
2010-05-13 16:20 ` Mauro Carvalho Chehab
@ 2010-05-19 23:34 ` Mauro Carvalho Chehab
2010-05-20 4:57 ` Mauro Carvalho Chehab
1 sibling, 1 reply; 24+ messages in thread
From: Mauro Carvalho Chehab @ 2010-05-19 23:34 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Valdis.Kletnieks, Andrew Morton, linux-kernel, linux-input
Dmitry Torokhov wrote:
> On Thu, May 13, 2010 at 11:06:34AM -0400, Valdis.Kletnieks@vt.edu wrote:
>> On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
>>> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>>>
>>> http://userweb.kernel.org/~akpm/mmotm/
>> Dell Latitude E6500, x86_64 kernel.
>>
>> Boots to single user prompt, but has issues on the way there. Possibly
>> very important - I was definitely *not* typing at the time (as I had hit
>> return on the LUKS passphrase for the disk at 36 seconds after boot, and
>> I didn't get the # prompt for single-user for another minute or two (probably
>> due to udev having issues due to the oops). So I have no idea what it was
>> trying to get a keycode for...
>>
>
> Udev probably tries to remap special keys on your keyboard...
>
>> [ 40.717136] udev: starting version 154
>> [ 41.710153] BUG: unable to handle kernel NULL pointer dereference at (null)
>> [ 41.711007] IP: [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>> [ 41.711007] PGD 11d318067 PUD 118af1067 PMD 0
>> [ 41.711007] Oops: 0002 [#1] PREEMPT SMP
>> [ 41.711007] last sysfs file: /sys/devices/pci0000:00/0000:00:1a.7/usb1/1-4/idVendor
>> [ 41.711007] CPU 0
>> [ 41.711007] Modules linked in:
>> [ 41.711007]
>> [ 41.711007] Pid: 2501, comm: keymap Not tainted 2.6.34-rc7-mmotm0511 #2 0X564R/Latitude E6500
>>
>> [ 41.711007] RIP: 0010:[<ffffffff813bb996>] [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>
> I think this is Mauro's big keycode additions.
>
Ok, I was able to reproduce the bug:
# getkeycodes
[22726.468755] BUG: unable to handle kernel NULL pointer dereference at (null)
[22726.471074] IP: [<c138b6d0>] input_default_getkeycode_from_index+0x40/0x60
[22726.471074] *pde = 00000000
[22726.471074] Oops: 0002 [#1] SMP
[22726.471074] last sysfs file: /sys/devices/pci0000:00/0000:00:0b.1/usb1/1-3/dm
[22726.471074] Modules linked in: ip6t_REJECT nf_conntrack_ipv6 ip6table_filter]
[22726.471074]
[22726.471074] Pid: 947, comm: getkeycodes Not tainted 2.6.34 #6 C51MCP51/
[22726.471074] EIP: 0060:[<c138b6d0>] EFLAGS: 00210046 CPU: 0
[22726.471074] EIP is at input_default_getkeycode_from_index+0x40/0x60
[22726.471074] EAX: 00000000 EBX: 00000000 ECX: 00000002 EDX: dacfbdc8
[22726.471074] ESI: dacfbdc8 EDI: f5daf794 EBP: dacfbdb8 ESP: dacfbdb4
[22726.471074] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
[22726.471074] Process getkeycodes (pid: 947, ti=dacfa000 task=f573d4a0 task.ti)
[22726.471074] Stack:
[22726.471074] f5daf000 dacfbdec c138d233 dacfbe30 00200286 00000000 00000000 4
[22726.471074] <0> 00000000 00000000 00000000 dacfbe2c f5da0340 c16c12cc dacfbd8
[22726.471074] <0> c12f4130 dacfbe24 c138d9f8 00000002 00000001 00000000 c138d90
[22726.471074] Call Trace:
[22726.471074] [<c138d233>] ? input_get_keycode+0x73/0x90
[22726.471074] [<c12f4148>] ? getkeycode_helper+0x18/0x30
[22726.471074] [<c12f4130>] ? getkeycode_helper+0x0/0x30
[22726.471074] [<c138d9f8>] ? input_handler_for_each_handle+0x78/0xa0
[22726.471074] [<c138d980>] ? input_handler_for_each_handle+0x0/0xa0
[22726.471074] [<c12f4130>] ? getkeycode_helper+0x0/0x30
[22726.471074] [<c12f399e>] ? getkeycode+0x2e/0x40
[22726.471074] [<c12f16ab>] ? vt_ioctl+0xb9b/0x1960
[22726.471074] [<c12ed600>] ? tty_ldisc_try+0x20/0x50
[22726.471074] [<c12ed8da>] ? put_ldisc+0x4a/0xd0
[22726.471074] [<c107649c>] ? trace_hardirqs_on_caller+0x12c/0x170
[22726.471074] [<c10764eb>] ? trace_hardirqs_on+0xb/0x10
[22726.471074] [<c12f0b10>] ? vt_ioctl+0x0/0x1960
[22726.471074] [<c12e74bf>] ? tty_ioctl+0x7f/0x8a0
[22726.471074] [<c11150e2>] ? vfs_ioctl+0x32/0xc0
[22726.471074] [<c12e7440>] ? tty_ioctl+0x0/0x8a0
[22726.471074] [<c111584a>] ? do_vfs_ioctl+0x6a/0x5d0
[22726.471074] [<c10fc455>] ? kmem_cache_free+0x85/0xc0
[22726.471074] [<c107649c>] ? trace_hardirqs_on_caller+0x12c/0x170
[22726.471074] [<c10764eb>] ? trace_hardirqs_on+0xb/0x10
[22726.471074] [<c111070b>] ? putname+0x2b/0x40
[22726.471074] [<c1105523>] ? do_sys_open+0xf3/0x110
[22726.471074] [<c1097f13>] ? audit_syscall_entry+0x1e3/0x210
[22726.471074] [<c1115e17>] ? sys_ioctl+0x67/0x80
[22726.471074] [<c1002fdf>] ? sysenter_do_call+0x12/0x38
[22726.471074] Code: 0a b8 ea ff ff ff 5b 5d c3 66 90 3b 98 a4 00 00 00 73 ee 8
[22726.471074] EIP: [<c138b6d0>] input_default_getkeycode_from_index+0x40/0x60 4
[22726.471074] CR2: 0000000000000000
[22726.471074] ---[ end trace 4ee8ba470bac54f1 ]---
I've removed the big getkeycode stuff from the material I've submitted earlier
today for 2.6.35. I'm currently working on fix the issue.
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: mmotm 2010-05-11-18-20 uploaded
2010-05-19 23:34 ` Mauro Carvalho Chehab
@ 2010-05-20 4:57 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 24+ messages in thread
From: Mauro Carvalho Chehab @ 2010-05-20 4:57 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Valdis.Kletnieks, Andrew Morton, linux-kernel, linux-input
Mauro Carvalho Chehab wrote:
> Dmitry Torokhov wrote:
>> On Thu, May 13, 2010 at 11:06:34AM -0400, Valdis.Kletnieks@vt.edu wrote:
>>> On Tue, 11 May 2010 18:21:22 PDT, akpm@linux-foundation.org said:
>>>> The mm-of-the-moment snapshot 2010-05-11-18-20 has been uploaded to
>>>>
>>>> http://userweb.kernel.org/~akpm/mmotm/
>>> Dell Latitude E6500, x86_64 kernel.
>>>
>>> Boots to single user prompt, but has issues on the way there. Possibly
>>> very important - I was definitely *not* typing at the time (as I had hit
>>> return on the LUKS passphrase for the disk at 36 seconds after boot, and
>>> I didn't get the # prompt for single-user for another minute or two (probably
>>> due to udev having issues due to the oops). So I have no idea what it was
>>> trying to get a keycode for...
>>>
>> Udev probably tries to remap special keys on your keyboard...
>>
>>> [ 40.717136] udev: starting version 154
>>> [ 41.710153] BUG: unable to handle kernel NULL pointer dereference at (null)
>>> [ 41.711007] IP: [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>>> [ 41.711007] PGD 11d318067 PUD 118af1067 PMD 0
>>> [ 41.711007] Oops: 0002 [#1] PREEMPT SMP
>>> [ 41.711007] last sysfs file: /sys/devices/pci0000:00/0000:00:1a.7/usb1/1-4/idVendor
>>> [ 41.711007] CPU 0
>>> [ 41.711007] Modules linked in:
>>> [ 41.711007]
>>> [ 41.711007] Pid: 2501, comm: keymap Not tainted 2.6.34-rc7-mmotm0511 #2 0X564R/Latitude E6500
>>>
>>> [ 41.711007] RIP: 0010:[<ffffffff813bb996>] [<ffffffff813bb996>] input_default_getkeycode_from_index+0x4e/0x5b
>> I think this is Mauro's big keycode additions.
>>
>
> Ok, I was able to reproduce the bug:
>
> # getkeycodes
> [22726.468755] BUG: unable to handle kernel NULL pointer dereference at (null)
> [22726.471074] IP: [<c138b6d0>] input_default_getkeycode_from_index+0x40/0x60
> [22726.471074] *pde = 00000000
> [22726.471074] Oops: 0002 [#1] SMP
> [22726.471074] last sysfs file: /sys/devices/pci0000:00/0000:00:0b.1/usb1/1-3/dm
> [22726.471074] Modules linked in: ip6t_REJECT nf_conntrack_ipv6 ip6table_filter]
> [22726.471074]
> [22726.471074] Pid: 947, comm: getkeycodes Not tainted 2.6.34 #6 C51MCP51/
> [22726.471074] EIP: 0060:[<c138b6d0>] EFLAGS: 00210046 CPU: 0
> [22726.471074] EIP is at input_default_getkeycode_from_index+0x40/0x60
> [22726.471074] EAX: 00000000 EBX: 00000000 ECX: 00000002 EDX: dacfbdc8
> [22726.471074] ESI: dacfbdc8 EDI: f5daf794 EBP: dacfbdb8 ESP: dacfbdb4
> [22726.471074] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
> [22726.471074] Process getkeycodes (pid: 947, ti=dacfa000 task=f573d4a0 task.ti)
> [22726.471074] Stack:
> [22726.471074] f5daf000 dacfbdec c138d233 dacfbe30 00200286 00000000 00000000 4
> [22726.471074] <0> 00000000 00000000 00000000 dacfbe2c f5da0340 c16c12cc dacfbd8
> [22726.471074] <0> c12f4130 dacfbe24 c138d9f8 00000002 00000001 00000000 c138d90
> [22726.471074] Call Trace:
> [22726.471074] [<c138d233>] ? input_get_keycode+0x73/0x90
> [22726.471074] [<c12f4148>] ? getkeycode_helper+0x18/0x30
> [22726.471074] [<c12f4130>] ? getkeycode_helper+0x0/0x30
> [22726.471074] [<c138d9f8>] ? input_handler_for_each_handle+0x78/0xa0
> [22726.471074] [<c138d980>] ? input_handler_for_each_handle+0x0/0xa0
> [22726.471074] [<c12f4130>] ? getkeycode_helper+0x0/0x30
> [22726.471074] [<c12f399e>] ? getkeycode+0x2e/0x40
> [22726.471074] [<c12f16ab>] ? vt_ioctl+0xb9b/0x1960
> [22726.471074] [<c12ed600>] ? tty_ldisc_try+0x20/0x50
> [22726.471074] [<c12ed8da>] ? put_ldisc+0x4a/0xd0
> [22726.471074] [<c107649c>] ? trace_hardirqs_on_caller+0x12c/0x170
> [22726.471074] [<c10764eb>] ? trace_hardirqs_on+0xb/0x10
> [22726.471074] [<c12f0b10>] ? vt_ioctl+0x0/0x1960
> [22726.471074] [<c12e74bf>] ? tty_ioctl+0x7f/0x8a0
> [22726.471074] [<c11150e2>] ? vfs_ioctl+0x32/0xc0
> [22726.471074] [<c12e7440>] ? tty_ioctl+0x0/0x8a0
> [22726.471074] [<c111584a>] ? do_vfs_ioctl+0x6a/0x5d0
> [22726.471074] [<c10fc455>] ? kmem_cache_free+0x85/0xc0
> [22726.471074] [<c107649c>] ? trace_hardirqs_on_caller+0x12c/0x170
> [22726.471074] [<c10764eb>] ? trace_hardirqs_on+0xb/0x10
> [22726.471074] [<c111070b>] ? putname+0x2b/0x40
> [22726.471074] [<c1105523>] ? do_sys_open+0xf3/0x110
> [22726.471074] [<c1097f13>] ? audit_syscall_entry+0x1e3/0x210
> [22726.471074] [<c1115e17>] ? sys_ioctl+0x67/0x80
> [22726.471074] [<c1002fdf>] ? sysenter_do_call+0x12/0x38
> [22726.471074] Code: 0a b8 ea ff ff ff 5b 5d c3 66 90 3b 98 a4 00 00 00 73 ee 8
> [22726.471074] EIP: [<c138b6d0>] input_default_getkeycode_from_index+0x40/0x60 4
> [22726.471074] CR2: 0000000000000000
> [22726.471074] ---[ end trace 4ee8ba470bac54f1 ]---
>
> I've removed the big getkeycode stuff from the material I've submitted earlier
> today for 2.6.35. I'm currently working on fix the issue.
OK, I just sent the one-line fix to LMML and input ML.
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 24+ messages in thread