From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Vernon Mauery <vernux@us.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add support for Westmere to i7core_edac driver
Date: Tue, 18 May 2010 16:00:14 -0300 [thread overview]
Message-ID: <4BF2E3BE.4020101@redhat.com> (raw)
In-Reply-To: <20100518184653.GA6511@lucy>
Vernon Mauery wrote:
> Add support for Westmere to i7core_edac driver
>
> This adds new PCI IDs for the Westmere's memory controller
> devices and modifies the i7core_edac driver to be able to
> probe both Nehalem and Westmere processors.
>
> This applies to
> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/i7core.git linux_next
>
> Signed-off-by: Vernon Mauery <vernux@us.ibm.com>
>
> @@ -1170,7 +1213,7 @@ static void i7core_put_all_devices(void)
> i7core_put_devices(i7core_dev);
> }
>
> -static void __init i7core_xeon_pci_fixup(int dev_id)
> +static void i7core_xeon_pci_fixup(struct pci_id_table *table)
> {
> struct pci_dev *pdev = NULL;
> int i;
Hmm... this hunk seems wrong to me. It ir just reverting this patch:
http://git.kernel.org/?p=linux/kernel/git/mchehab/i7core.git;a=commit;h=71753e0141a220ecbf9c71a66e0a8acce9705fb5
The other changes seem OK on my eyes.
--
Cheers,
Mauro
next prev parent reply other threads:[~2010-05-18 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 18:46 [PATCH] Add support for Westmere to i7core_edac driver Vernon Mauery
2010-05-18 19:00 ` Mauro Carvalho Chehab [this message]
2010-05-18 20:18 ` Vernon Mauery
2010-05-18 23:47 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF2E3BE.4020101@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vernux@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox