From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753054Ab0ESOpt (ORCPT <rfc822;w@1wt.eu>);
	Wed, 19 May 2010 10:45:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12148 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752595Ab0ESOps (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 19 May 2010 10:45:48 -0400
Message-ID: <4BF3F930.7050808@redhat.com>
Date: Wed, 19 May 2010 10:44:00 -0400
From: Masami Hiramatsu <mhiramat@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc11 Thunderbird/3.0.4
MIME-Version: 1.0
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
CC: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@elte.hu>,
       Mel Gorman <mel@csn.ul.ie>, Steven Rostedt <rostedt@goodmis.org>,
       Randy Dunlap <rdunlap@xenotime.net>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Roland McGrath <roland@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
       Christoph Hellwig <hch@infradead.org>,
       Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
       Oleg Nesterov <oleg@redhat.com>, Mark Wielaard <mjw@redhat.com>,
       Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
       LKML <linux-kernel@vger.kernel.org>,
       Jim Keniston <jkenisto@linux.vnet.ibm.com>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       "Rafael J. Wysocki" <rjw@sisk.pl>, "Frank Ch. Eigler" <fche@redhat.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 10/13] trace: Common code for kprobes/uprobes traceevents
References: <20100518165826.20070.11594.sendpatchset@localhost6.localdomain6> <20100518170024.20070.25438.sendpatchset@localhost6.localdomain6> <4BF2CD2F.8000104@redhat.com> <20100519062142.GD19957@linux.vnet.ibm.com>
In-Reply-To: <20100519062142.GD19957@linux.vnet.ibm.com>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Srikar Dronamraju wrote:
>>
>> Isn't it a common header for kprobes and uprobes? :)
>>
>> Maybe "Probe-based dynamic events common header" ?
>>
> 
> Agree.
> 
>>> +#define MAX_TRACE_ARGS 128
>>> +#define MAX_ARGSTR_LEN 63
>>> +#define MAX_EVENT_NAME_LEN 64
>>> +#define UPROBE_EVENT_SYSTEM "uprobes"
>>
>> You should *just move* the common code in this patch.
>> Additional uprobes code can be introduced in next patch.
>>
> 
> Okay.
> 
>>> +
>>> +/* Flags for trace_probe */
>>> +#define TP_FLAG_TRACE	1
>>> +#define TP_FLAG_PROFILE	2
>>> +#define UPROBE_ENABLED	4
>>
>> If this is a trace_probe flag, it is better to start with TP_FLAG_.
> 
> Okay.
> Does TP_FLAG_UPROBE sound fine?

Sure, that's good for me:)

Thank you,


-- 
Masami Hiramatsu
e-mail: mhiramat@redhat.com