From: "H. Peter Anvin" <hpa@zytor.com>
To: Greg KH <greg@kroah.com>
Cc: Ky Srinivasan <ksrinivasan@novell.com>,
hjanssen@microsoft.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 2/2] Hyperv detection - code cleanup
Date: Wed, 19 May 2010 11:21:49 -0700 [thread overview]
Message-ID: <4BF42C3D.6030404@zytor.com> (raw)
In-Reply-To: <20100519181926.GA22228@kroah.com>
On 05/19/2010 11:19 AM, Greg KH wrote:
> On Wed, May 19, 2010 at 10:50:54AM -0700, H. Peter Anvin wrote:
>> On 05/19/2010 10:20 AM, Ky Srinivasan wrote:
>>> From: K. Y. Srinivasan <ksrinivasan@novell.com>
>>> Subject: Code cleanup - get rid of the "ms" prefix in hyperv related files.
>>>
>>>
>>> Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
>>
>> NAK in the extreme.
>>
>> "hyperv" -- without the capitalization to make it stand out -- is way
>> too easy to read as just an abbreviation for "hypervisor".
>
> Which is what I confused it with, and hence I wrote the ms_* changes in
> my patch. But KY wanted it changed back so I suggested he write a
> patch.
>
> I personally like the ms_ stuff, it makes it more obvious what is going
> on here, but that's just me.
>
Well, I agree with you. Sorry, Ky.
-hpa
next prev parent reply other threads:[~2010-05-19 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 17:20 [PATCH 2/2] Hyperv detection - code cleanup Ky Srinivasan
2010-05-19 17:50 ` H. Peter Anvin
2010-05-19 18:19 ` Greg KH
2010-05-19 18:21 ` H. Peter Anvin [this message]
2010-05-19 18:33 ` Ky Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF42C3D.6030404@zytor.com \
--to=hpa@zytor.com \
--cc=avi@redhat.com \
--cc=greg@kroah.com \
--cc=hjanssen@microsoft.com \
--cc=ksrinivasan@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox