From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878Ab0ESVLt (ORCPT ); Wed, 19 May 2010 17:11:49 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:56307 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787Ab0ESVLr (ORCPT ); Wed, 19 May 2010 17:11:47 -0400 Message-ID: <4BF453E3.2040301@oracle.com> Date: Wed, 19 May 2010 14:10:59 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Alexander Kurz CC: Greg KH , linux-next@vger.kernel.org, fmhess@users.sourceforge.net, Greg KH , Ian Abbott , Dominik Brodowski , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging/comedi: fixing ni_tio to mite PCI dependancy References: <20100514190142.GA2505@kroah.com> <201005142029.37408.fmhess@speakeasy.net> <20100515034423.GA3811@suse.de> <20100519103203.155c9527.randy.dunlap@oracle.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090207.4BF453FB.00B9:SCFMA922111,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/10 13:32, Alexander Kurz wrote: > On Wed, 19 May 2010, Randy Dunlap wrote: >> linux-next of 2010-0519: >> when CONFIG_PCI is not enabled: >> >> drivers/staging/comedi/drivers/mite.c: In function 'mite_init': >> drivers/staging/comedi/drivers/mite.c:89: error: implicit declaration of function 'pci_dev_get' >> drivers/staging/comedi/drivers/mite.c:89: warning: assignment makes pointer from integer without a cast >> make[5]: *** [drivers/staging/comedi/drivers/mite.o] Error 1 > > thanks, this patch is a follow-up to >> [PATCH] staging/comedi: fixing 8255 and DAS08 Kconfig dependancies. > > From 9804b6bc8c997433411b24f477417f8e7cc9a19d Mon Sep 17 00:00:00 2001 > From: Alexander Kurz > Date: Wed, 19 May 2010 22:23:00 +0200 > Subject: [PATCH 2/2] staging/comedi: fixing ni_tio to mite PCI dependancy > > Signed-off-by: Alexander Kurz Acked-by: Randy Dunlap Thanks. > --- > drivers/staging/comedi/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig > index ebc68ee..0aa2b0d 100644 > --- a/drivers/staging/comedi/Kconfig > +++ b/drivers/staging/comedi/Kconfig > @@ -1258,8 +1258,8 @@ config COMEDI_MITE > > config COMEDI_NI_TIO > tristate "NI general purpose counter support" > + depends on COMEDI_MITE > select COMEDI_8255 > - select COMEDI_MITE > default N > ---help--- > Enable support for National Instruments general purpose counters. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***