linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Does anyone care about gcc 3.x support for x86 anymore?
  2010-05-18 21:11       ` Eric Dumazet
@ 2010-05-18 21:38         ` H. Peter Anvin
  2010-05-19 23:10           ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 12+ messages in thread
From: H. Peter Anvin @ 2010-05-18 21:38 UTC (permalink / raw)
  To: Eric Dumazet
  Cc: mingo, linux-kernel, suresh.b.siddha, tglx, avi,
	linux-tip-commits

Recently, we have seen an increasing number of problems with gcc 3.4 on
x86; mostly due to poor constant propagation producing not just bad code
but failing to properly eliminate what should be dead code.

I'm wondering if there is any remaining real use of gcc 3.4 on x86 for
compiling current kernels (as opposed to residual use for compiling
applications on old enterprise distros.)  I'm specifically not referring
to other architectures here -- most of these issues have been in
relation to low-level arch-specific code, and as such only affects the
x86 architectures.  Other architectures may very well have a much
stronger need for continued support of an older toolchain.

If there isn't a reason to preserve support, I would like to consider
discontinue support for using gcc 3 to compile x86 kernels.  If there is
a valid use case, it would be good to know what it is.

	-hpa

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Does anyone care about gcc 3.x support for *x86* anymore?
@ 2010-05-19  1:19 H. Peter Anvin
  2010-05-19  7:13 ` Ingo Molnar
  2010-05-19 13:38 ` Andi Kleen
  0 siblings, 2 replies; 12+ messages in thread
From: H. Peter Anvin @ 2010-05-19  1:19 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: eric.dumazet, Ingo Molnar, Siddha, Suresh B, Thomas Gleixner,
	Avi Kivity

[Reposting as a separate thread]

Recently, we have seen an increasing number of problems with gcc 3.4 on
x86; mostly due to poor constant propagation producing not just bad code
but failing to properly eliminate what should be dead code.

I'm wondering if there is any remaining real use of gcc 3.4 on x86 for
compiling current kernels (as opposed to residual use for compiling
applications on old enterprise distros.)  I'm specifically not referring
to other architectures here -- most of these issues have been in
relation to low-level arch-specific code, and as such only affects the
x86 architectures.  Other architectures may very well have a much
stronger need for continued support of an older toolchain.

If there isn't a reason to preserve support, I would like to consider
discontinue support for using gcc 3 to compile x86 kernels.  If there is
a valid use case, it would be good to know what it is.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for *x86* anymore?
  2010-05-19  1:19 Does anyone care about gcc 3.x support for *x86* anymore? H. Peter Anvin
@ 2010-05-19  7:13 ` Ingo Molnar
  2010-05-19 13:38 ` Andi Kleen
  1 sibling, 0 replies; 12+ messages in thread
From: Ingo Molnar @ 2010-05-19  7:13 UTC (permalink / raw)
  To: H. Peter Anvin, Andrew Morton, Linus Torvalds
  Cc: Linux Kernel Mailing List, eric.dumazet, Siddha, Suresh B,
	Thomas Gleixner, Avi Kivity


(reposted with Andrew and Linus Cc:-ed too)

* H. Peter Anvin <hpa@zytor.com> wrote:

> [Reposting as a separate thread]
> 
> Recently, we have seen an increasing number of problems 
> with gcc 3.4 on x86; mostly due to poor constant 
> propagation producing not just bad code but failing to 
> properly eliminate what should be dead code.
> 
> I'm wondering if there is any remaining real use of gcc 
> 3.4 on x86 for compiling current kernels (as opposed to 
> residual use for compiling applications on old 
> enterprise distros.)  I'm specifically not referring to 
> other architectures here -- most of these issues have 
> been in relation to low-level arch-specific code, and as 
> such only affects the x86 architectures.  Other 
> architectures may very well have a much stronger need 
> for continued support of an older toolchain.
> 
> If there isn't a reason to preserve support, I would 
> like to consider discontinue support for using gcc 3 to 
> compile x86 kernels.  If there is a valid use case, it 
> would be good to know what it is.
> 
> 	-hpa
> 
> -- 
> H. Peter Anvin, Intel Open Source Technology Center
> I work for Intel.  I don't speak on their behalf.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for *x86* anymore?
  2010-05-19  1:19 Does anyone care about gcc 3.x support for *x86* anymore? H. Peter Anvin
  2010-05-19  7:13 ` Ingo Molnar
@ 2010-05-19 13:38 ` Andi Kleen
  2010-05-19 14:08   ` H. Peter Anvin
  2010-05-20 18:37   ` Martin Michlmayr
  1 sibling, 2 replies; 12+ messages in thread
From: Andi Kleen @ 2010-05-19 13:38 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Linux Kernel Mailing List, eric.dumazet, Ingo Molnar,
	Siddha, Suresh B, Thomas Gleixner, Avi Kivity

"H. Peter Anvin" <hpa@zytor.com> writes:
>
> If there isn't a reason to preserve support, I would like to consider
> discontinue support for using gcc 3 to compile x86 kernels.  If there is
> a valid use case, it would be good to know what it is.

I suspect there are still distributions around that use it as a standard
compiler. Wasn't it used in some major release of Debian?

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for *x86* anymore?
  2010-05-19 13:38 ` Andi Kleen
@ 2010-05-19 14:08   ` H. Peter Anvin
  2010-05-19 22:45     ` Justin P. Mattock
  2010-05-20 18:37   ` Martin Michlmayr
  1 sibling, 1 reply; 12+ messages in thread
From: H. Peter Anvin @ 2010-05-19 14:08 UTC (permalink / raw)
  To: Andi Kleen
  Cc: Linux Kernel Mailing List, eric.dumazet, Ingo Molnar,
	Siddha, Suresh B, Thomas Gleixner, Avi Kivity

On 05/19/2010 06:38 AM, Andi Kleen wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>>
>> If there isn't a reason to preserve support, I would like to consider
>> discontinue support for using gcc 3 to compile x86 kernels.  If there is
>> a valid use case, it would be good to know what it is.
> 
> I suspect there are still distributions around that use it as a standard
> compiler. Wasn't it used in some major release of Debian?
> 
> -Andi

There are, but that doesn't mean it's relevant for people to compile
bleeding-edge kernels with it.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for *x86* anymore?
  2010-05-19 14:08   ` H. Peter Anvin
@ 2010-05-19 22:45     ` Justin P. Mattock
  0 siblings, 0 replies; 12+ messages in thread
From: Justin P. Mattock @ 2010-05-19 22:45 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Andi Kleen, Linux Kernel Mailing List, eric.dumazet, Ingo Molnar,
	Siddha, Suresh B, Thomas Gleixner, Avi Kivity

On 05/19/2010 07:08 AM, H. Peter Anvin wrote:
> On 05/19/2010 06:38 AM, Andi Kleen wrote:
>> "H. Peter Anvin"<hpa@zytor.com>  writes:
>>>
>>> If there isn't a reason to preserve support, I would like to consider
>>> discontinue support for using gcc 3 to compile x86 kernels.  If there is
>>> a valid use case, it would be good to know what it is.
>>
>> I suspect there are still distributions around that use it as a standard
>> compiler. Wasn't it used in some major release of Debian?
>>
>> -Andi
>
> There are, but that doesn't mean it's relevant for people to compile
> bleeding-edge kernels with it.
>
> 	-hpa
>

no need for it here(using 4.6.0)..
Any distro still using this version
should upgrade(but who am I to say anything)

cheers.

Justin P. Mattock

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for x86 anymore?
  2010-05-18 21:38         ` Does anyone care about gcc 3.x support for x86 anymore? H. Peter Anvin
@ 2010-05-19 23:10           ` Mauro Carvalho Chehab
  2010-05-20  0:39             ` H. Peter Anvin
  2010-05-20  0:42             ` H. Peter Anvin
  0 siblings, 2 replies; 12+ messages in thread
From: Mauro Carvalho Chehab @ 2010-05-19 23:10 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Eric Dumazet, mingo, linux-kernel, suresh.b.siddha, tglx, avi,
	linux-tip-commits

H. Peter Anvin wrote:
> Recently, we have seen an increasing number of problems with gcc 3.4 on
> x86; mostly due to poor constant propagation producing not just bad code
> but failing to properly eliminate what should be dead code.

I don't see any problem, as, if people are using gcc3, they are probably
not interested on the bleeding edge kernel. 

However, if the problems are just performance/dead code removal, I would 
just add a big warning if someone tries to compile x86 with it. I don't 
like very much the idea of having different minimum gcc requirements 
for each architecture, except if gcc is producing a broken code. 

Currently,Documentation/Changes list just a common minimal list for
everything - although the text describing gcc say that the "version 
requirements" may vary for each CPU type.

-- 

Cheers,
Mauro

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for x86 anymore?
  2010-05-19 23:10           ` Mauro Carvalho Chehab
@ 2010-05-20  0:39             ` H. Peter Anvin
  2010-05-20  0:42             ` H. Peter Anvin
  1 sibling, 0 replies; 12+ messages in thread
From: H. Peter Anvin @ 2010-05-20  0:39 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Eric Dumazet, mingo, linux-kernel, suresh.b.siddha, tglx, avi,
	linux-tip-commits

On 05/19/2010 04:10 PM, Mauro Carvalho Chehab wrote:
> H. Peter Anvin wrote:
>> Recently, we have seen an increasing number of problems with gcc 3.4 on
>> x86; mostly due to poor constant propagation producing not just bad code
>> but failing to properly eliminate what should be dead code.
> 
> I don't see any problem, as, if people are using gcc3, they are probably
> not interested on the bleeding edge kernel. 
> 
> However, if the problems are just performance/dead code removal, I would 
> just add a big warning if someone tries to compile x86 with it. I don't 
> like very much the idea of having different minimum gcc requirements 
> for each architecture, except if gcc is producing a broken code. 
> 
> Currently,Documentation/Changes list just a common minimal list for
> everything - although the text describing gcc say that the "version 
> requirements" may vary for each CPU type.
> 

We already have different gcc version requirements, whether or not
they're written down is another matter...

	-hpa


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for x86 anymore?
  2010-05-19 23:10           ` Mauro Carvalho Chehab
  2010-05-20  0:39             ` H. Peter Anvin
@ 2010-05-20  0:42             ` H. Peter Anvin
  2010-05-20 12:44               ` Ingo Molnar
  1 sibling, 1 reply; 12+ messages in thread
From: H. Peter Anvin @ 2010-05-20  0:42 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: Eric Dumazet, mingo, linux-kernel, suresh.b.siddha, tglx, avi,
	linux-tip-commits

On 05/19/2010 04:10 PM, Mauro Carvalho Chehab wrote:
> 
> However, if the problems are just performance/dead code removal, I would 
> just add a big warning if someone tries to compile x86 with it. I don't 
> like very much the idea of having different minimum gcc requirements 
> for each architecture, except if gcc is producing a broken code. 
> 

I should clarify the problem.  The problems we have seen are related to
constant propagation, which causes gcc3 to die when there is an assembly
constraint like:

	asm("..." : : "i" (foo));

... since "foo" isn't constant as far as it is concerned.  We can put in
workarounds, but it's real effort to keep it alive that probably isn't
well spent.

Similarly, lack of constant propagation can cause code that should have
been compile-time removed to still be there, causing link failures.

	-hpa

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for x86 anymore?
  2010-05-20  0:42             ` H. Peter Anvin
@ 2010-05-20 12:44               ` Ingo Molnar
  0 siblings, 0 replies; 12+ messages in thread
From: Ingo Molnar @ 2010-05-20 12:44 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Mauro Carvalho Chehab, Eric Dumazet, mingo, linux-kernel,
	suresh.b.siddha, tglx, avi, linux-tip-commits


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 05/19/2010 04:10 PM, Mauro Carvalho Chehab wrote:
> > 
> > However, if the problems are just performance/dead 
> > code removal, I would just add a big warning if 
> > someone tries to compile x86 with it. I don't like 
> > very much the idea of having different minimum gcc 
> > requirements for each architecture, except if gcc is 
> > producing a broken code.
> > 
> 
> I should clarify the problem.  The problems we have seen 
> are related to constant propagation, which causes gcc3 
> to die when there is an assembly constraint like:
> 
> 	asm("..." : : "i" (foo));
> 
> ... since "foo" isn't constant as far as it is 
> concerned.  We can put in workarounds, but it's real 
> effort to keep it alive that probably isn't well spent.
> 
> Similarly, lack of constant propagation can cause code 
> that should have been compile-time removed to still be 
> there, causing link failures.

Put in a deprecation warning first perhaps?

	Ingo

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for *x86* anymore?
  2010-05-19 13:38 ` Andi Kleen
  2010-05-19 14:08   ` H. Peter Anvin
@ 2010-05-20 18:37   ` Martin Michlmayr
  2010-05-20 19:56     ` Miguel Ojeda
  1 sibling, 1 reply; 12+ messages in thread
From: Martin Michlmayr @ 2010-05-20 18:37 UTC (permalink / raw)
  To: Andi Kleen
  Cc: H. Peter Anvin, Linux Kernel Mailing List, eric.dumazet,
	Ingo Molnar, Siddha, Suresh B, Thomas Gleixner, Avi Kivity

* Andi Kleen <andi@firstfloor.org> [2010-05-19 15:38]:
> > If there isn't a reason to preserve support, I would like to consider
> > discontinue support for using gcc 3 to compile x86 kernels.  If there is
> > a valid use case, it would be good to know what it is.
> 
> I suspect there are still distributions around that use it as a standard
> compiler. Wasn't it used in some major release of Debian?

Not in a recent one, no.
-- 
Martin Michlmayr
http://www.cyrius.com/

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Does anyone care about gcc 3.x support for *x86* anymore?
  2010-05-20 18:37   ` Martin Michlmayr
@ 2010-05-20 19:56     ` Miguel Ojeda
  0 siblings, 0 replies; 12+ messages in thread
From: Miguel Ojeda @ 2010-05-20 19:56 UTC (permalink / raw)
  To: Martin Michlmayr
  Cc: Andi Kleen, H. Peter Anvin, Linux Kernel Mailing List,
	eric.dumazet, Ingo Molnar, Siddha, Suresh B, Thomas Gleixner,
	Avi Kivity

On Thu, May 20, 2010 at 8:37 PM, Martin Michlmayr <tbm@cyrius.com> wrote:
> * Andi Kleen <andi@firstfloor.org> [2010-05-19 15:38]:
>> > If there isn't a reason to preserve support, I would like to consider
>> > discontinue support for using gcc 3 to compile x86 kernels.  If there is
>> > a valid use case, it would be good to know what it is.
>>
>> I suspect there are still distributions around that use it as a standard
>> compiler. Wasn't it used in some major release of Debian?
>
> Not in a recent one, no.

Not even in oldstable (etch).

> --
> Martin Michlmayr
> http://www.cyrius.com/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2010-05-20 19:56 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-19  1:19 Does anyone care about gcc 3.x support for *x86* anymore? H. Peter Anvin
2010-05-19  7:13 ` Ingo Molnar
2010-05-19 13:38 ` Andi Kleen
2010-05-19 14:08   ` H. Peter Anvin
2010-05-19 22:45     ` Justin P. Mattock
2010-05-20 18:37   ` Martin Michlmayr
2010-05-20 19:56     ` Miguel Ojeda
  -- strict thread matches above, loose matches on Subject: below --
2010-05-06  8:45 [PATCH v3 1/2] x86: eliminate TS_XSAVE Avi Kivity
2010-05-12  1:06 ` [tip:x86/fpu] x86: Add new static_cpu_has() function using alternatives tip-bot for H. Peter Anvin
2010-05-18 20:10   ` Eric Dumazet
2010-05-18 20:57     ` H. Peter Anvin
2010-05-18 21:11       ` Eric Dumazet
2010-05-18 21:38         ` Does anyone care about gcc 3.x support for x86 anymore? H. Peter Anvin
2010-05-19 23:10           ` Mauro Carvalho Chehab
2010-05-20  0:39             ` H. Peter Anvin
2010-05-20  0:42             ` H. Peter Anvin
2010-05-20 12:44               ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).