linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Jens.Kuenzer@fpga.homeip.net, linux-pcmcia@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][bisected]pcmcia:yenta_socket.c fix broken wireless cards.
Date: Thu, 20 May 2010 09:46:32 -0700	[thread overview]
Message-ID: <4BF56768.5080704@gmail.com> (raw)
In-Reply-To: <20100520163419.GA16522@comet.dominikbrodowski.net>

On 05/20/2010 09:34 AM, Dominik Brodowski wrote:
> Jens, Justin,
>
> could both of you test this patch on top of 2.6.34, please?
>
> pcmcia: only keep saved I365_CSCING flag if there is no PCI irq
>
> Signed-off-by: Dominik Brodowski<linux@dominikbrodowski.net>
>
> diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
> index 424e576..151ca43 100644
> --- a/drivers/pcmcia/yenta_socket.c
> +++ b/drivers/pcmcia/yenta_socket.c
> @@ -371,8 +371,11 @@ static int yenta_set_socket(struct pcmcia_socket *sock, socket_state_t *state)
>   			exca_writeb(socket, I365_POWER, reg);
>
>   		/* CSC interrupt: no ISA irq for CSC */
> -		reg = exca_readb(socket, I365_CSCINT);
> -		reg&= I365_CSC_IRQ_MASK;
> +		reg = 0;
> +		if (!socket->dev->irq) {
> +			reg = exca_readb(socket, I365_CSCINT);
> +			reg&= I365_CSC_IRQ_MASK;
> +		}
>   		reg |= I365_CSC_DETECT;
>   		if (state->flags&  SS_IOCARD) {
>   			if (state->csc_mask&  SS_STSCHG)
>


o.k., I just did a git pull
to the current, now waiting
(compiling)very slow machine) then I'll
verify or not, if a fix has already been
pushed forward, if not then I'll apply
your patch.

Thanks for taking the time with this.

Justin P. Mattock

  reply	other threads:[~2010-05-20 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 21:08 [PATCH][bisected]pcmcia:yenta_socket.c fix broken wireless cards Justin P. Mattock
2010-05-20 14:54 ` Dominik Brodowski
2010-05-20 15:52   ` Justin P. Mattock
2010-05-20 16:34     ` Dominik Brodowski
2010-05-20 16:46       ` Justin P. Mattock [this message]
2010-05-20 17:44       ` Justin P. Mattock
2010-05-21 13:16         ` Dominik Brodowski
2010-05-20 20:10       ` Justin P. Mattock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF56768.5080704@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=Jens.Kuenzer@fpga.homeip.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).