Re: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

Re: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

[Pekka Enberg]

Alexander Duyck wrote:
> This patch is meant to improve the performance of SLUB by moving the local
> kmem_cache_node lock into it's own cacheline separate from kmem_cache.
> This is accomplished by simply removing the local_node when NUMA is enabled.
> 
> On my system with 2 nodes I saw around a 5% performance increase w/
> hackbench times dropping from 6.2 seconds to 5.9 seconds on average.  I
> suspect the performance gain would increase as the number of nodes
> increases, but I do not have the data to currently back that up.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>

Thanks for the fix, Alexander!

Yanmin and Alex, can I have your Tested-by or Acked-by please so we can 
close "[Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e" 
after this patch is merged?

			Pekka

RE: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

[Shi, Alex]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1364 bytes --]

sure. glad to a fix on this! 
 

-----Original Message-----
From: Pekka Enberg [mailto:penberg@cs.helsinki.fi] 
Sent: 2010Äê5ÔÂ22ÈÕ 16:36
To: Duyck, Alexander H
Cc: cl@linux.com; linux-mm@kvack.org; Shi, Alex; yanmin_zhang@linux.intel.com; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; rjw@sisk.pl
Subject: Re: [PATCH v2] slub: move kmem_cache_node into it's own cacheline

Alexander Duyck wrote:
> This patch is meant to improve the performance of SLUB by moving the 
> local kmem_cache_node lock into it's own cacheline separate from kmem_cache.
> This is accomplished by simply removing the local_node when NUMA is enabled.
> 
> On my system with 2 nodes I saw around a 5% performance increase w/ 
> hackbench times dropping from 6.2 seconds to 5.9 seconds on average.  
> I suspect the performance gain would increase as the number of nodes 
> increases, but I do not have the data to currently back that up.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>

Thanks for the fix, Alexander!

Yanmin and Alex, can I have your Tested-by or Acked-by please so we can close "[Bug #15713] hackbench regression due to commit 9dfc6e68bfe6e" 
after this patch is merged?

			Pekka
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥