From: Avi Kivity <avi@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: MMU: allow more page become unsync at gfn mapping time
Date: Mon, 24 May 2010 09:24:20 +0300 [thread overview]
Message-ID: <4BFA1B94.9010403@redhat.com> (raw)
In-Reply-To: <4BF9DE88.4060609@cn.fujitsu.com>
On 05/24/2010 05:03 AM, Xiao Guangrong wrote:
>
> Avi Kivity wrote:
>
>
>>> + if (need_unsync)
>>> + kvm_unsync_pages(vcpu, gfn);
>>> return 0;
>>> }
>>>
>>>
>>>
>> Looks good, I'm just uncertain about role.invalid handling. What's the
>> reasoning here?
>>
>>
> Avi,
>
> Thanks for your reply.
>
> We no need worry about 'role.invalid' here, since we only allow the PTE shadow
> pages(role.level == 1) become unsync, and in current code, 'role.invalid' is only
> used for root shadow pages.
>
Right, the invlpg change is not it yet. But I think it should be in
this patch; I don't like subtle dependencies, and it will make the
invplg patch simpler.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-05-24 6:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 12:14 [PATCH 1/2] KVM: MMU: allow more page become unsync at gfn mapping time Xiao Guangrong
2010-05-23 12:16 ` [PATCH 2/2] KVM: MMU: allow more page become unsync at getting sp time Xiao Guangrong
2010-05-23 14:11 ` Avi Kivity
2010-05-24 2:31 ` Xiao Guangrong
2010-05-24 6:25 ` Avi Kivity
2010-05-24 7:41 ` [PATCH 2/2 v2] " Xiao Guangrong
2010-05-25 9:32 ` Avi Kivity
2010-05-23 13:51 ` [PATCH 1/2] KVM: MMU: allow more page become unsync at gfn mapping time Avi Kivity
2010-05-24 2:03 ` Xiao Guangrong
2010-05-24 6:24 ` Avi Kivity [this message]
2010-05-24 7:14 ` Xiao Guangrong
2010-05-24 7:40 ` [PATCH 1/2 v2] " Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFA1B94.9010403@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).