From: Cong Wang <amwang@redhat.com>
To: "J. R. Okajima" <hooanon05@yahoo.co.jp>
Cc: opurdila@ixiacom.com, davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: proc_dointvec() and write
Date: Tue, 25 May 2010 13:35:19 +0800 [thread overview]
Message-ID: <4BFB6197.5030206@redhat.com> (raw)
In-Reply-To: <11729.1274763460@jrobl>
On 05/25/10 12:57, J. R. Okajima wrote:
> Cong Wang:
>> Hmm, odd, I tested other proc files, I see no problem.
>> I am wondering why /proc/sys/kernel/printk is special here.
>
> The condition is,
> - the entry has multiple values, .maxlen = N * sizeof(foo)
> - the entry is writable, .mode = 0644 (or something)
>
> In sysctl.c, only "printk" and "acct" match.
Hmm, right, I missed this case during testing.
Your patch looks correct for me. Would you mind to send your
patch again with your Signed-off-by?
Thank you!
next prev parent reply other threads:[~2010-05-25 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 14:32 proc_dointvec() and write J. R. Okajima
2010-05-25 4:49 ` Cong Wang
2010-05-25 4:57 ` J. R. Okajima
2010-05-25 5:35 ` Cong Wang [this message]
2010-05-25 6:49 ` [PATCH] proc_dointvec, write a single value J. R. Okajima
2010-05-25 12:23 ` Cong Wang
2010-05-25 23:10 ` David Miller
2010-05-30 15:09 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFB6197.5030206@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=hooanon05@yahoo.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).