From: Carsten Emde <C.Emde@osadl.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 2/4] tracing/sched: Fix task states in sched switch event
Date: Tue, 25 May 2010 14:33:23 +0200 [thread overview]
Message-ID: <4BFBC393.50207@osadl.org> (raw)
In-Reply-To: <20100513133539.GA17107@elte.hu>
Hi Ingo,
>>> Hm, this is totally unreadable. What does 'TASK_STATE_X' mean??
>> Would this be better?
>> +#define MAKE_TASK_STATE_STRING(num) TASK_STATE_##num " (" DESCR_TASK_STATE_##num ")"
>> static const char *task_state_array[] = {
>> - "R (running)", /* 0 */
>> - "S (sleeping)", /* 1 */
>> - "D (disk sleep)", /* 2 */
>> - "T (stopped)", /* 4 */
>> - "t (tracing stop)", /* 8 */
>> - "Z (zombie)", /* 16 */
>> - "X (dead)", /* 32 */
>> - "x (dead)", /* 64 */
>> - "K (wakekill)", /* 128 */
>> - "W (waking)", /* 256 */
>> + MAKE_TASK_STATE_STRING(0),
>> + MAKE_TASK_STATE_STRING(1),
>> + MAKE_TASK_STATE_STRING(2),
>> + MAKE_TASK_STATE_STRING(4),
>> + MAKE_TASK_STATE_STRING(8),
>> + MAKE_TASK_STATE_STRING(16),
>> + MAKE_TASK_STATE_STRING(32),
>> + MAKE_TASK_STATE_STRING(64),
>> + MAKE_TASK_STATE_STRING(128),
>> + MAKE_TASK_STATE_STRING(256)
>
> The whole enumeration there is pointless in that .c file - it tells nothing to
> the code reader.
>
> If it cannot be expressed in a meaningful way then introduce
> TASK_STATE_STRINGS_INIT construct that is defined next to the strings (in a .h
> file or so) - that way it's a coherent whole.
This is what I did and submitted some time ago. Is there anything else
you want me to change?
Thanks,
Carsten.
next prev parent reply other threads:[~2010-05-25 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 11:10 [PATCH 2/4] tracing/sched: Fix task states in sched switch event Carsten Emde
2010-05-13 13:35 ` Ingo Molnar
2010-05-13 15:21 ` Steven Rostedt
2010-05-25 12:33 ` Carsten Emde [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-13 1:21 [PATCH 0/4] [GIT PULL] tracing: updates Steven Rostedt
2010-05-13 1:21 ` [PATCH 2/4] tracing/sched: Fix task states in sched switch event Steven Rostedt
2010-05-13 6:15 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFBC393.50207@osadl.org \
--to=c.emde@osadl.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).