From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: adobriyan@gmail.com, nhorman@tuxdriver.com, oleg@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 10/11] rlimits: implement prlimit64 syscall
Date: Wed, 26 May 2010 17:13:38 +0200 [thread overview]
Message-ID: <4BFD3AA2.1090904@gmail.com> (raw)
In-Reply-To: <20100526073045.ea26740f.akpm@linux-foundation.org>
On 05/26/2010 04:30 PM, Andrew Morton wrote:
> main()
> {
> if (clone(...)) {
> while (wait_for_message(&m))
> setrlimit(m);
> }
>
> ...
> }
>
> ?
Hmm. Probably I'm still missing something obvious, but how does this
help for existing services like databases and/or closed-source products?
Or do you mean to provide this as a library
(s@main@__attribute__((constructor)) my_main@ then) and link (or even
preload) to the programs people want to change limits on-the-fly in?
(And clone with THREAD flag to share task_struct->signal.)
But this approach can only help for the parent of all the forked-later
processes. Especially if a process forks and exits (i.e. creates a
daemon), the child running in the background doesn't have the
wait_for_message thread. So if it forks again (e.g. to service a new
request) the limits cannot be changed in any of them.
This can be solved by adding such a cloned-thread loop into every forked
child, but I'm not sure this is something we want.
In addition, people don't know which process will need to change limits
in advance. Every single binary would have to contain such code.
--
js
next prev parent reply other threads:[~2010-05-26 15:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 18:00 [PATCH v3 01/11] rlimits: security, add task_struct to setrlimit Jiri Slaby
2010-05-10 18:00 ` [PATCH v3 02/11] rlimits: add task_struct to update_rlimit_cpu Jiri Slaby
2010-05-10 18:00 ` [PATCH v3 03/11] rlimits: make sure ->rlim_max never grows in sys_setrlimit Jiri Slaby
2010-05-10 18:00 ` [PATCH v3 04/11] rlimits: split sys_setrlimit Jiri Slaby
2010-05-10 18:00 ` [PATCH v3 05/11] rlimits: allow setrlimit to non-current tasks Jiri Slaby
2010-05-13 22:56 ` Andrew Morton
2010-06-06 20:23 ` [PATCH v3 06/11] rlimits: do security check under task_lock Jiri Slaby
2010-06-07 18:08 ` Oleg Nesterov
2010-06-23 15:20 ` Jiri Slaby
2010-06-23 16:12 ` Oleg Nesterov
2010-06-23 17:44 ` Jiri Slaby
2010-06-23 17:56 ` Oleg Nesterov
2010-06-23 21:35 ` Jiri Slaby
2010-06-23 18:37 ` Stephen Smalley
2010-05-10 18:00 ` Jiri Slaby
2010-05-13 22:56 ` Andrew Morton
2010-05-10 18:00 ` [PATCH v3 07/11] rlimits: add rlimit64 structure Jiri Slaby
2010-05-10 18:00 ` [PATCH v3 08/11] rlimits: redo do_setrlimit to more generic do_prlimit Jiri Slaby
2010-05-10 18:00 ` [PATCH v3 09/11] rlimits: switch more rlimit syscalls to do_prlimit Jiri Slaby
2010-05-10 18:00 ` [PATCH v3 10/11] rlimits: implement prlimit64 syscall Jiri Slaby
2010-05-13 22:56 ` Andrew Morton
2010-05-26 12:58 ` Jiri Slaby
2010-05-26 14:30 ` Andrew Morton
2010-05-26 15:13 ` Jiri Slaby [this message]
2010-05-10 18:00 ` [PATCH v3 11/11] unistd: add __NR_prlimit64 syscall numbers Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFD3AA2.1090904@gmail.com \
--to=jirislaby@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox